You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:55:15 UTC

[GitHub] [flink] azagrebin commented on a change in pull request #12304: [FLINK-15620] Remove deprecated enable default background cleanup

azagrebin commented on a change in pull request #12304:
URL: https://github.com/apache/flink/pull/12304#discussion_r430222969



##########
File path: flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java
##########
@@ -282,7 +282,7 @@ public Builder cleanupIncrementally(
 		 * https://github.com/facebook/rocksdb/blob/master/include/rocksdb/compaction_filter.h#L69
 		 * It means that the TTL filter should be tested for List state taking into account this caveat.
 		 *
-		 * @deprecated Use more general configuration method {@link #cleanupInBackground()} instead
+		 * @deprecated

Review comment:
       This should be addressed in #12307.

##########
File path: flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java
##########
@@ -282,7 +282,7 @@ public Builder cleanupIncrementally(
 		 * https://github.com/facebook/rocksdb/blob/master/include/rocksdb/compaction_filter.h#L69
 		 * It means that the TTL filter should be tested for List state taking into account this caveat.
 		 *
-		 * @deprecated Use more general configuration method {@link #cleanupInBackground()} instead
+		 * @deprecated

Review comment:
       ```suggestion
   		 * @deprecated Use more general configuration method {@link #cleanupInRocksdbCompactFilter(long)} instead
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org