You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "mattcasters (via GitHub)" <gi...@apache.org> on 2026/08/27 08:14:54 UTC

[I] [Task]: Implement GuiWidgetGroupType.BOXES in GuiCompositeWidgets (hop)

mattcasters opened a new issue, #8117:
URL: https://github.com/apache/hop/issues/8117

   ### What needs to happen?
   
   `GuiWidgetGroupType` already defines `BOXES` (alongside `TABS` and `LIST`), and `@GuiWidgetElement` fields can set `group` + `groupType = GuiWidgetGroupType.BOXES`. `GuiCompositeWidgets.layoutElements()` does not implement that layout yet: any non-`TABS` group type logs *"is not implemented yet; showing tabs"* and always calls `layoutTabs()`.
   
   BOXES should stack one SWT `Group` per annotated `group`, filling the space between the dialog header and the button bar, with a `ScrolledComposite` inside each box (same fill-and-scroll idea as tabs, without a tab folder). That keeps OK/Cancel pinned to the bottom of a resizable dialog instead of overlapping the lower widgets.
   
   This is a small, localized change:
   
   - Add `layoutBoxes()` next to `layoutTabs()` in `ui/.../GuiCompositeWidgets.java`.
   - Branch on `GuiWidgetGroups.typeOf(...)` in `layoutElements()` instead of always falling through to tabs.
   - Reuse `addCompositeWidgets()` and `registerExtraGroup()` extras per group.
   - Cover it in `GuiCompositeWidgetsGroupTest` (BOXES should produce `org.eclipse.swt.widgets.Group`, not `CTabFolder`).
   
   `DataSetOutputMeta` already annotates its dialog fields with `groupType = BOXES` and `group = "Data Set"` and can be used as a visual check once this lands. `LIST` can stay a later follow-up.
   
   ### Issue Priority
   
   Priority: 3
   
   ### Issue Component
   
   Component: Hop Gui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task]: Implement GuiWidgetGroupType.BOXES in GuiCompositeWidgets (hop)

Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters closed issue #8117: [Task]: Implement GuiWidgetGroupType.BOXES in GuiCompositeWidgets
URL: https://github.com/apache/hop/issues/8117


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org