You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <hu...@gmail.com> on 2015/12/03 00:15:31 UTC
Review Request 40886: Adding additional unit tests for
GMSHealthMonitor and GMSJoinLeave
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40886/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Lynn Gallinat.
Repository: geode
Description
-------
Adding additional unit tests
minor refactoring to allow testing
Moved GMSHealthMonitorJUnitTest to package level that corresponds with GMSHealthMonitor
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 10478b7
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java fcda1a0
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 2f9c514
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java PRE-CREATION
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java e49e4ae
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/fd/GMSHealthMonitorJUnitTest.java 41a99a6
Diff: https://reviews.apache.org/r/40886/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 40886: Adding additional unit tests for
GMSHealthMonitor and GMSJoinLeave
Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40886/#review108749
-----------------------------------------------------------
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java (line 206)
<https://reviews.apache.org/r/40886/#comment168213>
Just putting in a marker to either refactor to call checkmember directly or pull anything with a time/sleep into an integration test.
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java (line 459)
<https://reviews.apache.org/r/40886/#comment168211>
This is where the new tests I added begin.
- Jason Huynh
On Dec. 2, 2015, 11:15 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40886/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 11:15 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Lynn Gallinat.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Adding additional unit tests
> minor refactoring to allow testing
> Moved GMSHealthMonitorJUnitTest to package level that corresponds with GMSHealthMonitor
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 10478b7
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java fcda1a0
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 2f9c514
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java PRE-CREATION
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java e49e4ae
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/fd/GMSHealthMonitorJUnitTest.java 41a99a6
>
> Diff: https://reviews.apache.org/r/40886/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 40886: Adding additional unit tests for
GMSHealthMonitor and GMSJoinLeave
Posted by Jason Huynh <hu...@gmail.com>.
> On Dec. 4, 2015, 12:47 a.m., Bruce Schuchardt wrote:
> > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java, line 462
> > <https://reviews.apache.org/r/40886/diff/1/?file=1151860#file1151860line462>
> >
> > add socket.close() to this and other test methods creating sockets?
Thanks Bruce, I ended up using a try-with-resources statement from java 8.
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40886/#review108921
-----------------------------------------------------------
On Dec. 2, 2015, 11:15 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40886/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 11:15 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Lynn Gallinat.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Adding additional unit tests
> minor refactoring to allow testing
> Moved GMSHealthMonitorJUnitTest to package level that corresponds with GMSHealthMonitor
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 10478b7
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java fcda1a0
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 2f9c514
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java PRE-CREATION
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java e49e4ae
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/fd/GMSHealthMonitorJUnitTest.java 41a99a6
>
> Diff: https://reviews.apache.org/r/40886/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 40886: Adding additional unit tests for
GMSHealthMonitor and GMSJoinLeave
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40886/#review108921
-----------------------------------------------------------
Nice work, and thank you for moving the class to the correct package. If you add socket.close() to the new methods that are creating sockets I think you can check this in.
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java (line 462)
<https://reviews.apache.org/r/40886/#comment168376>
add socket.close() to this and other test methods creating sockets?
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java (line 493)
<https://reviews.apache.org/r/40886/#comment168377>
nice work
- Bruce Schuchardt
On Dec. 2, 2015, 11:15 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40886/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 11:15 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Lynn Gallinat.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Adding additional unit tests
> minor refactoring to allow testing
> Moved GMSHealthMonitorJUnitTest to package level that corresponds with GMSHealthMonitor
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 10478b7
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java fcda1a0
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 2f9c514
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java PRE-CREATION
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java e49e4ae
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/fd/GMSHealthMonitorJUnitTest.java 41a99a6
>
> Diff: https://reviews.apache.org/r/40886/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>