[jira] Commented: (HADOOP-4170) delay in TestCLI teardown

["Owen O'Malley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631163#action_12631163 ] 

Owen O'Malley commented on HADOOP-4170:
---------------------------------------

Clearly, waits are not a good synchronization mechanism. It looks like that code was from the original checkin and Makund isn't watching the lists any more. Please fix it.

> delay in TestCLI teardown
> -------------------------
>
>                 Key: HADOOP-4170
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4170
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.19.0
>            Reporter: Steve Loughran
>            Priority: Minor
>
> Before I have a go at cleaning it up, can I check to see if there is a reason for this code in TestCLI.teardown()
>     success = true;
>     Thread.sleep(2000);
>     assertTrue("Error tearing down Mini DFS cluster", success);
> It sets a flag that is always true, and sleeps for 2 seconds. If shutdown is really needed, it should be checked for, and if not, the sleep and the assert culled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.