You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/06/05 10:23:37 UTC

[GitHub] [spark] gaborgsomogyi commented on issue #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor.

gaborgsomogyi commented on issue #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor.
URL: https://github.com/apache/spark/pull/24804#issuecomment-499027335
 
 
   cc @vanzin @squito @rdblue  since you were involved in the previous PR.
   
   I've considered many options but this looks the best from my perspective.
   I personally don't like the fact that it's not possible to concatenate options (just like Imran) but I think introducing it would produce more problems than solutions. Setting it in one (now two) places requires attention from user side (more coding to merge options properly) but then I think it's more clear what exactly will be set.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org