You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "hua74ni (via GitHub)" <gi...@apache.org> on 2023/03/17 17:56:32 UTC

[GitHub] [shardingsphere] hua74ni opened a new pull request, #24669: fix ReadwriteRule checkReadeDataSource and test

hua74ni opened a new pull request, #24669:
URL: https://github.com/apache/shardingsphere/pull/24669

   Changes proposed in this pull request:
     - fix ReadwriteRule checkReadeDataSource and test(The problem is that the readwrite splitting rule the slave dataSource are not verified as expected) 
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] zhaojinchao95 merged pull request #24669: fix ReadwriteRule checkReadeDataSource and test

Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 merged PR #24669:
URL: https://github.com/apache/shardingsphere/pull/24669


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] hua74ni commented on pull request #24669: fix ReadwriteRule checkReadeDataSource and test

Posted by "hua74ni (via GitHub)" <gi...@apache.org>.
hua74ni commented on PR #24669:
URL: https://github.com/apache/shardingsphere/pull/24669#issuecomment-1477250400

   What else I need to do for this PR @gxxiong 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] zhaojinchao95 commented on pull request #24669: fix ReadwriteRule checkReadeDataSource and test

Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on PR #24669:
URL: https://github.com/apache/shardingsphere/pull/24669#issuecomment-1478987618

   > What else I need to do for this PR @gxxiong
   
   Thx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org