You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/02/16 09:21:57 UTC
[PR] refactor(consensus): decouple pipeline from VsrConsensus internals [iggy]
hubcio opened a new pull request, #2740:
URL: https://github.com/apache/iggy/pull/2740
VsrConsensus hardcoded LocalPipeline and PipelineEntry stored
full Message<PrepareHeader> (header + body), even though only
the header is needed for quorum tracking. This coupled the
consensus pipeline to a specific implementation and wasted
memory on message bodies that already live in the journal.
Parameterize VsrConsensus<B, P = LocalPipeline> over the
Pipeline trait so implementations can be swapped.
Slim PipelineEntry to store only PrepareHeader; at commit
time on_ack fetches the full message from the journal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(consensus): decouple pipeline from VsrConsensus internals [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2740:
URL: https://github.com/apache/iggy/pull/2740#issuecomment-3907462883
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/2740?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `38 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.94%. Comparing base ([`88a598a`](https://app.codecov.io/gh/apache/iggy/commit/88a598ad91bac00188d75731dcca866deb65def7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8881adc`](https://app.codecov.io/gh/apache/iggy/commit/8881adcd62441846ac1c0593eb1267539dc5a2d9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/2740?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [core/consensus/src/impls.rs](https://app.codecov.io/gh/apache/iggy/pull/2740?src=pr&el=tree&filepath=core%2Fconsensus%2Fsrc%2Fimpls.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25zZW5zdXMvc3JjL2ltcGxzLnJz) | 0.00% | [23 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/2740?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [core/metadata/src/impls/metadata.rs](https://app.codecov.io/gh/apache/iggy/pull/2740?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fimpls%2Fmetadata.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvaW1wbHMvbWV0YWRhdGEucnM=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/2740?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [core/simulator/src/replica.rs](https://app.codecov.io/gh/apache/iggy/pull/2740?src=pr&el=tree&filepath=core%2Fsimulator%2Fsrc%2Freplica.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaW11bGF0b3Ivc3JjL3JlcGxpY2EucnM=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/2740?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
:x: Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the [target](https://docs.codecov.com/docs/commit-status#target) coverage.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2740 +/- ##
============================================
- Coverage 68.96% 68.94% -0.02%
Complexity 641 641
============================================
Files 736 736
Lines 60898 60901 +3
Branches 57311 57314 +3
============================================
- Hits 41996 41989 -7
- Misses 16858 16866 +8
- Partials 2044 2046 +2
```
| [Flag](https://app.codecov.io/gh/apache/iggy/pull/2740/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [rust](https://app.codecov.io/gh/apache/iggy/pull/2740/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.19% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/2740?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/simulator/src/deps.rs](https://app.codecov.io/gh/apache/iggy/pull/2740?src=pr&el=tree&filepath=core%2Fsimulator%2Fsrc%2Fdeps.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaW11bGF0b3Ivc3JjL2RlcHMucnM=) | `0.00% <ø> (ø)` | |
| [core/simulator/src/replica.rs](https://app.codecov.io/gh/apache/iggy/pull/2740?src=pr&el=tree&filepath=core%2Fsimulator%2Fsrc%2Freplica.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaW11bGF0b3Ivc3JjL3JlcGxpY2EucnM=) | `0.00% <0.00%> (ø)` | |
| [core/metadata/src/impls/metadata.rs](https://app.codecov.io/gh/apache/iggy/pull/2740?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fimpls%2Fmetadata.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvaW1wbHMvbWV0YWRhdGEucnM=) | `8.04% <0.00%> (-0.13%)` | :arrow_down: |
| [core/consensus/src/impls.rs](https://app.codecov.io/gh/apache/iggy/pull/2740?src=pr&el=tree&filepath=core%2Fconsensus%2Fsrc%2Fimpls.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25zZW5zdXMvc3JjL2ltcGxzLnJz) | `0.00% <0.00%> (ø)` | |
... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/2740/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(consensus): decouple pipeline from VsrConsensus internals [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio merged PR #2740:
URL: https://github.com/apache/iggy/pull/2740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org