You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/28 22:22:38 UTC

[GitHub] [superset] zuzana-vej opened a new pull request #13840: fix(sqllab): warning message when displayed rows limited

zuzana-vej opened a new pull request #13840:
URL: https://github.com/apache/superset/pull/13840


   ### SUMMARY
   Better error message when the displayed rows in SQL Lab are limited to 10000. Based on user feedback, currently the error is not very actionable for user, because the displayed rows are limited to 10000 but if user selected higher limit (e.g. 100 000) in the dropdown limit, they can still get more results (up to the max rows limit base don config) when downloading CSV. Alternatively they can add filters and rerun the query to get less results. 
   
   This new warning message clarifies this for the user making the error more actionable.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   <img width="719" alt="Screen Shot 2021-03-28 at 12 33 00 PM" src="https://user-images.githubusercontent.com/61221714/112769869-582d3e00-8fd8-11eb-9c34-b6fedf50ee0e.png">
   
   
   After:
   ![sqllab_after](https://user-images.githubusercontent.com/61221714/112769850-32079e00-8fd8-11eb-8f18-7b7f72208323.png)
   
   
   ### TEST PLAN
   Validated in local, took screenshots of new warning message.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #13840: fix(sqllab): warning message when displayed rows limited

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13840:
URL: https://github.com/apache/superset/pull/13840#issuecomment-808971279


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13840?src=pr&el=h1) Report
   > Merging [#13840](https://codecov.io/gh/apache/superset/pull/13840?src=pr&el=desc) (15a228b) into [master](https://codecov.io/gh/apache/superset/commit/18ff4841862cd53c92614805ae6db188e3379850?el=desc) (18ff484) will **decrease** coverage by `0.93%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 15a228b differs from pull request most recent head 67046d0. Consider uploading reports for the commit 67046d0 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13840/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13840?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13840      +/-   ##
   ==========================================
   - Coverage   77.22%   76.29%   -0.94%     
   ==========================================
     Files         935      935              
     Lines       47266    47295      +29     
     Branches     5893     5916      +23     
   ==========================================
   - Hits        36502    36083     -419     
   - Misses      10616    11051     +435     
   - Partials      148      161      +13     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `47.98% <0.00%> (-12.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13840?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `61.13% <100.00%> (-7.81%)` | :arrow_down: |
   | [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
   | [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
   | [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
   | [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
   | [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
   | [superset-frontend/src/dataMask/reducer.ts](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL3JlZHVjZXIudHM=) | `44.00% <0.00%> (-56.00%)` | :arrow_down: |
   | [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset-frontend/src/dataMask/actions.ts](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL2FjdGlvbnMudHM=) | `33.33% <0.00%> (-46.67%)` | :arrow_down: |
   | ... and [79 more](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13840?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13840?src=pr&el=footer). Last update [18ff484...67046d0](https://codecov.io/gh/apache/superset/pull/13840?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zuzana-vej closed pull request #13840: fix(sqllab): warning message when displayed rows limited

Posted by GitBox <gi...@apache.org>.
zuzana-vej closed pull request #13840:
URL: https://github.com/apache/superset/pull/13840


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13840: fix(sqllab): warning message when displayed rows limited

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13840:
URL: https://github.com/apache/superset/pull/13840#issuecomment-808971279


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13840?src=pr&el=h1) Report
   > Merging [#13840](https://codecov.io/gh/apache/superset/pull/13840?src=pr&el=desc) (15a228b) into [master](https://codecov.io/gh/apache/superset/commit/18ff4841862cd53c92614805ae6db188e3379850?el=desc) (18ff484) will **increase** coverage by `0.29%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 15a228b differs from pull request most recent head 67046d0. Consider uploading reports for the commit 67046d0 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13840/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13840?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13840      +/-   ##
   ==========================================
   + Coverage   77.22%   77.52%   +0.29%     
   ==========================================
     Files         935      935              
     Lines       47266    47296      +30     
     Branches     5893     5916      +23     
   ==========================================
   + Hits        36502    36664     +162     
   + Misses      10616    10488     -128     
   + Partials      148      144       -4     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.07% <0.00%> (-3.95%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13840?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `61.13% <100.00%> (-7.81%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `61.25% <0.00%> (+1.25%)` | :arrow_up: |
   | [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `73.58% <0.00%> (+1.25%)` | :arrow_up: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <0.00%> (+1.38%)` | :arrow_up: |
   | [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `82.60% <0.00%> (+1.44%)` | :arrow_up: |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.60% <0.00%> (+1.49%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `52.63% <0.00%> (+2.63%)` | :arrow_up: |
   | [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `89.47% <0.00%> (+4.21%)` | :arrow_up: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `63.26% <0.00%> (+4.28%)` | :arrow_up: |
   | ... and [15 more](https://codecov.io/gh/apache/superset/pull/13840/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13840?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13840?src=pr&el=footer). Last update [18ff484...67046d0](https://codecov.io/gh/apache/superset/pull/13840?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org