You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by bt...@apache.org on 2022/03/22 02:03:33 UTC

[james-project] 04/25: JAMES-3722 SELECT + QRESYNC cosmetic fix

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 908d064f6c9966e7d23da23ca2a08127283e7dbf
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Mon Mar 7 22:37:14 2022 +0700

    JAMES-3722 SELECT + QRESYNC cosmetic fix
    
    Avoid intermediate search API data representation for ranges to check for QRESYNC
---
 .../james/imap/processor/AbstractMailboxProcessor.java     | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java b/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java
index ae3b12c..919445f 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java
@@ -61,7 +61,6 @@ import org.apache.james.mailbox.model.ComposedMessageIdWithMetaData;
 import org.apache.james.mailbox.model.MailboxPath;
 import org.apache.james.mailbox.model.MessageRange;
 import org.apache.james.mailbox.model.MessageRange.Type;
-import org.apache.james.mailbox.model.SearchQuery;
 import org.apache.james.metrics.api.MetricFactory;
 import org.apache.james.metrics.api.TimeMetric;
 import org.slf4j.Logger;
@@ -536,16 +535,9 @@ public abstract class AbstractMailboxProcessor<R extends ImapRequest> extends Ab
      */
     protected void respondVanished(SelectedMailbox selectedMailbox, List<MessageRange> ranges, Responder responder) throws MailboxException {
         Set<MessageUid> vanishedUids = new HashSet<>();
-        for (int i = 0; i < ranges.size(); i++) {
-            MessageRange r = ranges.get(i);
-            SearchQuery.UidRange nr;
-            if (r.getType() == Type.ONE) {
-                nr = new SearchQuery.UidRange(r.getUidFrom());
-            } else {
-                nr = new SearchQuery.UidRange(r.getUidFrom(), r.getUidTo());
-            }
-            MessageUid from = nr.getLowValue();
-            MessageUid to = nr.getHighValue();
+        for (MessageRange range : ranges) {
+            MessageUid from = range.getUidFrom();
+            MessageUid to = range.getUidTo();
             while (from.compareTo(to) <= 0) {
                 MessageUid copy = from;
                 selectedMailbox.msn(from).fold(

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org