You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwhisk.apache.org by David P Grove <gr...@us.ibm.com> on 2018/12/06 15:39:06 UTC

Re: "nightly" releases of clis (was Graduation)

Bertrand Delacretaz <bd...@apache.org> wrote on 12/06/2018 03:37:15
AM:
>
> On Tue, Dec 4, 2018 at 12:55 AM Carlos Santana <cs...@gmail.com>
wrote:
> > ...what you mean by releases directly from github
> > without PMC votes?
> > All our releases have gone thru Votes first and then publish into the
> > Apache server, and link in the website.
> > http://openwhisk.incubator.apache.org/downloads.html
>
> I'm thinking for example of
> https://github.com/apache/incubator-openwhisk-wskdeploy/releases
> which seems to be a mix of Apache and non-Apache releases - highly
> confusing if that's the case.

Yes.  The wskdeploy github release page is a mix. This should be addressed
somehow.

>
> I haven't checked all OpenWhisk repositories but there's also at least
> https://github.com/apache/incubator-openwhisk-cli/releases
>
> I don't think the Incubator PMC has voted on those, unless I missed
something.
>

Here I think the problem is the 'latest' tag/release.  This is actually a
nightly build that we need to publish somewhere so that other parts of our
CI/CD pipeline can pick up pre-built CLIs.  If this "release" was named
"nightly" instead of "latest" or otherwise indicated as a non-official
release in the github metadata while still being named "latest", would that
work?

--dave

Re: "nightly" releases of clis (was Graduation)

Posted by Carlos Santana <cs...@gmail.com>.
To help with the confusion I try to clean up the "releases" github pages
for both CLIs wsk and wskdeploy

https://github.com/apache/incubator-openwhisk-wskdeploy/releases
https://github.com/apache/incubator-openwhisk-cli/releases

The tag "latest" means nightly and is mark in red as "pre-release"
Apache OpenWhisk Releases right now should be tag as x.y.z-incubating and
is mark in green "latest-releaes"

Any tags with `x.y.z` this are old before we cut the first Apache OpenWhisk
release.

One weird thing I found was in wskdeploy there is a 0.9;9 and
0.9.8-incubating, I left 0.9.9 just in case someone is using the convenient
binaries
Can't remember if I created that tag or someone else.
But it would not matter that much if we cut another release of the CLIs
soon, and then we can delete this 0.9.8 binaries






On Wed, Dec 12, 2018 at 12:03 AM Bertrand Delacretaz <bd...@apache.org>
wrote:

> Hi Matt,
>
> On Tue, Dec 11, 2018 at 7:32 PM Matt Rutkowski <mr...@us.ibm.com>
> wrote:
> > ...https://github.com/apache/incubator-openwhisk-website/pull/353 ...
>
> Thank you very much for this. I like it, with a few minor comments.
>
> I'd prefer saying "Apache Releases" or "Apache OpenWhisk Releases"
> instead of "Official Releases".
>
> It would be good to link to
> http://www.apache.org/legal/release-policy.html somewhere, to provide
> background information.
>
> > In some special cases, Committers on the project may choose to use
> > GitHub to tag certain builds...
>
> Does that automatically cause those builds to appear as releases like
> at https://github.com/apache/incubator-openwhisk-wskdeploy/releases ?
> If not, GitHub tags are perfectly ok of course, but I think the mix of
> Apache Releases and tagged builds there is a major source of confusion
> and should be avoided.
>
> I would expect tags to appear only at (for example)
> https://github.com/apache/incubator-openwhisk-wskdeploy/tags - and
> document tag naming conventions might be useful for clarity if there
> are none so far.
>
> -Bertrand
>


-- 
Carlos Santana
<cs...@gmail.com>

Re: "nightly" releases of clis (was Graduation)

Posted by Matt Rutkowski <mr...@apache.org>.
Hi Bertrand,

I hope I addressed some of your most recent comments with my PRs today.  Please view the updated page here: https://openwhisk.incubator.apache.org/downloads.html

Thanks,
Matt

On 2018/12/12 08:02:48, Bertrand Delacretaz <bd...@apache.org> wrote: 
> Hi Matt,
> 
> On Tue, Dec 11, 2018 at 7:32 PM Matt Rutkowski <mr...@us.ibm.com> wrote:
> > ...https://github.com/apache/incubator-openwhisk-website/pull/353 ...
> 
> Thank you very much for this. I like it, with a few minor comments.
> 
> I'd prefer saying "Apache Releases" or "Apache OpenWhisk Releases"
> instead of "Official Releases".
> 
> It would be good to link to
> http://www.apache.org/legal/release-policy.html somewhere, to provide
> background information.
> 
> > In some special cases, Committers on the project may choose to use
> > GitHub to tag certain builds...
> 
> Does that automatically cause those builds to appear as releases like
> at https://github.com/apache/incubator-openwhisk-wskdeploy/releases ?
> If not, GitHub tags are perfectly ok of course, but I think the mix of
> Apache Releases and tagged builds there is a major source of confusion
> and should be avoided.
> 
> I would expect tags to appear only at (for example)
> https://github.com/apache/incubator-openwhisk-wskdeploy/tags - and
> document tag naming conventions might be useful for clarity if there
> are none so far.
> 
> -Bertrand
> 

Re: "nightly" releases of clis (was Graduation)

Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi Matt,

On Tue, Dec 11, 2018 at 7:32 PM Matt Rutkowski <mr...@us.ibm.com> wrote:
> ...https://github.com/apache/incubator-openwhisk-website/pull/353 ...

Thank you very much for this. I like it, with a few minor comments.

I'd prefer saying "Apache Releases" or "Apache OpenWhisk Releases"
instead of "Official Releases".

It would be good to link to
http://www.apache.org/legal/release-policy.html somewhere, to provide
background information.

> In some special cases, Committers on the project may choose to use
> GitHub to tag certain builds...

Does that automatically cause those builds to appear as releases like
at https://github.com/apache/incubator-openwhisk-wskdeploy/releases ?
If not, GitHub tags are perfectly ok of course, but I think the mix of
Apache Releases and tagged builds there is a major source of confusion
and should be avoided.

I would expect tags to appear only at (for example)
https://github.com/apache/incubator-openwhisk-wskdeploy/tags - and
document tag naming conventions might be useful for clarity if there
are none so far.

-Bertrand

Re: "nightly" releases of clis (was Graduation)

Posted by Matt Rutkowski <mr...@us.ibm.com>.
In order to address confusion immediately, I created a section named 
"Developer builds" and set about to create unambiguous text to position 
these as unofficial "nightly" (or interim) builds with no status, as well 
as rename the current "Releases" as "Official Releases" and augmented its 
text as well to clarify their standing.

https://github.com/apache/incubator-openwhisk-website/pull/353 - "Clarify 
GitHub nightly-interim releases tags from Apache releases."

Please review/comment... would like to merge the PR if no one has any 
major objections and with all things can accept subsequent PRs/issues if 
we want more changes/text.


Kind regards,
Matt 




From:   "Matt Rutkowski" <mr...@us.ibm.com>
To:     dev@openwhisk.apache.org
Date:   12/10/2018 01:01 PM
Subject:        Re: "nightly" releases of clis (was Graduation)



I will update the release page to explain the purpose of the nightly 
builds.

Kind regards,
Matt 




From:   Bertrand Delacretaz <bd...@apache.org>
To:     dev@openwhisk.apache.org
Date:   12/07/2018 10:33 AM
Subject:        Re: "nightly" releases of clis (was Graduation)



Hi,

On Fri, Dec 7, 2018 at 4:27 PM Carlos Santana <cs...@gmail.com> 
wrote:
> ...Your suggesting that when we do the next source release with a new 
version
> of the CLI we always include a disclaimer clarifying that the nightly
> binary “latest” is not the released version it should not be use...

No - what I suggest is including on the OpenWhisk release management
page a note on the purpose of these nightly builds, so that current
and future (P)PMC members can refer to that and know what is what.

And also remove the confusing mixes of these nightly builds,
unofficial releases (which should not exist) and Apache releases like
at 
https://github.com/apache/incubator-openwhisk-wskdeploy/releases



-Bertrand










Re: "nightly" releases of clis (was Graduation)

Posted by Matt Rutkowski <mr...@us.ibm.com>.
I will update the release page to explain the purpose of the nightly 
builds.

Kind regards,
Matt 




From:   Bertrand Delacretaz <bd...@apache.org>
To:     dev@openwhisk.apache.org
Date:   12/07/2018 10:33 AM
Subject:        Re: "nightly" releases of clis (was Graduation)



Hi,

On Fri, Dec 7, 2018 at 4:27 PM Carlos Santana <cs...@gmail.com> 
wrote:
> ...Your suggesting that when we do the next source release with a new 
version
> of the CLI we always include a disclaimer clarifying that the nightly
> binary “latest” is not the released version it should not be use...

No - what I suggest is including on the OpenWhisk release management
page a note on the purpose of these nightly builds, so that current
and future (P)PMC members can refer to that and know what is what.

And also remove the confusing mixes of these nightly builds,
unofficial releases (which should not exist) and Apache releases like
at 
https://github.com/apache/incubator-openwhisk-wskdeploy/releases


-Bertrand






Re: "nightly" releases of clis (was Graduation)

Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,

On Fri, Dec 7, 2018 at 4:27 PM Carlos Santana <cs...@gmail.com> wrote:
> ...Your suggesting that when we do the next source release with a new version
> of the CLI we always include a disclaimer clarifying that the nightly
> binary “latest” is not the released version it should not be use...

No - what I suggest is including on the OpenWhisk release management
page a note on the purpose of these nightly builds, so that current
and future (P)PMC members can refer to that and know what is what.

And also remove the confusing mixes of these nightly builds,
unofficial releases (which should not exist) and Apache releases like
at https://github.com/apache/incubator-openwhisk-wskdeploy/releases

-Bertrand

Re: "nightly" releases of clis (was Graduation)

Posted by Carlos Santana <cs...@gmail.com>.
This are nightly builds for cicd integration.

We don’t link to them or document them from our website.

Your suggesting that when we do the next source release with a new version
of the CLI we always include a disclaimer clarifying that the nightly
binary “latest” is not the released version it should not be use, that
users to get the released need to go to the website download page and the
correct artifacts will be linked there


On Thu, Dec 6, 2018 at 11:40 AM Bertrand Delacretaz <bd...@apache.org>
wrote:

> Hi Dave,
>
> On Thu, Dec 6, 2018 at 4:40 PM David P Grove <gr...@us.ibm.com> wrote:
> >> ...I haven't checked all OpenWhisk repositories but there's also at
> least
> > > https://github.com/apache/incubator-openwhisk-cli/releases
> >
> > Here I think the problem is the 'latest' tag/release.  This is actually a
> > nightly build that we need to publish somewhere so that other parts of
> our
> > CI/CD pipeline can pick up pre-built CLIs...
>
> Ok, got it. Nightly builds are fine, and having them named "latest" is
> ok as far as I'm concerned but their purpose should be documented in
> the OpenWhisk release instructions so that the intention is clear.
>
> As per http://www.apache.org/legal/release-policy.html#host-rc such
> builds "should not be hosted or linked on pages intended for end
> users" so I think having them in GitHub repositories is fine, that's
> clearly a place for developers.
>
> On the other hand, as you mention, the mix of such builds with Apache
> Releases and "other" releases like at
> https://github.com/apache/incubator-openwhisk-wskdeploy/releases needs
> to be addressed, and OpenWhisk release instructions probably need an
> update to clarify what goes where.
>
> Thanks for your prompt reply on this!
>
> -Bertrand
>
-- 
Carlos Santana
<cs...@gmail.com>

Re: "nightly" releases of clis (was Graduation)

Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi Dave,

On Thu, Dec 6, 2018 at 4:40 PM David P Grove <gr...@us.ibm.com> wrote:
>> ...I haven't checked all OpenWhisk repositories but there's also at least
> > https://github.com/apache/incubator-openwhisk-cli/releases
>
> Here I think the problem is the 'latest' tag/release.  This is actually a
> nightly build that we need to publish somewhere so that other parts of our
> CI/CD pipeline can pick up pre-built CLIs...

Ok, got it. Nightly builds are fine, and having them named "latest" is
ok as far as I'm concerned but their purpose should be documented in
the OpenWhisk release instructions so that the intention is clear.

As per http://www.apache.org/legal/release-policy.html#host-rc such
builds "should not be hosted or linked on pages intended for end
users" so I think having them in GitHub repositories is fine, that's
clearly a place for developers.

On the other hand, as you mention, the mix of such builds with Apache
Releases and "other" releases like at
https://github.com/apache/incubator-openwhisk-wskdeploy/releases needs
to be addressed, and OpenWhisk release instructions probably need an
update to clarify what goes where.

Thanks for your prompt reply on this!

-Bertrand