You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by "Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org> on 2019/05/24 07:23:00 UTC

[jira] [Commented] (RATIS-568) Server sliding window should fail out of order requests on close

    [ https://issues.apache.org/jira/browse/RATIS-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847302#comment-16847302 ] 

Tsz Wo Nicholas Sze commented on RATIS-568:
-------------------------------------------

The current code is not easy to add a test for this specific case.  Filed RATIS-565 to do some refactoring.

> Server sliding window should fail out of order requests on close
> ----------------------------------------------------------------
>
>                 Key: RATIS-568
>                 URL: https://issues.apache.org/jira/browse/RATIS-568
>             Project: Ratis
>          Issue Type: Bug
>          Components: gRPC
>            Reporter: Lokesh Jain
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Major
>         Attachments: r568_20190524.patch
>
>
> Currently SlidingWindow does not fail the out of order requests on close. The out of order requests are not processed and are therefore never removed from the queue leading to memory leak. Further OrderedRequestStreamObserver should be removed from the orderedStreamObservers map on error or completion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)