You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2014/09/23 13:44:51 UTC

[Bug 57005] New: maven build for jdbc-pool broken with Java 8 because of javadoc problems

https://issues.apache.org/bugzilla/show_bug.cgi?id=57005

            Bug ID: 57005
           Summary: maven build for jdbc-pool broken with Java 8 because
                    of javadoc problems
           Product: Tomcat Modules
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: jdbc-pool
          Assignee: dev@tomcat.apache.org
          Reporter: pierre.viret@gmail.com

The maven build for jdbc-pool crashes while creating the javadoc with following
error:
/Users/viretp/Dev/apache/tomcat/sandbox/trunk-maven-layout/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSource.java:66:
error: self-closing element not allowed
* Unregisters the underlying connection pool mbean.<br/>
^

The problem is, that java 8 has become more strict with javadoc and per default
javadoc will exits with an error if the syntax is not absolutely http
conformed.

How to repeat: (be sure to have java 8 version active)
  cd modules/jdbc-pool
  mvm clean install -DskipTests

There are at minimum 2 solutions for this:
1) fix the javadoc
   --> this is my preferred option because the quality of the documentation
will be better. In some cases the syntax errors would avoid some informations
to be properly displayed in the final javadoc.
2) setup the javadoc plugin in maven to use a special flag to disable the
syntax verification.
   --> no need to update the sources but the real problems are not solved with
this solution.

More information for this problem can be found here:
http://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html

If nobody fixes this before and if I come to this I will fix the javadoc and
upload the patch here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 57005] maven build for jdbc-pool broken with Java 8 because of javadoc problems

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57005

--- Comment #1 from Konstantin Kolinko <kn...@gmail.com> ---
See here on how to disable DocLint checks in maven builds:
https://jdpgrailsdev.github.io/blog/2014/04/03/maven_java8_javadoc.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 57005] maven build for jdbc-pool broken with Java 8 because of javadoc problems

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57005

--- Comment #2 from Pierre Viret <pi...@gmail.com> ---
Created attachment 32089
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=32089&action=edit
proposed patch which fixes the javadoc errors

I have fixed the javadoc errors occurring with java 8 and tested it with java
7: the javadoc can now be built with both versions without error.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 57005] maven build for jdbc-pool broken with Java 8 because of javadoc problems

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57005

--- Comment #3 from Pierre Viret <pi...@gmail.com> ---
Who could check this patch and commit it if it's OK ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 57005] maven build for jdbc-pool broken with Java 8 because of javadoc problems

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57005

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Mark Thomas <ma...@apache.org> ---
Fixed in 8.0.x for 8.0.15 onwards.
Thanks for the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org