You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ju...@apache.org on 2014/04/08 15:14:16 UTC
svn commit: r1585718 - in /subversion/trunk/subversion: include/svn_config.h
include/svn_error.h libsvn_fs_base/dag.c libsvn_fs_base/dag.h
libsvn_fs_x/index.c libsvn_fs_x/index.h libsvn_subr/config.c
libsvn_subr/error.c
Author: julianfoad
Date: Tue Apr 8 13:14:16 2014
New Revision: 1585718
URL: http://svn.apache.org/r1585718
Log:
The standard _dup() function pattern takes a const-qualified pointer to an
object and returns a mutable copy. Add 'const' to a few that didn't follow
that pattern.
* subversion/include/svn_config.h,
subversion/libsvn_subr/config.c
(svn_config_dup): Add 'const' as above.
* subversion/include/svn_error.h,
subversion/libsvn_subr/error.c
(svn_error_dup): Add 'const' as above.
* subversion/libsvn_fs_base/dag.h,
subversion/libsvn_fs_base/dag.c
(svn_fs_base__dag_dup): Add 'const' as above.
* subversion/libsvn_fs_x/index.h,
subversion/libsvn_fs_x/index.c
(svn_fs_x__p2l_entry_dup): Add 'const' as above.
Modified:
subversion/trunk/subversion/include/svn_config.h
subversion/trunk/subversion/include/svn_error.h
subversion/trunk/subversion/libsvn_fs_base/dag.c
subversion/trunk/subversion/libsvn_fs_base/dag.h
subversion/trunk/subversion/libsvn_fs_x/index.c
subversion/trunk/subversion/libsvn_fs_x/index.h
subversion/trunk/subversion/libsvn_subr/config.c
subversion/trunk/subversion/libsvn_subr/error.c
Modified: subversion/trunk/subversion/include/svn_config.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_config.h?rev=1585718&r1=1585717&r2=1585718&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_config.h (original)
+++ subversion/trunk/subversion/include/svn_config.h Tue Apr 8 13:14:16 2014
@@ -892,7 +892,7 @@ svn_config_get_user_config_path(const ch
*/
svn_error_t *
svn_config_dup(svn_config_t **cfgp,
- svn_config_t *src,
+ const svn_config_t *src,
apr_pool_t *pool);
/** Create a deep copy of the config hash @a src_hash and return
Modified: subversion/trunk/subversion/include/svn_error.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_error.h?rev=1585718&r1=1585717&r2=1585718&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_error.h (original)
+++ subversion/trunk/subversion/include/svn_error.h Tue Apr 8 13:14:16 2014
@@ -225,7 +225,7 @@ svn_error_find_cause(svn_error_t *err, a
* @since New in 1.2.
*/
svn_error_t *
-svn_error_dup(svn_error_t *err);
+svn_error_dup(const svn_error_t *err);
/** Free the memory used by @a error, as well as all ancestors and
* descendants of @a error.
Modified: subversion/trunk/subversion/libsvn_fs_base/dag.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_base/dag.c?rev=1585718&r1=1585717&r2=1585718&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_base/dag.c (original)
+++ subversion/trunk/subversion/libsvn_fs_base/dag.c Tue Apr 8 13:14:16 2014
@@ -1342,7 +1342,7 @@ svn_fs_base__dag_finalize_edits(dag_node
dag_node_t *
-svn_fs_base__dag_dup(dag_node_t *node,
+svn_fs_base__dag_dup(const dag_node_t *node,
apr_pool_t *pool)
{
/* Allocate our new node. */
Modified: subversion/trunk/subversion/libsvn_fs_base/dag.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_base/dag.h?rev=1585718&r1=1585717&r2=1585718&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_base/dag.h (original)
+++ subversion/trunk/subversion/libsvn_fs_base/dag.h Tue Apr 8 13:14:16 2014
@@ -82,7 +82,7 @@ svn_error_t *svn_fs_base__dag_get_node(d
/* Return a new dag_node_t object referring to the same node as NODE,
allocated in POOL. */
-dag_node_t *svn_fs_base__dag_dup(dag_node_t *node,
+dag_node_t *svn_fs_base__dag_dup(const dag_node_t *node,
apr_pool_t *pool);
Modified: subversion/trunk/subversion/libsvn_fs_x/index.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_x/index.c?rev=1585718&r1=1585717&r2=1585718&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_x/index.c (original)
+++ subversion/trunk/subversion/libsvn_fs_x/index.c Tue Apr 8 13:14:16 2014
@@ -1634,7 +1634,7 @@ svn_fs_x__l2p_get_max_ids(apr_array_head
* phys-to-log index
*/
svn_fs_x__p2l_entry_t *
-svn_fs_x__p2l_entry_dup(svn_fs_x__p2l_entry_t *entry,
+svn_fs_x__p2l_entry_dup(const svn_fs_x__p2l_entry_t *entry,
apr_pool_t *pool)
{
svn_fs_x__p2l_entry_t *new_entry = apr_palloc(pool, sizeof(*new_entry));
Modified: subversion/trunk/subversion/libsvn_fs_x/index.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_x/index.h?rev=1585718&r1=1585717&r2=1585718&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_x/index.h (original)
+++ subversion/trunk/subversion/libsvn_fs_x/index.h Tue Apr 8 13:14:16 2014
@@ -79,7 +79,7 @@ typedef struct svn_fs_x__p2l_entry_t
/* Return a (deep) copy of ENTRY, allocated in POOL.
*/
svn_fs_x__p2l_entry_t *
-svn_fs_x__p2l_entry_dup(svn_fs_x__p2l_entry_t *entry,
+svn_fs_x__p2l_entry_dup(const svn_fs_x__p2l_entry_t *entry,
apr_pool_t *pool);
/* Open / create a log-to-phys index file with the full file path name
Modified: subversion/trunk/subversion/libsvn_subr/config.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/config.c?rev=1585718&r1=1585717&r2=1585718&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/config.c (original)
+++ subversion/trunk/subversion/libsvn_subr/config.c Tue Apr 8 13:14:16 2014
@@ -1113,7 +1113,7 @@ svn_config_get_server_setting(svn_config
svn_error_t *
svn_config_dup(svn_config_t **cfgp,
- svn_config_t *src,
+ const svn_config_t *src,
apr_pool_t *pool)
{
apr_hash_index_t *sectidx;
Modified: subversion/trunk/subversion/libsvn_subr/error.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/error.c?rev=1585718&r1=1585717&r2=1585718&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/error.c (original)
+++ subversion/trunk/subversion/libsvn_subr/error.c Tue Apr 8 13:14:16 2014
@@ -355,7 +355,7 @@ svn_error_find_cause(svn_error_t *err, a
}
svn_error_t *
-svn_error_dup(svn_error_t *err)
+svn_error_dup(const svn_error_t *err)
{
apr_pool_t *pool;
svn_error_t *new_err = NULL, *tmp_err = NULL;