You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by doublefx <gi...@git.apache.org> on 2014/11/14 17:29:47 UTC
[GitHub] flex-utilities pull request: Update apache-flex-spelling-framework...
GitHub user doublefx opened a pull request:
https://github.com/apache/flex-utilities/pull/3
Update apache-flex-spelling-framework.pom
Misspelling of apache-flex-linguistic-utils instead of apache-flex-spelling-linguistic-utils
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/doublefx/flex-utilities patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flex-utilities/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit bd285499fcd0da4594de9812ff51bf79b015db99
Author: Frédéric THOMAS <ft...@apache.org>
Date: 2014-11-14T16:29:33Z
Update apache-flex-spelling-framework.pom
Misspelling of apache-flex-linguistic-utils instead of apache-flex-spelling-linguistic-utils
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flex-utilities pull request: Update apache-flex-spelling-framework...
Posted by doublefx <gi...@git.apache.org>.
Github user doublefx closed the pull request at:
https://github.com/apache/flex-utilities/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] flex-utilities pull request: Update
apache-flex-spelling-framework...
Posted by Alex Harui <ah...@adobe.com>.
Makes sense. Won’t hurt, might help.
Regarding merging the PR, what error are you getting? Don’t forget that
the ASF GH repos are read-only. There is a whole workflow for taking PR
into the actual ASF Git repos. And since you are a committer, it’d
probably be faster to simply copy the modified source file into your ASF
Git repo working copy and commit it.
-Alex
On 11/14/14, 9:17 AM, "Frédéric THOMAS" <we...@hotmail.com> wrote:
>My web outlook is very shitty today, sorry.
>> Given that squiggly is on the small size is there a huge need for RSLs?
>>Don't mind either way, just curious to why you would need them.
>I have an Air app that downloads modules, I try to make them as small as
>possible because some of our clients have a very slow connection, I
>modified the way the RSLs work in Flex (Monkey patch) to make it work
>with Air and as well load them from the local storage, the App is now
>loaded from a Loader (the actual installed app) and so with the modules
>will load the RSLs the first time they will need one, store it in the
>user storage and then and subsequently load them from here, doing so, my
>constantly updated modules will be as lighter as possible, am I clear ?
>
>Thanks,
>Frédéric THOMAS
>
>From: webdoublefx@hotmail.com
>To: dev@flex.apache.org
>Subject: RE: [GitHub] flex-utilities pull request: Update
>apache-flex-spelling-framework...
>Date: Fri, 14 Nov 2014 17:09:31 +0000
>
>
>
>
>> Looks like windows only? That may be an issue.
>Right, never did Ant for other platforms, does someone know how I could
>solve that ?
>
>Frédéric THOMAS
>
>> Subject: Re: [GitHub] flex-utilities pull request: Update
>>apache-flex-spelling-framework...
>> From: justin@classsoftware.com
>> Date: Sat, 15 Nov 2014 03:59:11 +1100
>> To: dev@flex.apache.org
>>
>> Hi,
>>
>> > <exec executable="${FLEX_BIN}/optimizer.exe"
>> > output="${output.dir}/flex-optimizer-@{swc-name}.log"
>>append="true">
>>
>> Looks like windows only? That may be an issue.
>>
>> Given that squiggly is on the small size is there a huge need for RSLs?
>>Don't mind either way, just curious to why you would need them.
>>
>> Thanks,
>> Justin
>
Re: [GitHub] flex-utilities pull request: Update apache-flex-spelling-framework...
Posted by OmPrakash Muppirala <bi...@gmail.com>.
Fred, we cannot merge pull requests from GitHub, because we dont have
admin access. We have to download the patch and apply to the Apache Git
repo. And if we add a magic comment in the format: "This closes #<pull
request number>", the PR gets closed automatically.
I think in this case, you just have to commit the code directly to the
Apache git repo since you have the committer rights.
Thanks,
Om
On Fri, Nov 14, 2014 at 9:17 AM, Frédéric THOMAS <we...@hotmail.com>
wrote:
> My web outlook is very shitty today, sorry.
> > Given that squiggly is on the small size is there a huge need for RSLs?
> Don't mind either way, just curious to why you would need them.
> I have an Air app that downloads modules, I try to make them as small as
> possible because some of our clients have a very slow connection, I
> modified the way the RSLs work in Flex (Monkey patch) to make it work with
> Air and as well load them from the local storage, the App is now loaded
> from a Loader (the actual installed app) and so with the modules will load
> the RSLs the first time they will need one, store it in the user storage
> and then and subsequently load them from here, doing so, my constantly
> updated modules will be as lighter as possible, am I clear ?
>
> Thanks,
> Frédéric THOMAS
>
> From: webdoublefx@hotmail.com
> To: dev@flex.apache.org
> Subject: RE: [GitHub] flex-utilities pull request: Update
> apache-flex-spelling-framework...
> Date: Fri, 14 Nov 2014 17:09:31 +0000
>
>
>
>
> > Looks like windows only? That may be an issue.
> Right, never did Ant for other platforms, does someone know how I could
> solve that ?
>
> Frédéric THOMAS
>
> > Subject: Re: [GitHub] flex-utilities pull request: Update
> apache-flex-spelling-framework...
> > From: justin@classsoftware.com
> > Date: Sat, 15 Nov 2014 03:59:11 +1100
> > To: dev@flex.apache.org
> >
> > Hi,
> >
> > > <exec executable="${FLEX_BIN}/optimizer.exe"
> > > output="${output.dir}/flex-optimizer-@{swc-name}.log"
> append="true">
> >
> > Looks like windows only? That may be an issue.
> >
> > Given that squiggly is on the small size is there a huge need for RSLs?
> Don't mind either way, just curious to why you would need them.
> >
> > Thanks,
> > Justin
>
>
>
RE: [GitHub] flex-utilities pull request: Update
apache-flex-spelling-framework...
Posted by Frédéric THOMAS <we...@hotmail.com>.
My web outlook is very shitty today, sorry.
> Given that squiggly is on the small size is there a huge need for RSLs? Don't mind either way, just curious to why you would need them.
I have an Air app that downloads modules, I try to make them as small as possible because some of our clients have a very slow connection, I modified the way the RSLs work in Flex (Monkey patch) to make it work with Air and as well load them from the local storage, the App is now loaded from a Loader (the actual installed app) and so with the modules will load the RSLs the first time they will need one, store it in the user storage and then and subsequently load them from here, doing so, my constantly updated modules will be as lighter as possible, am I clear ?
Thanks,
Frédéric THOMAS
From: webdoublefx@hotmail.com
To: dev@flex.apache.org
Subject: RE: [GitHub] flex-utilities pull request: Update apache-flex-spelling-framework...
Date: Fri, 14 Nov 2014 17:09:31 +0000
> Looks like windows only? That may be an issue.
Right, never did Ant for other platforms, does someone know how I could solve that ?
Frédéric THOMAS
> Subject: Re: [GitHub] flex-utilities pull request: Update apache-flex-spelling-framework...
> From: justin@classsoftware.com
> Date: Sat, 15 Nov 2014 03:59:11 +1100
> To: dev@flex.apache.org
>
> Hi,
>
> > <exec executable="${FLEX_BIN}/optimizer.exe"
> > output="${output.dir}/flex-optimizer-@{swc-name}.log" append="true">
>
> Looks like windows only? That may be an issue.
>
> Given that squiggly is on the small size is there a huge need for RSLs? Don't mind either way, just curious to why you would need them.
>
> Thanks,
> Justin
RE: [GitHub] flex-utilities pull request: Update
apache-flex-spelling-framework...
Posted by Frédéric THOMAS <we...@hotmail.com>.
> Looks like windows only? That may be an issue.
Right, never did Ant for other platforms, does someone know how I could solve that ?
Frédéric THOMAS
> Subject: Re: [GitHub] flex-utilities pull request: Update apache-flex-spelling-framework...
> From: justin@classsoftware.com
> Date: Sat, 15 Nov 2014 03:59:11 +1100
> To: dev@flex.apache.org
>
> Hi,
>
> > <exec executable="${FLEX_BIN}/optimizer.exe"
> > output="${output.dir}/flex-optimizer-@{swc-name}.log" append="true">
>
> Looks like windows only? That may be an issue.
>
> Given that squiggly is on the small size is there a huge need for RSLs? Don't mind either way, just curious to why you would need them.
>
> Thanks,
> Justin
Re: [GitHub] flex-utilities pull request: Update apache-flex-spelling-framework...
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> <exec executable="${FLEX_BIN}/optimizer.exe"
> output="${output.dir}/flex-optimizer-@{swc-name}.log" append="true">
Looks like windows only? That may be an issue.
Given that squiggly is on the small size is there a huge need for RSLs? Don't mind either way, just curious to why you would need them.
Thanks,
Justin
RE: [GitHub] flex-utilities pull request: Update
apache-flex-spelling-framework...
Posted by Frédéric THOMAS <we...@hotmail.com>.
Erratum: "Squiggly does come with RSLs", I mean't "Squiggly does not come with RSLs"
PS: I will need to update the Maven part too indeed if it's ok for you.
Thanks,
Frédéric THOMAS
From: webdoublefx@hotmail.com
To: dev@flex.apache.org
Subject: RE: [GitHub] flex-utilities pull request: Update apache-flex-spelling-framework...
Date: Fri, 14 Nov 2014 16:50:40 +0000
Hi,
I was trying to use Squiggly and felt on this issue, being at work, I went thru github to fix it but noticed I hadn't got the right karma to merge pull requests.Does someone can do something ?
An other thing, Squiggly does come with RSLs, I can try to fix that in the week if I find a bit of time and everyone agreed ?
Btw, I created my Ant MacroDef for that [1], if you're ok I process RSLs, can I use it (removing the -keep-as3-metadata part) or we have something ready ?
In between, can someone apply this patch ?
Thanks,
Frédéric THOMAS
[1]
<macrodef name="create-rsl">
<attribute name="rsl-dir"/>
<attribute name="swc-dir"/>
<attribute name="swc-name"/>
<sequential>
<mkdir dir="@{rsl-dir}"/>
<delete>
<fileset dir="@{rsl-dir}">
<include name="@{swc-name}.swc"/>
</fileset>
</delete>
<unzip src="@{swc-dir}/@{swc-name}.swc" dest="@{rsl-dir}" overwrite="true">
<patternset>
<include name="library.swf"/>
</patternset>
<mapper type="glob" from="library.swf" to="@{swc-name}.library.swf"/>
</unzip>
<exec executable="${FLEX_BIN}/optimizer.exe"
output="${output.dir}/flex-optimizer-@{swc-name}.log" append="true">
<arg value="-keep-as3-metadata='Inject,InjectConstructor,Factory,AssignableTo,Init,Destroy,Observe,AsyncInit,MessageDispatcher,ManagedEvents,MessageHandler,MessageBinding,MessageError,MessageInterceptor,CommandResult,CommandComplete,CommandError,CommandStatus,Publish,Subscribe,PublishSubscribe,ResourceBinding,Autoremove,Selector,Target,Internal,ObjectDefinition,DynamicObject,Metadata,DefaultProperty,Required,Event,XmlMapping,Attribute,TextNode,ChildTextNode,ChoiceId,ChoiceType,Ignore'"/>
<arg value="-input=@{rsl-dir}/@{swc-name}.library.swf"/>
<arg value="-output=@{rsl-dir}/@{swc-name}.swf"/>
</exec>
<exec executable="${FLEX_BIN}/digest.exe"
output="${output.dir}/flex-optimizer-@{swc-name}.log" append="true">
<arg value="-digest.rsl-file=@{rsl-dir}/@{swc-name}.swf"/>
<arg value="-digest.swc-path=@{swc-dir}/@{swc-name}.swc"/>
</exec>
<delete file="@{rsl-dir}/@{swc-name}.library.swf"/>
</sequential>
</macrodef>
> From: git@git.apache.org
> To: dev@flex.apache.org
> Subject: [GitHub] flex-utilities pull request: Update apache-flex-spelling-framework...
> Date: Fri, 14 Nov 2014 16:29:47 +0000
>
> GitHub user doublefx opened a pull request:
>
> https://github.com/apache/flex-utilities/pull/3
>
> Update apache-flex-spelling-framework.pom
>
> Misspelling of apache-flex-linguistic-utils instead of apache-flex-spelling-linguistic-utils
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/doublefx/flex-utilities patch-1
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/flex-utilities/pull/3.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #3
>
> ----
> commit bd285499fcd0da4594de9812ff51bf79b015db99
> Author: Frédéric THOMAS <ft...@apache.org>
> Date: 2014-11-14T16:29:33Z
>
> Update apache-flex-spelling-framework.pom
>
> Misspelling of apache-flex-linguistic-utils instead of apache-flex-spelling-linguistic-utils
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
RE: [GitHub] flex-utilities pull request: Update
apache-flex-spelling-framework...
Posted by Frédéric THOMAS <we...@hotmail.com>.
Hi,
I was trying to use Squiggly and felt on this issue, being at work, I went thru github to fix it but noticed I hadn't got the right karma to merge pull requests.Does someone can do something ?
An other thing, Squiggly does come with RSLs, I can try to fix that in the week if I find a bit of time and everyone agreed ?
Btw, I created my Ant MacroDef for that [1], if you're ok I process RSLs, can I use it (removing the -keep-as3-metadata part) or we have something ready ?
In between, can someone apply this patch ?
Thanks,
Frédéric THOMAS
[1]
<macrodef name="create-rsl">
<attribute name="rsl-dir"/>
<attribute name="swc-dir"/>
<attribute name="swc-name"/>
<sequential>
<mkdir dir="@{rsl-dir}"/>
<delete>
<fileset dir="@{rsl-dir}">
<include name="@{swc-name}.swc"/>
</fileset>
</delete>
<unzip src="@{swc-dir}/@{swc-name}.swc" dest="@{rsl-dir}" overwrite="true">
<patternset>
<include name="library.swf"/>
</patternset>
<mapper type="glob" from="library.swf" to="@{swc-name}.library.swf"/>
</unzip>
<exec executable="${FLEX_BIN}/optimizer.exe"
output="${output.dir}/flex-optimizer-@{swc-name}.log" append="true">
<arg value="-keep-as3-metadata='Inject,InjectConstructor,Factory,AssignableTo,Init,Destroy,Observe,AsyncInit,MessageDispatcher,ManagedEvents,MessageHandler,MessageBinding,MessageError,MessageInterceptor,CommandResult,CommandComplete,CommandError,CommandStatus,Publish,Subscribe,PublishSubscribe,ResourceBinding,Autoremove,Selector,Target,Internal,ObjectDefinition,DynamicObject,Metadata,DefaultProperty,Required,Event,XmlMapping,Attribute,TextNode,ChildTextNode,ChoiceId,ChoiceType,Ignore'"/>
<arg value="-input=@{rsl-dir}/@{swc-name}.library.swf"/>
<arg value="-output=@{rsl-dir}/@{swc-name}.swf"/>
</exec>
<exec executable="${FLEX_BIN}/digest.exe"
output="${output.dir}/flex-optimizer-@{swc-name}.log" append="true">
<arg value="-digest.rsl-file=@{rsl-dir}/@{swc-name}.swf"/>
<arg value="-digest.swc-path=@{swc-dir}/@{swc-name}.swc"/>
</exec>
<delete file="@{rsl-dir}/@{swc-name}.library.swf"/>
</sequential>
</macrodef>
> From: git@git.apache.org
> To: dev@flex.apache.org
> Subject: [GitHub] flex-utilities pull request: Update apache-flex-spelling-framework...
> Date: Fri, 14 Nov 2014 16:29:47 +0000
>
> GitHub user doublefx opened a pull request:
>
> https://github.com/apache/flex-utilities/pull/3
>
> Update apache-flex-spelling-framework.pom
>
> Misspelling of apache-flex-linguistic-utils instead of apache-flex-spelling-linguistic-utils
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/doublefx/flex-utilities patch-1
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/flex-utilities/pull/3.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #3
>
> ----
> commit bd285499fcd0da4594de9812ff51bf79b015db99
> Author: Frédéric THOMAS <ft...@apache.org>
> Date: 2014-11-14T16:29:33Z
>
> Update apache-flex-spelling-framework.pom
>
> Misspelling of apache-flex-linguistic-utils instead of apache-flex-spelling-linguistic-utils
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] flex-utilities pull request: Update apache-flex-spelling-framework...
Posted by doublefx <gi...@git.apache.org>.
Github user doublefx commented on the pull request:
https://github.com/apache/flex-utilities/pull/3#issuecomment-63282420
Has been merged.
This closes #3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---