[GitHub] [arrow] nealrichardson commented on a change in pull request #11795: ARROW-14910: [R] [CI] Use dev duckdb to build with < 8GB or ram

[GitBox <gi...@apache.org>]

nealrichardson commented on a change in pull request #11795:
URL: https://github.com/apache/arrow/pull/11795#discussion_r759615090



##########
File path: ci/scripts/r_deps.sh
##########
@@ -41,6 +41,13 @@ fi
 # but we want to error/fail the build.
 # options(warn=2) turns warnings into errors
 ${R_BIN} -e "options(warn=2); install.packages('remotes'); remotes::install_cran(c('glue', 'rcmdcheck', 'sys')); remotes::install_deps(INSTALL_opts = '"${INSTALL_ARGS}"')"
+
+# (Temporarily) install DuckDB from source to avoid their Unity builds (though only if we haven't filtered it out of the deps above)

Review comment:
       ```suggestion
   # (Temporarily) install DuckDB from source to avoid their Unity builds
   # (though only if we haven't filtered it out of the deps above,
   # and if we can't get a binary from RSPM)
   ```
   
   Explaining the `if` in the R code. I guess we don't have any mac/windows builds that use this script (in which case RSPM wouldn't matter, you'd still get a binary)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org