[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10034: chore(security): Updating assert logic

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #10034:
URL: https://github.com/apache/incubator-superset/pull/10034#discussion_r443719624



##########
File path: superset/charts/api.py
##########
@@ -450,7 +450,7 @@ def data(self) -> Response:
         except KeyError:
             return self.response_400(message="Request is incorrect")
         try:
-            security_manager.assert_query_context_permission(query_context)
+            query_context.raise_for_access()

Review comment:
       @etr2460 #9529 kind of addresses that, it's a POC for SIP-41, is uses flask error handling




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org