[GitHub] [incubator-mxnet] liuzh91 commented on issue #16900: introduce gradient update handler to the base estimator

[GitBox <gi...@apache.org>]

liuzh91 commented on issue #16900: introduce  gradient update handler to the  base estimator
URL: https://github.com/apache/incubator-mxnet/pull/16900#issuecomment-560201526
 
 
   >     1. Does this require the user to specify grad_req = 'add' for gradient accumulation? When is the gradient reset to zeros?
   > 
   >     2. Now GradientUpdateHandler is added to the list of default handlers. If users explicitly create estimator with `event_handlers=[metric, logging]`, will `GradientUpdateHandler` still be included in the estimator and performing updates correctly?
   
   1. The gradient update handler is for general gradient update. When we implement gradient accumulation handler in the future, we will inherit this class.
   
   2. Yes, it is added as a default handler. Please refer to (https://github.com/apache/incubator-mxnet/blob/5878451c4b476d8771d93000ff5d51b81071997d/tests/python/unittest/test_gluon_estimator.py#L369).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services