You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by bryancall <gi...@git.apache.org> on 2016/08/12 18:06:44 UTC
[GitHub] trafficserver pull request #857: TS-4732: Changing the do_io_read API so it ...
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/857
TS-4732: Changing the do_io_read API so it can be called with NULL and
0 byte values. Allowing do_io_read and do_io_write to not warn on closed
connection when we are only trying to disable the reads and writes for it.
Removed some macros that were used in a few places (not all the time) and
a couple that were not used at all.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4732
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/857.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #857
----
commit 1975d679663453348057bb7155bdd3c17ac73880
Author: Bryan Call <bc...@apache.org>
Date: 2016-08-12T18:00:11Z
TS-4732: Changing the do_io_read API so it can be called with NULL and
0 byte values. Allowing do_io_read and do_io_write to not warn on closed
connection when we are only trying to disable the reads and writes for it.
Removed some macros that were used in a few places (not all the time) and
a couple that were not used at all.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #857: TS-4732: Changing the do_io_read API so it can be ...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/857
I've been thinking about this and wonder if we should avoid this and have an explicit `disable_io_read` and `disable_io_write` instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #857: TS-4732: Changing the do_io_read API so it can be ...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/857
I am going to go with this right now and open a bug for disable_read() and disable_write()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #857: TS-4732: Changing the do_io_read API so it can be ...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/857
Looks good. Having an explicit disable_io_read/write might be nice. But using NULL's to clear out the current io's does't seem too surprising.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #857: TS-4732: Changing the do_io_read API so it can be ...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/857
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/523/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #857: TS-4732: Changing the do_io_read API so it can be ...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/857
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/420/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #857: TS-4732: Changing the do_io_read API so it ...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/857
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #857: TS-4732: Changing the do_io_read API so it ...
Posted by JamesPeach <gi...@git.apache.org>.
Github user JamesPeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/857#discussion_r74655590
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -622,8 +617,7 @@ UnixNetVConnection::get_data(int id, void *data)
VIO *
UnixNetVConnection::do_io_read(Continuation *c, int64_t nbytes, MIOBuffer *buf)
{
- ink_assert(c || 0 == nbytes);
--- End diff --
Maybe move this assert after the new check and add an equivalent one to ``do_io_write``?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #857: TS-4732: Changing the do_io_read API so it can be ...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/857
Yeah, I started down the path of disable_read() and disable_write(), then ran into having to implemented the methods in multiple locations (pluginvc) when declaring them pure virtual.
I might switch back to disable_read() and disable_write()...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---