You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/11 11:45:05 UTC
[GitHub] [superset] codecov[bot] commented on pull request #13547: test: Adds storybook and tests to PopoverDropdown component
codecov[bot] commented on pull request #13547:
URL: https://github.com/apache/superset/pull/13547#issuecomment-796677837
# [Codecov](https://codecov.io/gh/apache/superset/pull/13547?src=pr&el=h1) Report
> Merging [#13547](https://codecov.io/gh/apache/superset/pull/13547?src=pr&el=desc) (d773277) into [master](https://codecov.io/gh/apache/superset/commit/1d1a1cdc208a7df6e45bffaac3e99675a61e0a20?el=desc) (1d1a1cd) will **decrease** coverage by `3.71%`.
> The diff coverage is `40.19%`.
[](https://codecov.io/gh/apache/superset/pull/13547?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13547 +/- ##
==========================================
- Coverage 77.31% 73.59% -3.72%
==========================================
Files 903 603 -300
Lines 45926 21396 -24530
Branches 5624 5554 -70
==========================================
- Hits 35508 15747 -19761
+ Misses 10282 5515 -4767
+ Partials 136 134 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.20% <25.64%> (+0.74%)` | :arrow_up: |
| javascript | `63.41% <40.19%> (-0.07%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13547?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/13547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `23.80% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `64.10% <0.00%> (-3.47%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `100.00% <ø> (+2.63%)` | :arrow_up: |
| [...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx](https://codecov.io/gh/apache/superset/pull/13547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0VW5pdC50c3g=) | `40.90% <ø> (ø)` | |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `39.13% <0.00%> (-1.78%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13547/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `66.38% <ø> (ø)` | |
| ... and [322 more](https://codecov.io/gh/apache/superset/pull/13547/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13547?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13547?src=pr&el=footer). Last update [1d1a1cd...9777dfd](https://codecov.io/gh/apache/superset/pull/13547?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org