[jira] [Commented] (HBASE-8350) enable ChaosMonkey to run commands as different users

["Nick Dimiduk (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-8350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633576#comment-13633576 ] 

Nick Dimiduk commented on HBASE-8350:
-------------------------------------

{noformat}
+    }
+    sshUserName = conf.get("hbase.it.clustermanager.ssh.user", "");
+    String extraSshOptions = conf.get("hbase.it.clustermanager.ssh.opts", "");
+    sshOptions = System.getenv("HBASE_SSH_OPTS");
{noformat}

Since these are user-facing configuration points (we want to use hbase-it as smoke-test for user installs, right?), please move them to HConstants.

{noformat}
+      String userAndHost = sshUserName.isEmpty() ? hostname : (sshUserName + "@" + hostname);
{noformat}

You could alternatively use {{-l login_name}}. Whichever makes the code simpler.

+1
                
> enable ChaosMonkey to run commands as different users
> -----------------------------------------------------
>
>                 Key: HBASE-8350
>                 URL: https://issues.apache.org/jira/browse/HBASE-8350
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Minor
>             Fix For: 0.94.8, 0.95.2
>
>         Attachments: HBASE-8350-v0-0.94.patch, HBASE-8350-v0.patch
>
>
> CM should be able to run under different user than the user under which hbase is running. Current options are insufficient to achieve that... it should ssh under configurable user, or sudo

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira