You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/08/17 15:57:11 UTC
[GitHub] [arrow-adbc] paleolimbot opened a new pull request, #982: feat(r): Add basic dbplyr integration
paleolimbot opened a new pull request, #982:
URL: https://github.com/apache/arrow-adbc/pull/982
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] krlmlr commented on a diff in pull request #982: feat(r): Add `adbc_simulate_dbi()` S3 generic
Posted by "krlmlr (via GitHub)" <gi...@apache.org>.
krlmlr commented on code in PR #982:
URL: https://github.com/apache/arrow-adbc/pull/982#discussion_r1311095405
##########
r/adbcdrivermanager/R/pkg-dbi.R:
##########
@@ -0,0 +1,78 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#' Simulate an equivalent DBI connection
+#'
+#' @inheritParams adbc_connection_init
+#' @param method The package-qualified name of the method that
+#' requires a simulation of a DBI object.
+#' @param class The DBIConnection subclass for the simulated
+#' connection.
+#' @param ... Passed to S3 methods
+#'
+#' @return An S3 object like that returned by `dbplyr::simulate_dbi()`
+#' @export
+#'
+#' @examples
+#' db <- adbc_database_init(adbc_driver_void())
+#' con <- adbc_connection_init(db)
+#' adbc_simulate_dbi(con)
+#'
+adbc_simulate_dbi <- function(connection, method = NULL, ...) {
+ UseMethod("adbc_simulate_dbi")
+}
+
+#' @export
+adbc_simulate_dbi.default <- function(connection, method = NULL, ...) {
+ vendor_name <- tryCatch({
+ # 0L == ADBC_INFO_VENDOR_NAME
+ with_adbc(info <- adbc_connection_get_info(connection, 0L), {
Review Comment:
Should there be a `local_adbc()` ?
##########
r/adbcdrivermanager/R/pkg-dbi.R:
##########
@@ -0,0 +1,78 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#' Simulate an equivalent DBI connection
+#'
Review Comment:
Should we add details on how to use it here, or in a separate vignette?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] paleolimbot commented on pull request #982: feat(r): Add `adbc_simulate_dbi()` S3 generic
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #982:
URL: https://github.com/apache/arrow-adbc/pull/982#issuecomment-1736494357
Closing in favour of implementing the quote literal + quote string generics directly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] paleolimbot closed pull request #982: feat(r): Add `adbc_simulate_dbi()` S3 generic
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot closed pull request #982: feat(r): Add `adbc_simulate_dbi()` S3 generic
URL: https://github.com/apache/arrow-adbc/pull/982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org