You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/31 20:44:45 UTC
[GitHub] [pinot] xiangfu0 opened a new pull request #8451: Rewrite PinotQuery based on expression hints at segment level
xiangfu0 opened a new pull request #8451:
URL: https://github.com/apache/pinot/pull/8451
## Description
Rewrite PinotQuery based on expression hints at segment level
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
<!-- If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release. -->
<!-- If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text.
-->
## Documentation
<!-- If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#discussion_r840896309
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
##########
@@ -281,4 +287,80 @@ public PlanNode makeStreamingSegmentPlanNode(IndexSegment indexSegment, QueryCon
return new StreamingSelectionPlanNode(indexSegment, queryContext);
}
}
+
+ /**
+ * In-place rewrite QueryContext based on the information from local IndexSegment.
+ *
+ * @param queryContext
+ * @param indexSegment
+ */
+ @VisibleForTesting
+ public static void rewriteQueryContextWithHints(QueryContext queryContext, IndexSegment indexSegment) {
+ Map<ExpressionContext, ExpressionContext> expressionOverrideHints = queryContext.getExpressionOverrideHints();
+ if (MapUtils.isEmpty(expressionOverrideHints)) {
+ return;
+ }
+
+ List<ExpressionContext> selectExpressions = queryContext.getSelectExpressions();
+ selectExpressions.replaceAll(
+ expression -> overrideWithExpressionHints(expression, indexSegment, expressionOverrideHints));
+
+ List<ExpressionContext> groupByExpressions = queryContext.getGroupByExpressions();
+ if (CollectionUtils.isNotEmpty(groupByExpressions)) {
+ groupByExpressions.replaceAll(
+ expression -> overrideWithExpressionHints(expression, indexSegment, expressionOverrideHints));
+ }
+
+ List<OrderByExpressionContext> orderByExpressions = queryContext.getOrderByExpressions();
+ if (CollectionUtils.isNotEmpty(orderByExpressions)) {
+ orderByExpressions.replaceAll(expression -> new OrderByExpressionContext(
+ overrideWithExpressionHints(expression.getExpression(), indexSegment, expressionOverrideHints),
+ expression.isAsc()));
+ }
+
+ // In-place override
+ FilterContext filter = queryContext.getFilter();
+ if (filter != null) {
+ overrideWithExpressionHints(filter, indexSegment, expressionOverrideHints);
+ }
+
+ // In-place override
+ FilterContext havingFilter = queryContext.getHavingFilter();
+ if (havingFilter != null) {
+ overrideWithExpressionHints(havingFilter, indexSegment, expressionOverrideHints);
+ }
+ }
+
+ @VisibleForTesting
+ public static void overrideWithExpressionHints(FilterContext filter, IndexSegment indexSegment,
+ Map<ExpressionContext, ExpressionContext> expressionOverrideHints) {
+ if (filter.getChildren() != null) {
+ // AND, OR, NOT
+ for (FilterContext child : filter.getChildren()) {
+ overrideWithExpressionHints(child, indexSegment, expressionOverrideHints);
+ }
+ } else {
+ // PREDICATE
+ Predicate predicate = filter.getPredicate();
+ predicate.setLhs(overrideWithExpressionHints(predicate.getLhs(), indexSegment, expressionOverrideHints));
+ }
+ }
+
+ @VisibleForTesting
+ public static ExpressionContext overrideWithExpressionHints(ExpressionContext expression, IndexSegment indexSegment,
+ Map<ExpressionContext, ExpressionContext> expressionOverrideHints) {
+ if (expression.getType() != ExpressionContext.Type.FUNCTION) {
+ return expression;
+ }
+ ExpressionContext overrideExpression = expressionOverrideHints.get(expression);
+ if (overrideExpression != null && overrideExpression.getIdentifier() != null
+ && indexSegment.getColumnNames().contains(overrideExpression.getIdentifier())) {
+ return overrideExpression;
+ }
+ List<ExpressionContext> arguments = expression.getFunction().getArguments();
+ for (int i = 0; i < arguments.size(); i++) {
+ arguments.set(i, overrideWithExpressionHints(arguments.get(i), indexSegment, expressionOverrideHints));
Review comment:
(minor) Use `replaceAll`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8451](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85dd906) into [master](https://codecov.io/gh/apache/pinot/commit/370d86c298c68def6e830b868fa16cabda9d08ff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (370d86c) will **decrease** coverage by `8.26%`.
> The diff coverage is `82.85%`.
> :exclamation: Current head 85dd906 differs from pull request most recent head f2637f9. Consider uploading reports for the commit f2637f9 to get more accurate results
```diff
@@ Coverage Diff @@
## master #8451 +/- ##
============================================
- Coverage 70.63% 62.37% -8.27%
+ Complexity 4282 4198 -84
============================================
Files 1663 1652 -11
Lines 87305 86987 -318
Branches 13216 13189 -27
============================================
- Hits 61671 54255 -7416
- Misses 21350 28711 +7361
+ Partials 4284 4021 -263
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `27.18% <35.71%> (+0.15%)` | :arrow_up: |
| integration2 | `?` | |
| unittests1 | `67.04% <82.85%> (-0.01%)` | :arrow_down: |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ot/common/request/context/predicate/Predicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9QcmVkaWNhdGUuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...pinot/core/plan/maker/InstancePlanMakerImplV2.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL21ha2VyL0luc3RhbmNlUGxhbk1ha2VySW1wbFYyLmphdmE=) | `64.74% <69.23%> (-12.26%)` | :arrow_down: |
| [...ommon/request/context/predicate/BasePredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9CYXNlUHJlZGljYXRlLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../common/request/context/predicate/EqPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9FcVByZWRpY2F0ZS5qYXZh) | `61.53% <100.00%> (-5.13%)` | :arrow_down: |
| [.../common/request/context/predicate/InPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9JblByZWRpY2F0ZS5qYXZh) | `72.22% <100.00%> (-2.78%)` | :arrow_down: |
| [.../request/context/predicate/IsNotNullPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Jc05vdE51bGxQcmVkaWNhdGUuamF2YQ==) | `63.63% <100.00%> (-5.60%)` | :arrow_down: |
| [...mon/request/context/predicate/IsNullPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Jc051bGxQcmVkaWNhdGUuamF2YQ==) | `63.63% <100.00%> (-5.60%)` | :arrow_down: |
| [.../request/context/predicate/JsonMatchPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Kc29uTWF0Y2hQcmVkaWNhdGUuamF2YQ==) | `53.84% <100.00%> (-6.16%)` | :arrow_down: |
| [...mmon/request/context/predicate/NotEqPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Ob3RFcVByZWRpY2F0ZS5qYXZh) | `61.53% <100.00%> (-5.13%)` | :arrow_down: |
| [...mmon/request/context/predicate/NotInPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Ob3RJblByZWRpY2F0ZS5qYXZh) | `72.22% <100.00%> (-2.78%)` | :arrow_down: |
| ... and [302 more](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [370d86c...f2637f9](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#discussion_r840834410
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/BasePredicate.java
##########
@@ -0,0 +1,43 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.request.context.predicate;
+
+import org.apache.pinot.common.request.context.ExpressionContext;
+
+
+/**
+ * Abstract predicate with left-hand side expression
+ */
+public abstract class BasePredicate implements Predicate {
+
+ protected ExpressionContext _lhs;
+
+ public BasePredicate(ExpressionContext lhs) {
+ _lhs = lhs;
+ }
+
+ @Override
+ public ExpressionContext getLhs() {
+ return _lhs;
+ }
+
+ public void setLhs(ExpressionContext lhs) {
Review comment:
add `@Override`
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/Predicate.java
##########
@@ -54,4 +54,9 @@ public boolean isExclusive() {
* Returns the left-hand side expression of the predicate.
*/
ExpressionContext getLhs();
+
+ /**
+ * Set the left-hand side expression of the predicate.
Review comment:
(nit)
```suggestion
* Sets the left-hand side expression of the predicate.
```
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
##########
@@ -228,6 +231,9 @@ private void applyQueryOptions(QueryContext queryContext) {
@Override
public PlanNode makeSegmentPlanNode(IndexSegment indexSegment, QueryContext queryContext) {
+ if (queryContext.getExpressionOverrideHints() != null && !queryContext.getExpressionOverrideHints().isEmpty()) {
Review comment:
(minor)
```suggestion
if (MapUtils.isNotEmpty(queryContext.getExpressionOverrideHints())) {
```
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
##########
@@ -281,4 +287,84 @@ public PlanNode makeStreamingSegmentPlanNode(IndexSegment indexSegment, QueryCon
return new StreamingSelectionPlanNode(indexSegment, queryContext);
}
}
+
+ /**
+ * In-place rewrite QueryContext based on the information from local IndexSegment.
+ *
+ * @param queryContext
+ * @param indexSegment
+ */
+ @VisibleForTesting
+ public static void rewriteQueryContextWithHints(QueryContext queryContext, IndexSegment indexSegment) {
+ List<ExpressionContext> selectExpressions = queryContext.getSelectExpressions();
+ if (selectExpressions != null && !selectExpressions.isEmpty()) {
Review comment:
This check is redundant
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
##########
@@ -281,4 +287,84 @@ public PlanNode makeStreamingSegmentPlanNode(IndexSegment indexSegment, QueryCon
return new StreamingSelectionPlanNode(indexSegment, queryContext);
}
}
+
+ /**
+ * In-place rewrite QueryContext based on the information from local IndexSegment.
+ *
+ * @param queryContext
+ * @param indexSegment
+ */
+ @VisibleForTesting
+ public static void rewriteQueryContextWithHints(QueryContext queryContext, IndexSegment indexSegment) {
+ List<ExpressionContext> selectExpressions = queryContext.getSelectExpressions();
+ if (selectExpressions != null && !selectExpressions.isEmpty()) {
+ for (int i = 0; i < selectExpressions.size(); i++) {
+ selectExpressions.set(i, overrideWithExpressionHints(selectExpressions.get(i), indexSegment,
+ queryContext.getExpressionOverrideHints()));
+ }
+ }
+
+ List<ExpressionContext> groupByExpression = queryContext.getGroupByExpressions();
+ if (groupByExpression != null && !groupByExpression.isEmpty()) {
Review comment:
(minor) Same for other places
```suggestion
if (CollectionUtils.isNotEmpty(groupByExpression)) {
```
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
##########
@@ -281,4 +287,84 @@ public PlanNode makeStreamingSegmentPlanNode(IndexSegment indexSegment, QueryCon
return new StreamingSelectionPlanNode(indexSegment, queryContext);
}
}
+
+ /**
+ * In-place rewrite QueryContext based on the information from local IndexSegment.
+ *
+ * @param queryContext
+ * @param indexSegment
+ */
+ @VisibleForTesting
+ public static void rewriteQueryContextWithHints(QueryContext queryContext, IndexSegment indexSegment) {
+ List<ExpressionContext> selectExpressions = queryContext.getSelectExpressions();
+ if (selectExpressions != null && !selectExpressions.isEmpty()) {
+ for (int i = 0; i < selectExpressions.size(); i++) {
+ selectExpressions.set(i, overrideWithExpressionHints(selectExpressions.get(i), indexSegment,
+ queryContext.getExpressionOverrideHints()));
+ }
+ }
+
+ List<ExpressionContext> groupByExpression = queryContext.getGroupByExpressions();
+ if (groupByExpression != null && !groupByExpression.isEmpty()) {
+ for (int i = 0; i < groupByExpression.size(); i++) {
Review comment:
This can be simplified with `replaceAll()`, which can be faster for certain `List` impl. Same for other places
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/utils/BrokerRequestToQueryContextConverter.java
##########
@@ -149,12 +151,23 @@ private static QueryContext convertSQL(PinotQuery pinotQuery, BrokerRequest brok
havingFilter = RequestContextUtils.getFilter(havingExpression);
}
+ // EXPRESSION OVERRIDE HINTS
+ Map<ExpressionContext, ExpressionContext> expressionContextOverrideHints = new HashMap<>();
+ Map<Expression, Expression> expressionOverrideHints = pinotQuery.getExpressionOverrideHints();
+ if (expressionOverrideHints != null) {
+ for (Expression key : expressionOverrideHints.keySet()) {
Review comment:
Use `.entrySet()` to avoid extra lookups
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
##########
@@ -281,4 +287,84 @@ public PlanNode makeStreamingSegmentPlanNode(IndexSegment indexSegment, QueryCon
return new StreamingSelectionPlanNode(indexSegment, queryContext);
}
}
+
+ /**
+ * In-place rewrite QueryContext based on the information from local IndexSegment.
+ *
+ * @param queryContext
+ * @param indexSegment
+ */
+ @VisibleForTesting
+ public static void rewriteQueryContextWithHints(QueryContext queryContext, IndexSegment indexSegment) {
+ List<ExpressionContext> selectExpressions = queryContext.getSelectExpressions();
+ if (selectExpressions != null && !selectExpressions.isEmpty()) {
+ for (int i = 0; i < selectExpressions.size(); i++) {
+ selectExpressions.set(i, overrideWithExpressionHints(selectExpressions.get(i), indexSegment,
+ queryContext.getExpressionOverrideHints()));
+ }
+ }
+
+ List<ExpressionContext> groupByExpression = queryContext.getGroupByExpressions();
+ if (groupByExpression != null && !groupByExpression.isEmpty()) {
+ for (int i = 0; i < groupByExpression.size(); i++) {
+ groupByExpression.set(i, overrideWithExpressionHints(groupByExpression.get(i), indexSegment,
+ queryContext.getExpressionOverrideHints()));
+ }
+ }
+
+ List<OrderByExpressionContext> orderByExpression = queryContext.getOrderByExpressions();
+ if (orderByExpression != null && !orderByExpression.isEmpty()) {
+ for (int i = 0; i < orderByExpression.size(); i++) {
+ OrderByExpressionContext expression = orderByExpression.get(i);
+ orderByExpression.set(i, new OrderByExpressionContext(
+ overrideWithExpressionHints(expression.getExpression(), indexSegment,
+ queryContext.getExpressionOverrideHints()), expression.isAsc()));
+ }
+ }
+
+ // In-place override
+ FilterContext filter = queryContext.getFilter();
+ if (filter != null) {
+ overrideWithExpressionHints(filter, indexSegment, queryContext.getExpressionOverrideHints());
+ }
+
+ // In-place override
+ FilterContext havingFilter = queryContext.getHavingFilter();
+ if (havingFilter != null) {
+ overrideWithExpressionHints(havingFilter, indexSegment, queryContext.getExpressionOverrideHints());
+ }
+ }
+
+ @VisibleForTesting
+ public static void overrideWithExpressionHints(FilterContext filter, IndexSegment indexSegment,
+ Map<ExpressionContext, ExpressionContext> expressionOverrideHints) {
+ if (filter.getChildren() != null) {
+ // AND, OR, NOT
+ for (FilterContext child : filter.getChildren()) {
+ overrideWithExpressionHints(child, indexSegment, expressionOverrideHints);
+ }
+ return;
+ }
+ // PREDICATE
+ Predicate predicate = filter.getPredicate();
+ predicate.setLhs(overrideWithExpressionHints(predicate.getLhs(), indexSegment, expressionOverrideHints));
+ }
+
+ @VisibleForTesting
+ public static ExpressionContext overrideWithExpressionHints(ExpressionContext expression, IndexSegment indexSegment,
+ Map<ExpressionContext, ExpressionContext> expressionOverrideHints) {
+ if (expression.getType() != ExpressionContext.Type.FUNCTION) {
+ return expression;
+ }
+ ExpressionContext overrideExpression = expressionOverrideHints.get(expression);
+ if (overrideExpression != null && overrideExpression.getIdentifier() != null
+ && indexSegment.getPhysicalColumnNames().contains(overrideExpression.getIdentifier())) {
Review comment:
(MAJOR) `indexSegment.getPhysicalColumnNames()` is quite expensive, and conceptually we should also allow overriding to virtual columns. Use `indexSegment.getColumnNames()` instead
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
##########
@@ -281,4 +287,84 @@ public PlanNode makeStreamingSegmentPlanNode(IndexSegment indexSegment, QueryCon
return new StreamingSelectionPlanNode(indexSegment, queryContext);
}
}
+
+ /**
+ * In-place rewrite QueryContext based on the information from local IndexSegment.
+ *
+ * @param queryContext
+ * @param indexSegment
+ */
+ @VisibleForTesting
+ public static void rewriteQueryContextWithHints(QueryContext queryContext, IndexSegment indexSegment) {
+ List<ExpressionContext> selectExpressions = queryContext.getSelectExpressions();
+ if (selectExpressions != null && !selectExpressions.isEmpty()) {
+ for (int i = 0; i < selectExpressions.size(); i++) {
+ selectExpressions.set(i, overrideWithExpressionHints(selectExpressions.get(i), indexSegment,
+ queryContext.getExpressionOverrideHints()));
+ }
+ }
+
+ List<ExpressionContext> groupByExpression = queryContext.getGroupByExpressions();
+ if (groupByExpression != null && !groupByExpression.isEmpty()) {
+ for (int i = 0; i < groupByExpression.size(); i++) {
+ groupByExpression.set(i, overrideWithExpressionHints(groupByExpression.get(i), indexSegment,
+ queryContext.getExpressionOverrideHints()));
+ }
+ }
+
+ List<OrderByExpressionContext> orderByExpression = queryContext.getOrderByExpressions();
+ if (orderByExpression != null && !orderByExpression.isEmpty()) {
+ for (int i = 0; i < orderByExpression.size(); i++) {
+ OrderByExpressionContext expression = orderByExpression.get(i);
+ orderByExpression.set(i, new OrderByExpressionContext(
+ overrideWithExpressionHints(expression.getExpression(), indexSegment,
+ queryContext.getExpressionOverrideHints()), expression.isAsc()));
+ }
+ }
+
+ // In-place override
+ FilterContext filter = queryContext.getFilter();
+ if (filter != null) {
+ overrideWithExpressionHints(filter, indexSegment, queryContext.getExpressionOverrideHints());
+ }
+
+ // In-place override
+ FilterContext havingFilter = queryContext.getHavingFilter();
+ if (havingFilter != null) {
+ overrideWithExpressionHints(havingFilter, indexSegment, queryContext.getExpressionOverrideHints());
+ }
+ }
+
+ @VisibleForTesting
+ public static void overrideWithExpressionHints(FilterContext filter, IndexSegment indexSegment,
+ Map<ExpressionContext, ExpressionContext> expressionOverrideHints) {
+ if (filter.getChildren() != null) {
+ // AND, OR, NOT
+ for (FilterContext child : filter.getChildren()) {
+ overrideWithExpressionHints(child, indexSegment, expressionOverrideHints);
+ }
+ return;
Review comment:
(minor) Suggest using `else` instead of `return` for better readability
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
##########
@@ -281,4 +287,84 @@ public PlanNode makeStreamingSegmentPlanNode(IndexSegment indexSegment, QueryCon
return new StreamingSelectionPlanNode(indexSegment, queryContext);
}
}
+
+ /**
+ * In-place rewrite QueryContext based on the information from local IndexSegment.
+ *
+ * @param queryContext
+ * @param indexSegment
+ */
+ @VisibleForTesting
+ public static void rewriteQueryContextWithHints(QueryContext queryContext, IndexSegment indexSegment) {
+ List<ExpressionContext> selectExpressions = queryContext.getSelectExpressions();
+ if (selectExpressions != null && !selectExpressions.isEmpty()) {
+ for (int i = 0; i < selectExpressions.size(); i++) {
+ selectExpressions.set(i, overrideWithExpressionHints(selectExpressions.get(i), indexSegment,
+ queryContext.getExpressionOverrideHints()));
+ }
+ }
+
+ List<ExpressionContext> groupByExpression = queryContext.getGroupByExpressions();
Review comment:
```suggestion
List<ExpressionContext> groupByExpressions = queryContext.getGroupByExpressions();
```
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
##########
@@ -228,6 +231,9 @@ private void applyQueryOptions(QueryContext queryContext) {
@Override
public PlanNode makeSegmentPlanNode(IndexSegment indexSegment, QueryContext queryContext) {
+ if (queryContext.getExpressionOverrideHints() != null && !queryContext.getExpressionOverrideHints().isEmpty()) {
Review comment:
Move this check into `rewriteQueryContextWithHints` because conceptually it should handle other hints rewrite as well
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
##########
@@ -281,4 +287,84 @@ public PlanNode makeStreamingSegmentPlanNode(IndexSegment indexSegment, QueryCon
return new StreamingSelectionPlanNode(indexSegment, queryContext);
}
}
+
+ /**
+ * In-place rewrite QueryContext based on the information from local IndexSegment.
+ *
+ * @param queryContext
+ * @param indexSegment
+ */
+ @VisibleForTesting
+ public static void rewriteQueryContextWithHints(QueryContext queryContext, IndexSegment indexSegment) {
+ List<ExpressionContext> selectExpressions = queryContext.getSelectExpressions();
+ if (selectExpressions != null && !selectExpressions.isEmpty()) {
+ for (int i = 0; i < selectExpressions.size(); i++) {
+ selectExpressions.set(i, overrideWithExpressionHints(selectExpressions.get(i), indexSegment,
+ queryContext.getExpressionOverrideHints()));
+ }
+ }
+
+ List<ExpressionContext> groupByExpression = queryContext.getGroupByExpressions();
+ if (groupByExpression != null && !groupByExpression.isEmpty()) {
+ for (int i = 0; i < groupByExpression.size(); i++) {
+ groupByExpression.set(i, overrideWithExpressionHints(groupByExpression.get(i), indexSegment,
+ queryContext.getExpressionOverrideHints()));
+ }
+ }
+
+ List<OrderByExpressionContext> orderByExpression = queryContext.getOrderByExpressions();
Review comment:
```suggestion
List<OrderByExpressionContext> orderByExpressions = queryContext.getOrderByExpressions();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#discussion_r840124465
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/RangePredicate.java
##########
@@ -138,4 +138,12 @@ public String toString() {
return "(" + _lhs + (_lowerInclusive ? " >= '" : " > '") + _lowerBound + "' AND " + _lhs + (_upperInclusive
? " <= '" : " < '") + _upperBound + "')";
}
+
+ /**
+ * @return Generated range string, this string has the same format used in the Constructor.
+ */
+ public String getRange() {
Review comment:
No need to have this extra ser/de if lhs can be set
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java
##########
@@ -411,4 +415,69 @@ public static FilterContext getFilter(FilterQueryTree node) {
throw new IllegalStateException();
}
}
+
+ public static FilterContext overrideFilterWithExpressionOverrideHints(FilterContext filter, IndexSegment indexSegment,
+ Map<ExpressionContext, ExpressionContext> getExpressionOverrideHints) {
+ if (filter.getChildren() != null) {
+ // AND, OR, NOT
+ List<FilterContext> newChildren = filter.getChildren().stream().map(
+ filterContext -> overrideFilterWithExpressionOverrideHints(filterContext, indexSegment,
+ getExpressionOverrideHints))
+ .collect(Collectors.toList());
+ return new FilterContext(filter.getType(), newChildren, null);
+ }
+ // PREDICATE
+ Predicate predicate = filter.getPredicate();
+ ExpressionContext newPredicateLhs =
+ overrideWithExpressionHints(indexSegment, getExpressionOverrideHints, predicate.getLhs());
+ Predicate newPredicate = getNewPredicate(predicate, newPredicateLhs);
+ return new FilterContext(filter.getType(), null, newPredicate);
+ }
+
+ public static Predicate getNewPredicate(Predicate predicate, ExpressionContext lhs) {
Review comment:
To save garbage, we can add `setLhs()` to all predicates. Consider adding a `BasePredicate` with `setLhs()` and `getLhs()` and we don't need the switch
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java
##########
@@ -411,4 +415,69 @@ public static FilterContext getFilter(FilterQueryTree node) {
throw new IllegalStateException();
}
}
+
+ public static FilterContext overrideFilterWithExpressionOverrideHints(FilterContext filter, IndexSegment indexSegment,
+ Map<ExpressionContext, ExpressionContext> getExpressionOverrideHints) {
Review comment:
```suggestion
public static FilterContext overrideWithExpressionHints(FilterContext filter, IndexSegment indexSegment,
Map<ExpressionContext, ExpressionContext> expressionOverrideHints) {
```
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java
##########
@@ -411,4 +415,69 @@ public static FilterContext getFilter(FilterQueryTree node) {
throw new IllegalStateException();
}
}
+
+ public static FilterContext overrideFilterWithExpressionOverrideHints(FilterContext filter, IndexSegment indexSegment,
+ Map<ExpressionContext, ExpressionContext> getExpressionOverrideHints) {
+ if (filter.getChildren() != null) {
+ // AND, OR, NOT
+ List<FilterContext> newChildren = filter.getChildren().stream().map(
+ filterContext -> overrideFilterWithExpressionOverrideHints(filterContext, indexSegment,
+ getExpressionOverrideHints))
+ .collect(Collectors.toList());
+ return new FilterContext(filter.getType(), newChildren, null);
+ }
+ // PREDICATE
+ Predicate predicate = filter.getPredicate();
+ ExpressionContext newPredicateLhs =
+ overrideWithExpressionHints(indexSegment, getExpressionOverrideHints, predicate.getLhs());
+ Predicate newPredicate = getNewPredicate(predicate, newPredicateLhs);
+ return new FilterContext(filter.getType(), null, newPredicate);
+ }
+
+ public static Predicate getNewPredicate(Predicate predicate, ExpressionContext lhs) {
+ switch (predicate.getType()) {
+ case EQ:
+ return new EqPredicate(lhs, ((EqPredicate) predicate).getValue());
+ case NOT_EQ:
+ return new NotEqPredicate(lhs, ((NotEqPredicate) predicate).getValue());
+ case IN:
+ return new InPredicate(lhs, ((InPredicate) predicate).getValues());
+ case NOT_IN:
+ return new NotInPredicate(lhs, ((NotInPredicate) predicate).getValues());
+ case RANGE:
+ return new RangePredicate(lhs, ((RangePredicate) predicate).getRange());
+ case REGEXP_LIKE:
+ return new RegexpLikePredicate(lhs, ((RegexpLikePredicate) predicate).getValue());
+ case TEXT_MATCH:
+ return new TextMatchPredicate(lhs, ((TextMatchPredicate) predicate).getValue());
+ case JSON_MATCH:
+ return new JsonMatchPredicate(lhs, ((JsonMatchPredicate) predicate).getValue());
+ case IS_NULL:
+ return new IsNullPredicate(lhs);
+ case IS_NOT_NULL:
+ return new IsNotNullPredicate(lhs);
+ default:
+ throw new IllegalStateException();
+ }
+ }
+
+ public static ExpressionContext overrideWithExpressionHints(IndexSegment indexSegment,
+ Map<ExpressionContext, ExpressionContext> expressionOverrideHints, ExpressionContext expression) {
Review comment:
(minor) Put `expression` as the first argument for consistency
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java
##########
@@ -411,4 +415,69 @@ public static FilterContext getFilter(FilterQueryTree node) {
throw new IllegalStateException();
}
}
+
+ public static FilterContext overrideFilterWithExpressionOverrideHints(FilterContext filter, IndexSegment indexSegment,
+ Map<ExpressionContext, ExpressionContext> getExpressionOverrideHints) {
+ if (filter.getChildren() != null) {
+ // AND, OR, NOT
+ List<FilterContext> newChildren = filter.getChildren().stream().map(
+ filterContext -> overrideFilterWithExpressionOverrideHints(filterContext, indexSegment,
+ getExpressionOverrideHints))
+ .collect(Collectors.toList());
+ return new FilterContext(filter.getType(), newChildren, null);
+ }
+ // PREDICATE
+ Predicate predicate = filter.getPredicate();
+ ExpressionContext newPredicateLhs =
+ overrideWithExpressionHints(indexSegment, getExpressionOverrideHints, predicate.getLhs());
+ Predicate newPredicate = getNewPredicate(predicate, newPredicateLhs);
+ return new FilterContext(filter.getType(), null, newPredicate);
+ }
+
+ public static Predicate getNewPredicate(Predicate predicate, ExpressionContext lhs) {
+ switch (predicate.getType()) {
+ case EQ:
+ return new EqPredicate(lhs, ((EqPredicate) predicate).getValue());
+ case NOT_EQ:
+ return new NotEqPredicate(lhs, ((NotEqPredicate) predicate).getValue());
+ case IN:
+ return new InPredicate(lhs, ((InPredicate) predicate).getValues());
+ case NOT_IN:
+ return new NotInPredicate(lhs, ((NotInPredicate) predicate).getValues());
+ case RANGE:
+ return new RangePredicate(lhs, ((RangePredicate) predicate).getRange());
+ case REGEXP_LIKE:
+ return new RegexpLikePredicate(lhs, ((RegexpLikePredicate) predicate).getValue());
+ case TEXT_MATCH:
+ return new TextMatchPredicate(lhs, ((TextMatchPredicate) predicate).getValue());
+ case JSON_MATCH:
+ return new JsonMatchPredicate(lhs, ((JsonMatchPredicate) predicate).getValue());
+ case IS_NULL:
+ return new IsNullPredicate(lhs);
+ case IS_NOT_NULL:
+ return new IsNotNullPredicate(lhs);
+ default:
+ throw new IllegalStateException();
+ }
+ }
+
+ public static ExpressionContext overrideWithExpressionHints(IndexSegment indexSegment,
+ Map<ExpressionContext, ExpressionContext> expressionOverrideHints, ExpressionContext expression) {
+ if (expression.getType() != ExpressionContext.Type.FUNCTION) {
+ return expression;
+ }
+ ExpressionContext overrideExpression = expressionOverrideHints.get(expression);
+ if (overrideExpression != null && indexSegment.getPhysicalColumnNames()
Review comment:
Check if `overrideExpression` is identifier before looking up the map
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java
##########
@@ -411,4 +415,69 @@ public static FilterContext getFilter(FilterQueryTree node) {
throw new IllegalStateException();
}
}
+
+ public static FilterContext overrideFilterWithExpressionOverrideHints(FilterContext filter, IndexSegment indexSegment,
+ Map<ExpressionContext, ExpressionContext> getExpressionOverrideHints) {
+ if (filter.getChildren() != null) {
+ // AND, OR, NOT
+ List<FilterContext> newChildren = filter.getChildren().stream().map(
+ filterContext -> overrideFilterWithExpressionOverrideHints(filterContext, indexSegment,
+ getExpressionOverrideHints))
+ .collect(Collectors.toList());
+ return new FilterContext(filter.getType(), newChildren, null);
+ }
+ // PREDICATE
+ Predicate predicate = filter.getPredicate();
+ ExpressionContext newPredicateLhs =
+ overrideWithExpressionHints(indexSegment, getExpressionOverrideHints, predicate.getLhs());
+ Predicate newPredicate = getNewPredicate(predicate, newPredicateLhs);
+ return new FilterContext(filter.getType(), null, newPredicate);
+ }
+
+ public static Predicate getNewPredicate(Predicate predicate, ExpressionContext lhs) {
+ switch (predicate.getType()) {
+ case EQ:
+ return new EqPredicate(lhs, ((EqPredicate) predicate).getValue());
+ case NOT_EQ:
+ return new NotEqPredicate(lhs, ((NotEqPredicate) predicate).getValue());
+ case IN:
+ return new InPredicate(lhs, ((InPredicate) predicate).getValues());
+ case NOT_IN:
+ return new NotInPredicate(lhs, ((NotInPredicate) predicate).getValues());
+ case RANGE:
+ return new RangePredicate(lhs, ((RangePredicate) predicate).getRange());
+ case REGEXP_LIKE:
+ return new RegexpLikePredicate(lhs, ((RegexpLikePredicate) predicate).getValue());
+ case TEXT_MATCH:
+ return new TextMatchPredicate(lhs, ((TextMatchPredicate) predicate).getValue());
+ case JSON_MATCH:
+ return new JsonMatchPredicate(lhs, ((JsonMatchPredicate) predicate).getValue());
+ case IS_NULL:
+ return new IsNullPredicate(lhs);
+ case IS_NOT_NULL:
+ return new IsNotNullPredicate(lhs);
+ default:
+ throw new IllegalStateException();
+ }
+ }
+
+ public static ExpressionContext overrideWithExpressionHints(IndexSegment indexSegment,
+ Map<ExpressionContext, ExpressionContext> expressionOverrideHints, ExpressionContext expression) {
+ if (expression.getType() != ExpressionContext.Type.FUNCTION) {
+ return expression;
+ }
+ ExpressionContext overrideExpression = expressionOverrideHints.get(expression);
+ if (overrideExpression != null && indexSegment.getPhysicalColumnNames()
+ .contains(overrideExpression.getIdentifier())) {
+ return overrideExpression;
+ }
+ List<ExpressionContext> newArguments = new ArrayList<>();
Review comment:
We can do in-place replacement to save garbage
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java
##########
@@ -411,4 +415,69 @@ public static FilterContext getFilter(FilterQueryTree node) {
throw new IllegalStateException();
}
}
+
+ public static FilterContext overrideFilterWithExpressionOverrideHints(FilterContext filter, IndexSegment indexSegment,
Review comment:
We should move these data dependent methods to a separate util (or put them in `InstancePlanMakerImplV2` for now, and extract them out in the future if needed to be reused). IMO `RequestContextUtils` should be data independent, and only related to query.
##########
File path: pinot-common/src/test/java/org/apache/pinot/common/request/RequestContextUtilsTest.java
##########
@@ -0,0 +1,191 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.request;
+
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import javax.annotation.Nullable;
+import org.apache.pinot.common.request.context.ExpressionContext;
+import org.apache.pinot.common.request.context.FilterContext;
+import org.apache.pinot.common.request.context.FunctionContext;
+import org.apache.pinot.common.request.context.RequestContextUtils;
+import org.apache.pinot.common.request.context.predicate.EqPredicate;
+import org.apache.pinot.segment.spi.IndexSegment;
+import org.apache.pinot.segment.spi.SegmentMetadata;
+import org.apache.pinot.segment.spi.datasource.DataSource;
+import org.apache.pinot.segment.spi.index.mutable.ThreadSafeMutableRoaringBitmap;
+import org.apache.pinot.segment.spi.index.startree.StarTreeV2;
+import org.apache.pinot.spi.data.readers.GenericRow;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+
+public class RequestContextUtilsTest {
+ private IndexSegment _indexSegment = new IndexSegment() {
+ @Override
+ public String getSegmentName() {
+ return null;
+ }
+
+ @Override
+ public SegmentMetadata getSegmentMetadata() {
+ return null;
+ }
+
+ @Override
+ public Set<String> getColumnNames() {
+ return null;
+ }
+
+ @Override
+ public Set<String> getPhysicalColumnNames() {
+ return ImmutableSet.of("$ts$MONTH");
+ }
+
+ @Override
+ public DataSource getDataSource(String columnName) {
+ return null;
+ }
+
+ @Override
+ public List<StarTreeV2> getStarTrees() {
+ return null;
+ }
+
+ @Nullable
+ @Override
+ public ThreadSafeMutableRoaringBitmap getValidDocIds() {
+ return null;
+ }
+
+ @Override
+ public GenericRow getRecord(int docId, GenericRow reuse) {
+ return null;
+ }
+
+ @Override
+ public void destroy() {
+
+ }
+ };
+
+ @Test
+ public void testExpressionContextHashcode() {
+ ExpressionContext expressionContext1 = ExpressionContext.forIdentifier("abc");
+ ExpressionContext expressionContext2 = ExpressionContext.forIdentifier("abc");
+ Assert.assertEquals(expressionContext1, expressionContext2);
Review comment:
(minor) We may static import assert functions in tests
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
##########
@@ -248,6 +255,48 @@ public PlanNode makeSegmentPlanNode(IndexSegment indexSegment, QueryContext quer
}
}
+ private QueryContext rewriteExpressionsWithHints(IndexSegment indexSegment, QueryContext queryContext) {
+ List<ExpressionContext> newSelectExpressions = queryContext.getSelectExpressions();
+ if (newSelectExpressions != null && !newSelectExpressions.isEmpty()) {
+ newSelectExpressions = newSelectExpressions.stream().map(
Review comment:
We can do in-place replacement to save garbage. Also suggest not using stream api for performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8451](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24574f9) into [master](https://codecov.io/gh/apache/pinot/commit/91c9ce4aebca3913065e08263c6e80f7f515dd50?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91c9ce4) will **increase** coverage by `6.51%`.
> The diff coverage is `41.97%`.
```diff
@@ Coverage Diff @@
## master #8451 +/- ##
============================================
+ Coverage 64.21% 70.72% +6.51%
+ Complexity 4282 4281 -1
============================================
Files 1618 1663 +45
Lines 85376 87362 +1986
Branches 13004 13220 +216
============================================
+ Hits 54820 61789 +6969
+ Misses 26576 21287 -5289
- Partials 3980 4286 +306
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `27.19% <11.11%> (?)` | |
| integration2 | `26.13% <11.11%> (?)` | |
| unittests1 | `67.00% <41.97%> (-0.05%)` | :arrow_down: |
| unittests2 | `14.18% <0.00%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pinot/core/plan/maker/InstancePlanMakerImplV2.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL21ha2VyL0luc3RhbmNlUGxhbk1ha2VySW1wbFYyLmphdmE=) | `58.77% <0.00%> (-4.23%)` | :arrow_down: |
| [...xt/utils/BrokerRequestToQueryContextConverter.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvdXRpbHMvQnJva2VyUmVxdWVzdFRvUXVlcnlDb250ZXh0Q29udmVydGVyLmphdmE=) | `94.89% <44.44%> (-1.24%)` | :arrow_down: |
| [...ot/common/request/context/RequestContextUtils.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L1JlcXVlc3RDb250ZXh0VXRpbHMuamF2YQ==) | `72.26% <67.64%> (+0.21%)` | :arrow_up: |
| [...mmon/request/context/predicate/RangePredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9SYW5nZVByZWRpY2F0ZS5qYXZh) | `75.55% <100.00%> (+1.13%)` | :arrow_up: |
| [...pinot/core/query/request/context/QueryContext.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvUXVlcnlDb250ZXh0LmphdmE=) | `98.07% <100.00%> (+0.03%)` | :arrow_up: |
| [.../helix/core/minion/MinionInstancesCleanupTask.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL21pbmlvbi9NaW5pb25JbnN0YW5jZXNDbGVhbnVwVGFzay5qYXZh) | `77.27% <0.00%> (-4.55%)` | :arrow_down: |
| [.../impl/dictionary/BaseOffHeapMutableDictionary.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvQmFzZU9mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `81.33% <0.00%> (-3.34%)` | :arrow_down: |
| [.../aggregation/function/ModeAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9Nb2RlQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `88.37% <0.00%> (-0.28%)` | :arrow_down: |
| [...che/pinot/plugin/metrics/yammer/YammerMetered.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcGx1Z2lucy9waW5vdC1tZXRyaWNzL3Bpbm90LXlhbW1lci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGx1Z2luL21ldHJpY3MveWFtbWVyL1lhbW1lck1ldGVyZWQuamF2YQ==) | `25.00% <0.00%> (ø)` | |
| [...ugin/inputformat/avro/KafkaAvroMessageDecoder.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcGx1Z2lucy9waW5vdC1pbnB1dC1mb3JtYXQvcGlub3QtYXZyby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGx1Z2luL2lucHV0Zm9ybWF0L2F2cm8vS2Fma2FBdnJvTWVzc2FnZURlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [375 more](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [91c9ce4...24574f9](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8451](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24574f9) into [master](https://codecov.io/gh/apache/pinot/commit/91c9ce4aebca3913065e08263c6e80f7f515dd50?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91c9ce4) will **increase** coverage by `6.51%`.
> The diff coverage is `41.97%`.
```diff
@@ Coverage Diff @@
## master #8451 +/- ##
============================================
+ Coverage 64.21% 70.72% +6.51%
+ Complexity 4282 4281 -1
============================================
Files 1618 1663 +45
Lines 85376 87362 +1986
Branches 13004 13220 +216
============================================
+ Hits 54820 61789 +6969
+ Misses 26576 21287 -5289
- Partials 3980 4286 +306
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `27.19% <11.11%> (?)` | |
| integration2 | `26.13% <11.11%> (?)` | |
| unittests1 | `67.00% <41.97%> (-0.05%)` | :arrow_down: |
| unittests2 | `14.18% <0.00%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pinot/core/plan/maker/InstancePlanMakerImplV2.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL21ha2VyL0luc3RhbmNlUGxhbk1ha2VySW1wbFYyLmphdmE=) | `58.77% <0.00%> (-4.23%)` | :arrow_down: |
| [...xt/utils/BrokerRequestToQueryContextConverter.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvdXRpbHMvQnJva2VyUmVxdWVzdFRvUXVlcnlDb250ZXh0Q29udmVydGVyLmphdmE=) | `94.89% <44.44%> (-1.24%)` | :arrow_down: |
| [...ot/common/request/context/RequestContextUtils.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L1JlcXVlc3RDb250ZXh0VXRpbHMuamF2YQ==) | `72.26% <67.64%> (+0.21%)` | :arrow_up: |
| [...mmon/request/context/predicate/RangePredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9SYW5nZVByZWRpY2F0ZS5qYXZh) | `75.55% <100.00%> (+1.13%)` | :arrow_up: |
| [...pinot/core/query/request/context/QueryContext.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvUXVlcnlDb250ZXh0LmphdmE=) | `98.07% <100.00%> (+0.03%)` | :arrow_up: |
| [.../helix/core/minion/MinionInstancesCleanupTask.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL21pbmlvbi9NaW5pb25JbnN0YW5jZXNDbGVhbnVwVGFzay5qYXZh) | `77.27% <0.00%> (-4.55%)` | :arrow_down: |
| [.../impl/dictionary/BaseOffHeapMutableDictionary.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvQmFzZU9mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `81.33% <0.00%> (-3.34%)` | :arrow_down: |
| [.../aggregation/function/ModeAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9Nb2RlQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `88.37% <0.00%> (-0.28%)` | :arrow_down: |
| [.../plugin/inputformat/csv/CSVRecordReaderConfig.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtcGx1Z2lucy9waW5vdC1pbnB1dC1mb3JtYXQvcGlub3QtY3N2L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wbHVnaW4vaW5wdXRmb3JtYXQvY3N2L0NTVlJlY29yZFJlYWRlckNvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...che/pinot/server/api/resources/TablesResource.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvYXBpL3Jlc291cmNlcy9UYWJsZXNSZXNvdXJjZS5qYXZh) | `43.97% <0.00%> (ø)` | |
| ... and [375 more](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [91c9ce4...24574f9](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8451](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4bfb2df) into [master](https://codecov.io/gh/apache/pinot/commit/e7a2f5b2c08b75a718bf2619dc9abe51a07736ed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7a2f5b) will **decrease** coverage by `34.18%`.
> The diff coverage is `37.14%`.
> :exclamation: Current head 4bfb2df differs from pull request most recent head 292e9de. Consider uploading reports for the commit 292e9de to get more accurate results
```diff
@@ Coverage Diff @@
## master #8451 +/- ##
=============================================
- Coverage 70.68% 36.49% -34.19%
+ Complexity 4282 84 -4198
=============================================
Files 1663 1664 +1
Lines 87288 87324 +36
Branches 13210 13221 +11
=============================================
- Hits 61697 31868 -29829
- Misses 21305 52889 +31584
+ Partials 4286 2567 -1719
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `27.15% <35.71%> (+0.04%)` | :arrow_up: |
| integration2 | `25.96% <35.71%> (-0.04%)` | :arrow_down: |
| unittests1 | `?` | |
| unittests2 | `14.14% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mon/request/context/predicate/IsNullPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Jc051bGxQcmVkaWNhdGUuamF2YQ==) | `0.00% <0.00%> (-69.24%)` | :arrow_down: |
| [...ot/common/request/context/predicate/Predicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9QcmVkaWNhdGUuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...pinot/core/plan/maker/InstancePlanMakerImplV2.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL21ha2VyL0luc3RhbmNlUGxhbk1ha2VySW1wbFYyLmphdmE=) | `46.04% <7.69%> (-30.96%)` | :arrow_down: |
| [...xt/utils/BrokerRequestToQueryContextConverter.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvdXRpbHMvQnJva2VyUmVxdWVzdFRvUXVlcnlDb250ZXh0Q29udmVydGVyLmphdmE=) | `62.77% <44.44%> (-35.68%)` | :arrow_down: |
| [...ommon/request/context/predicate/BasePredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9CYXNlUHJlZGljYXRlLmphdmE=) | `66.66% <66.66%> (ø)` | |
| [.../common/request/context/predicate/EqPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9FcVByZWRpY2F0ZS5qYXZh) | `46.15% <100.00%> (-20.52%)` | :arrow_down: |
| [.../common/request/context/predicate/InPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9JblByZWRpY2F0ZS5qYXZh) | `38.88% <100.00%> (-36.12%)` | :arrow_down: |
| [.../request/context/predicate/IsNotNullPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Jc05vdE51bGxQcmVkaWNhdGUuamF2YQ==) | `36.36% <100.00%> (-32.87%)` | :arrow_down: |
| [.../request/context/predicate/JsonMatchPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Kc29uTWF0Y2hQcmVkaWNhdGUuamF2YQ==) | `38.46% <100.00%> (-21.54%)` | :arrow_down: |
| [...mmon/request/context/predicate/NotEqPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Ob3RFcVByZWRpY2F0ZS5qYXZh) | `46.15% <100.00%> (-20.52%)` | :arrow_down: |
| ... and [971 more](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e7a2f5b...292e9de](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8451](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f37146c) into [master](https://codecov.io/gh/apache/pinot/commit/86958b6e0bcdd51c3de0afc1196baea64bc4b92c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86958b6) will **decrease** coverage by `0.03%`.
> The diff coverage is `41.97%`.
```diff
@@ Coverage Diff @@
## master #8451 +/- ##
============================================
- Coverage 70.64% 70.60% -0.04%
+ Complexity 4284 4281 -3
============================================
Files 1663 1663
Lines 87285 87364 +79
Branches 13208 13220 +12
============================================
+ Hits 61660 61681 +21
- Misses 21341 21398 +57
- Partials 4284 4285 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `27.07% <11.11%> (-0.01%)` | :arrow_down: |
| integration2 | `25.94% <11.11%> (-0.09%)` | :arrow_down: |
| unittests1 | `67.01% <41.97%> (-0.08%)` | :arrow_down: |
| unittests2 | `14.11% <0.00%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pinot/core/plan/maker/InstancePlanMakerImplV2.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL21ha2VyL0luc3RhbmNlUGxhbk1ha2VySW1wbFYyLmphdmE=) | `58.77% <0.00%> (-18.23%)` | :arrow_down: |
| [...xt/utils/BrokerRequestToQueryContextConverter.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvdXRpbHMvQnJva2VyUmVxdWVzdFRvUXVlcnlDb250ZXh0Q29udmVydGVyLmphdmE=) | `94.89% <44.44%> (-3.56%)` | :arrow_down: |
| [...ot/common/request/context/RequestContextUtils.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L1JlcXVlc3RDb250ZXh0VXRpbHMuamF2YQ==) | `72.26% <67.64%> (-0.78%)` | :arrow_down: |
| [...mmon/request/context/predicate/RangePredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9SYW5nZVByZWRpY2F0ZS5qYXZh) | `75.55% <100.00%> (+1.13%)` | :arrow_up: |
| [...pinot/core/query/request/context/QueryContext.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvUXVlcnlDb250ZXh0LmphdmE=) | `98.07% <100.00%> (+0.03%)` | :arrow_up: |
| [...nt/local/startree/v2/store/StarTreeDataSource.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zdGFydHJlZS92Mi9zdG9yZS9TdGFyVHJlZURhdGFTb3VyY2UuamF2YQ==) | `40.00% <0.00%> (-13.34%)` | :arrow_down: |
| [...he/pinot/segment/local/segment/store/IndexKey.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zZWdtZW50L3N0b3JlL0luZGV4S2V5LmphdmE=) | `65.00% <0.00%> (-10.00%)` | :arrow_down: |
| [...core/startree/operator/StarTreeFilterOperator.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9vcGVyYXRvci9TdGFyVHJlZUZpbHRlck9wZXJhdG9yLmphdmE=) | `85.31% <0.00%> (-7.70%)` | :arrow_down: |
| [...ot/segment/local/startree/OffHeapStarTreeNode.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zdGFydHJlZS9PZmZIZWFwU3RhclRyZWVOb2RlLmphdmE=) | `72.22% <0.00%> (-5.56%)` | :arrow_down: |
| [...ion/function/DistinctCountAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9EaXN0aW5jdENvdW50QWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `51.56% <0.00%> (-4.49%)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86958b6...f37146c](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8451](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f37146c) into [master](https://codecov.io/gh/apache/pinot/commit/86958b6e0bcdd51c3de0afc1196baea64bc4b92c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86958b6) will **decrease** coverage by `7.30%`.
> The diff coverage is `41.97%`.
```diff
@@ Coverage Diff @@
## master #8451 +/- ##
============================================
- Coverage 69.58% 62.27% -7.31%
+ Complexity 4284 4197 -87
============================================
Files 1663 1651 -12
Lines 87285 87010 -275
Branches 13208 13182 -26
============================================
- Hits 60738 54188 -6550
- Misses 22278 28807 +6529
+ Partials 4269 4015 -254
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `27.07% <11.11%> (-0.01%)` | :arrow_down: |
| unittests1 | `67.01% <41.97%> (-0.08%)` | :arrow_down: |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pinot/core/plan/maker/InstancePlanMakerImplV2.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL21ha2VyL0luc3RhbmNlUGxhbk1ha2VySW1wbFYyLmphdmE=) | `48.09% <0.00%> (-14.91%)` | :arrow_down: |
| [...xt/utils/BrokerRequestToQueryContextConverter.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvdXRpbHMvQnJva2VyUmVxdWVzdFRvUXVlcnlDb250ZXh0Q29udmVydGVyLmphdmE=) | `94.89% <44.44%> (-3.56%)` | :arrow_down: |
| [...ot/common/request/context/RequestContextUtils.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L1JlcXVlc3RDb250ZXh0VXRpbHMuamF2YQ==) | `72.26% <67.64%> (-0.78%)` | :arrow_down: |
| [...mmon/request/context/predicate/RangePredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9SYW5nZVByZWRpY2F0ZS5qYXZh) | `75.55% <100.00%> (+1.13%)` | :arrow_up: |
| [...pinot/core/query/request/context/QueryContext.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvUXVlcnlDb250ZXh0LmphdmE=) | `98.07% <100.00%> (+0.03%)` | :arrow_up: |
| [...pinot/controller/recommender/io/ConfigManager.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9yZWNvbW1lbmRlci9pby9Db25maWdNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/client/AggregationResultSet.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0FnZ3JlZ2F0aW9uUmVzdWx0U2V0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...troller/recommender/io/metadata/FieldMetadata.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9yZWNvbW1lbmRlci9pby9tZXRhZGF0YS9GaWVsZE1ldGFkYXRhLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...roller/recommender/rules/impl/BloomFilterRule.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9yZWNvbW1lbmRlci9ydWxlcy9pbXBsL0Jsb29tRmlsdGVyUnVsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...oller/api/resources/PinotControllerAppConfigs.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90Q29udHJvbGxlckFwcENvbmZpZ3MuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [226 more](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86958b6...f37146c](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8451](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fefc640) into [master](https://codecov.io/gh/apache/pinot/commit/e7a2f5b2c08b75a718bf2619dc9abe51a07736ed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7a2f5b) will **decrease** coverage by `1.35%`.
> The diff coverage is `53.75%`.
> :exclamation: Current head fefc640 differs from pull request most recent head 7aaa74d. Consider uploading reports for the commit 7aaa74d to get more accurate results
```diff
@@ Coverage Diff @@
## master #8451 +/- ##
============================================
- Coverage 70.68% 69.32% -1.36%
Complexity 4282 4282
============================================
Files 1663 1664 +1
Lines 87288 87334 +46
Branches 13210 13225 +15
============================================
- Hits 61697 60548 -1149
- Misses 21305 22538 +1233
+ Partials 4286 4248 -38
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `25.87% <27.50%> (-0.13%)` | :arrow_down: |
| unittests1 | `67.00% <53.75%> (-0.04%)` | :arrow_down: |
| unittests2 | `14.16% <0.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ot/common/request/context/predicate/Predicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9QcmVkaWNhdGUuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...pinot/core/plan/maker/InstancePlanMakerImplV2.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL21ha2VyL0luc3RhbmNlUGxhbk1ha2VySW1wbFYyLmphdmE=) | `63.08% <34.69%> (-13.92%)` | :arrow_down: |
| [...xt/utils/BrokerRequestToQueryContextConverter.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvdXRpbHMvQnJva2VyUmVxdWVzdFRvUXVlcnlDb250ZXh0Q29udmVydGVyLmphdmE=) | `94.89% <44.44%> (-3.56%)` | :arrow_down: |
| [...ommon/request/context/predicate/BasePredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9CYXNlUHJlZGljYXRlLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../common/request/context/predicate/EqPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9FcVByZWRpY2F0ZS5qYXZh) | `61.53% <100.00%> (-5.13%)` | :arrow_down: |
| [.../common/request/context/predicate/InPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9JblByZWRpY2F0ZS5qYXZh) | `72.22% <100.00%> (-2.78%)` | :arrow_down: |
| [.../request/context/predicate/IsNotNullPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Jc05vdE51bGxQcmVkaWNhdGUuamF2YQ==) | `63.63% <100.00%> (-5.60%)` | :arrow_down: |
| [...mon/request/context/predicate/IsNullPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Jc051bGxQcmVkaWNhdGUuamF2YQ==) | `63.63% <100.00%> (-5.60%)` | :arrow_down: |
| [.../request/context/predicate/JsonMatchPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Kc29uTWF0Y2hQcmVkaWNhdGUuamF2YQ==) | `53.84% <100.00%> (-6.16%)` | :arrow_down: |
| [...mmon/request/context/predicate/NotEqPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Ob3RFcVByZWRpY2F0ZS5qYXZh) | `61.53% <100.00%> (-5.13%)` | :arrow_down: |
| ... and [142 more](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e7a2f5b...7aaa74d](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 merged pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
xiangfu0 merged pull request #8451:
URL: https://github.com/apache/pinot/pull/8451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8451](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24574f9) into [master](https://codecov.io/gh/apache/pinot/commit/91c9ce4aebca3913065e08263c6e80f7f515dd50?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91c9ce4) will **increase** coverage by `0.01%`.
> The diff coverage is `41.97%`.
```diff
@@ Coverage Diff @@
## master #8451 +/- ##
============================================
+ Coverage 64.21% 64.22% +0.01%
+ Complexity 4282 4281 -1
============================================
Files 1618 1618
Lines 85376 85455 +79
Branches 13004 13016 +12
============================================
+ Hits 54820 54880 +60
- Misses 26576 26580 +4
- Partials 3980 3995 +15
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests1 | `67.00% <41.97%> (-0.05%)` | :arrow_down: |
| unittests2 | `14.18% <0.00%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pinot/core/plan/maker/InstancePlanMakerImplV2.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL21ha2VyL0luc3RhbmNlUGxhbk1ha2VySW1wbFYyLmphdmE=) | `48.09% <0.00%> (-14.91%)` | :arrow_down: |
| [...xt/utils/BrokerRequestToQueryContextConverter.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvdXRpbHMvQnJva2VyUmVxdWVzdFRvUXVlcnlDb250ZXh0Q29udmVydGVyLmphdmE=) | `92.70% <44.44%> (-3.43%)` | :arrow_down: |
| [...ot/common/request/context/RequestContextUtils.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L1JlcXVlc3RDb250ZXh0VXRpbHMuamF2YQ==) | `71.42% <67.64%> (-0.64%)` | :arrow_down: |
| [...mmon/request/context/predicate/RangePredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9SYW5nZVByZWRpY2F0ZS5qYXZh) | `75.55% <100.00%> (+1.13%)` | :arrow_up: |
| [...pinot/core/query/request/context/QueryContext.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvUXVlcnlDb250ZXh0LmphdmE=) | `98.07% <100.00%> (+0.03%)` | :arrow_up: |
| [.../helix/core/minion/MinionInstancesCleanupTask.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL21pbmlvbi9NaW5pb25JbnN0YW5jZXNDbGVhbnVwVGFzay5qYXZh) | `77.27% <0.00%> (-4.55%)` | :arrow_down: |
| [.../impl/dictionary/BaseOffHeapMutableDictionary.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvQmFzZU9mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `81.33% <0.00%> (-3.34%)` | :arrow_down: |
| [...ces/PinotSegmentUploadDownloadRestletResource.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90U2VnbWVudFVwbG9hZERvd25sb2FkUmVzdGxldFJlc291cmNlLmphdmE=) | `41.49% <0.00%> (-1.25%)` | :arrow_down: |
| [.../aggregation/function/ModeAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9Nb2RlQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `88.37% <0.00%> (-0.28%)` | :arrow_down: |
| [...lix/core/realtime/PinotRealtimeSegmentManager.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90UmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh) | `78.01% <0.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [91c9ce4...24574f9](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8451](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85dd906) into [master](https://codecov.io/gh/apache/pinot/commit/370d86c298c68def6e830b868fa16cabda9d08ff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (370d86c) will **decrease** coverage by `7.04%`.
> The diff coverage is `82.85%`.
> :exclamation: Current head 85dd906 differs from pull request most recent head f2637f9. Consider uploading reports for the commit f2637f9 to get more accurate results
```diff
@@ Coverage Diff @@
## master #8451 +/- ##
============================================
- Coverage 70.63% 63.59% -7.05%
+ Complexity 4282 4198 -84
============================================
Files 1663 1652 -11
Lines 87305 86987 -318
Branches 13216 13189 -27
============================================
- Hits 61671 55319 -6352
- Misses 21350 27616 +6266
+ Partials 4284 4052 -232
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `27.18% <35.71%> (+0.15%)` | :arrow_up: |
| integration2 | `26.10% <35.71%> (+0.25%)` | :arrow_up: |
| unittests1 | `67.04% <82.85%> (-0.01%)` | :arrow_down: |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ot/common/request/context/predicate/Predicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9QcmVkaWNhdGUuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...pinot/core/plan/maker/InstancePlanMakerImplV2.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL21ha2VyL0luc3RhbmNlUGxhbk1ha2VySW1wbFYyLmphdmE=) | `74.82% <69.23%> (-2.18%)` | :arrow_down: |
| [...ommon/request/context/predicate/BasePredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9CYXNlUHJlZGljYXRlLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../common/request/context/predicate/EqPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9FcVByZWRpY2F0ZS5qYXZh) | `61.53% <100.00%> (-5.13%)` | :arrow_down: |
| [.../common/request/context/predicate/InPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9JblByZWRpY2F0ZS5qYXZh) | `72.22% <100.00%> (-2.78%)` | :arrow_down: |
| [.../request/context/predicate/IsNotNullPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Jc05vdE51bGxQcmVkaWNhdGUuamF2YQ==) | `63.63% <100.00%> (-5.60%)` | :arrow_down: |
| [...mon/request/context/predicate/IsNullPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Jc051bGxQcmVkaWNhdGUuamF2YQ==) | `63.63% <100.00%> (-5.60%)` | :arrow_down: |
| [.../request/context/predicate/JsonMatchPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Kc29uTWF0Y2hQcmVkaWNhdGUuamF2YQ==) | `53.84% <100.00%> (-6.16%)` | :arrow_down: |
| [...mmon/request/context/predicate/NotEqPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Ob3RFcVByZWRpY2F0ZS5qYXZh) | `61.53% <100.00%> (-5.13%)` | :arrow_down: |
| [...mmon/request/context/predicate/NotInPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Ob3RJblByZWRpY2F0ZS5qYXZh) | `72.22% <100.00%> (-2.78%)` | :arrow_down: |
| ... and [234 more](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [370d86c...f2637f9](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8451](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fefc640) into [master](https://codecov.io/gh/apache/pinot/commit/e7a2f5b2c08b75a718bf2619dc9abe51a07736ed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7a2f5b) will **increase** coverage by `0.01%`.
> The diff coverage is `53.75%`.
> :exclamation: Current head fefc640 differs from pull request most recent head 7aaa74d. Consider uploading reports for the commit 7aaa74d to get more accurate results
```diff
@@ Coverage Diff @@
## master #8451 +/- ##
============================================
+ Coverage 70.68% 70.69% +0.01%
Complexity 4282 4282
============================================
Files 1663 1664 +1
Lines 87288 87334 +46
Branches 13210 13225 +15
============================================
+ Hits 61697 61745 +48
+ Misses 21305 21302 -3
- Partials 4286 4287 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `27.15% <27.50%> (+0.04%)` | :arrow_up: |
| integration2 | `25.87% <27.50%> (-0.13%)` | :arrow_down: |
| unittests1 | `67.00% <53.75%> (-0.04%)` | :arrow_down: |
| unittests2 | `14.16% <0.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ot/common/request/context/predicate/Predicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9QcmVkaWNhdGUuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...pinot/core/plan/maker/InstancePlanMakerImplV2.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL21ha2VyL0luc3RhbmNlUGxhbk1ha2VySW1wbFYyLmphdmE=) | `63.08% <34.69%> (-13.92%)` | :arrow_down: |
| [...xt/utils/BrokerRequestToQueryContextConverter.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvdXRpbHMvQnJva2VyUmVxdWVzdFRvUXVlcnlDb250ZXh0Q29udmVydGVyLmphdmE=) | `94.89% <44.44%> (-3.56%)` | :arrow_down: |
| [...ommon/request/context/predicate/BasePredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9CYXNlUHJlZGljYXRlLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../common/request/context/predicate/EqPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9FcVByZWRpY2F0ZS5qYXZh) | `61.53% <100.00%> (-5.13%)` | :arrow_down: |
| [.../common/request/context/predicate/InPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9JblByZWRpY2F0ZS5qYXZh) | `72.22% <100.00%> (-2.78%)` | :arrow_down: |
| [.../request/context/predicate/IsNotNullPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Jc05vdE51bGxQcmVkaWNhdGUuamF2YQ==) | `63.63% <100.00%> (-5.60%)` | :arrow_down: |
| [...mon/request/context/predicate/IsNullPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Jc051bGxQcmVkaWNhdGUuamF2YQ==) | `63.63% <100.00%> (-5.60%)` | :arrow_down: |
| [.../request/context/predicate/JsonMatchPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Kc29uTWF0Y2hQcmVkaWNhdGUuamF2YQ==) | `53.84% <100.00%> (-6.16%)` | :arrow_down: |
| [...mmon/request/context/predicate/NotEqPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Ob3RFcVByZWRpY2F0ZS5qYXZh) | `61.53% <100.00%> (-5.13%)` | :arrow_down: |
| ... and [50 more](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e7a2f5b...7aaa74d](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8451](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f37146c) into [master](https://codecov.io/gh/apache/pinot/commit/86958b6e0bcdd51c3de0afc1196baea64bc4b92c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86958b6) will **increase** coverage by `2.77%`.
> The diff coverage is `41.97%`.
```diff
@@ Coverage Diff @@
## master #8451 +/- ##
============================================
+ Coverage 64.23% 67.01% +2.77%
+ Complexity 4284 4197 -87
============================================
Files 1618 1261 -357
Lines 85378 63811 -21567
Branches 13004 10020 -2984
============================================
- Hits 54844 42762 -12082
+ Misses 26548 17977 -8571
+ Partials 3986 3072 -914
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests1 | `67.01% <41.97%> (-0.08%)` | :arrow_down: |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pinot/core/plan/maker/InstancePlanMakerImplV2.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL21ha2VyL0luc3RhbmNlUGxhbk1ha2VySW1wbFYyLmphdmE=) | `48.09% <0.00%> (-14.91%)` | :arrow_down: |
| [...xt/utils/BrokerRequestToQueryContextConverter.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvdXRpbHMvQnJva2VyUmVxdWVzdFRvUXVlcnlDb250ZXh0Q29udmVydGVyLmphdmE=) | `92.70% <44.44%> (-3.43%)` | :arrow_down: |
| [...ot/common/request/context/RequestContextUtils.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L1JlcXVlc3RDb250ZXh0VXRpbHMuamF2YQ==) | `71.42% <67.64%> (-0.64%)` | :arrow_down: |
| [...mmon/request/context/predicate/RangePredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9SYW5nZVByZWRpY2F0ZS5qYXZh) | `75.55% <100.00%> (+1.13%)` | :arrow_up: |
| [...pinot/core/query/request/context/QueryContext.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvUXVlcnlDb250ZXh0LmphdmE=) | `98.07% <100.00%> (+0.03%)` | :arrow_up: |
| [...core/startree/operator/StarTreeFilterOperator.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9vcGVyYXRvci9TdGFyVHJlZUZpbHRlck9wZXJhdG9yLmphdmE=) | `67.13% <0.00%> (-15.39%)` | :arrow_down: |
| [...nt/local/startree/v2/store/StarTreeDataSource.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zdGFydHJlZS92Mi9zdG9yZS9TdGFyVHJlZURhdGFTb3VyY2UuamF2YQ==) | `40.00% <0.00%> (-13.34%)` | :arrow_down: |
| [...he/pinot/segment/local/segment/store/IndexKey.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zZWdtZW50L3N0b3JlL0luZGV4S2V5LmphdmE=) | `65.00% <0.00%> (-10.00%)` | :arrow_down: |
| [...ot/segment/local/startree/OffHeapStarTreeNode.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zdGFydHJlZS9PZmZIZWFwU3RhclRyZWVOb2RlLmphdmE=) | `72.22% <0.00%> (-5.56%)` | :arrow_down: |
| [.../aggregation/function/ModeAggregationFunction.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9Nb2RlQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `88.10% <0.00%> (-0.55%)` | :arrow_down: |
| ... and [360 more](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86958b6...f37146c](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8451](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85dd906) into [master](https://codecov.io/gh/apache/pinot/commit/370d86c298c68def6e830b868fa16cabda9d08ff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (370d86c) will **decrease** coverage by `3.59%`.
> The diff coverage is `82.85%`.
> :exclamation: Current head 85dd906 differs from pull request most recent head f2637f9. Consider uploading reports for the commit f2637f9 to get more accurate results
```diff
@@ Coverage Diff @@
## master #8451 +/- ##
============================================
- Coverage 70.63% 67.04% -3.60%
+ Complexity 4282 4198 -84
============================================
Files 1663 1262 -401
Lines 87305 63772 -23533
Branches 13216 10021 -3195
============================================
- Hits 61671 42753 -18918
+ Misses 21350 17939 -3411
+ Partials 4284 3080 -1204
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `67.04% <82.85%> (-0.01%)` | :arrow_down: |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ot/common/request/context/predicate/Predicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9QcmVkaWNhdGUuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...pinot/core/plan/maker/InstancePlanMakerImplV2.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL21ha2VyL0luc3RhbmNlUGxhbk1ha2VySW1wbFYyLmphdmE=) | `64.74% <69.23%> (-12.26%)` | :arrow_down: |
| [...ommon/request/context/predicate/BasePredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9CYXNlUHJlZGljYXRlLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../common/request/context/predicate/EqPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9FcVByZWRpY2F0ZS5qYXZh) | `61.53% <100.00%> (-5.13%)` | :arrow_down: |
| [.../common/request/context/predicate/InPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9JblByZWRpY2F0ZS5qYXZh) | `72.22% <100.00%> (-2.78%)` | :arrow_down: |
| [.../request/context/predicate/IsNotNullPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Jc05vdE51bGxQcmVkaWNhdGUuamF2YQ==) | `63.63% <100.00%> (-5.60%)` | :arrow_down: |
| [...mon/request/context/predicate/IsNullPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Jc051bGxQcmVkaWNhdGUuamF2YQ==) | `63.63% <100.00%> (-5.60%)` | :arrow_down: |
| [.../request/context/predicate/JsonMatchPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Kc29uTWF0Y2hQcmVkaWNhdGUuamF2YQ==) | `53.84% <100.00%> (-6.16%)` | :arrow_down: |
| [...mmon/request/context/predicate/NotEqPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Ob3RFcVByZWRpY2F0ZS5qYXZh) | `61.53% <100.00%> (-5.13%)` | :arrow_down: |
| [...mmon/request/context/predicate/NotInPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Ob3RJblByZWRpY2F0ZS5qYXZh) | `72.22% <100.00%> (-2.78%)` | :arrow_down: |
| ... and [645 more](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [370d86c...f2637f9](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8451:
URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8451](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f2637f9) into [master](https://codecov.io/gh/apache/pinot/commit/370d86c298c68def6e830b868fa16cabda9d08ff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (370d86c) will **decrease** coverage by `56.49%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #8451 +/- ##
=============================================
- Coverage 70.63% 14.14% -56.50%
+ Complexity 4282 84 -4198
=============================================
Files 1663 1619 -44
Lines 87305 85434 -1871
Branches 13216 13023 -193
=============================================
- Hits 61671 12084 -49587
- Misses 21350 72442 +51092
+ Partials 4284 908 -3376
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `14.14% <0.00%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ommon/request/context/predicate/BasePredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9CYXNlUHJlZGljYXRlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../common/request/context/predicate/EqPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9FcVByZWRpY2F0ZS5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [.../common/request/context/predicate/InPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9JblByZWRpY2F0ZS5qYXZh) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [.../request/context/predicate/IsNotNullPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Jc05vdE51bGxQcmVkaWNhdGUuamF2YQ==) | `0.00% <0.00%> (-69.24%)` | :arrow_down: |
| [...mon/request/context/predicate/IsNullPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Jc051bGxQcmVkaWNhdGUuamF2YQ==) | `0.00% <0.00%> (-69.24%)` | :arrow_down: |
| [.../request/context/predicate/JsonMatchPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Kc29uTWF0Y2hQcmVkaWNhdGUuamF2YQ==) | `0.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...mmon/request/context/predicate/NotEqPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Ob3RFcVByZWRpY2F0ZS5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...mmon/request/context/predicate/NotInPredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9Ob3RJblByZWRpY2F0ZS5qYXZh) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...ot/common/request/context/predicate/Predicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9QcmVkaWNhdGUuamF2YQ==) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [...mmon/request/context/predicate/RangePredicate.java](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9jb250ZXh0L3ByZWRpY2F0ZS9SYW5nZVByZWRpY2F0ZS5qYXZh) | `0.00% <0.00%> (-74.42%)` | :arrow_down: |
| ... and [1336 more](https://codecov.io/gh/apache/pinot/pull/8451/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [370d86c...f2637f9](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org