[jira] [Updated] (TS-3268) Superfluous #ifdef in proxy/CoreUtils.cc

["Alan M. Carroll (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alan M. Carroll updated TS-3268:
--------------------------------
    Fix Version/s:     (was: 7.0.0)
                   sometime

> Superfluous #ifdef in proxy/CoreUtils.cc
> ----------------------------------------
>
>                 Key: TS-3268
>                 URL: https://issues.apache.org/jira/browse/TS-3268
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Leif Hedstrom
>            Assignee: Jason Kenny
>             Fix For: sometime
>
>
> This seems odd / wonky to me:
> {code}
> #if defined(darwin) || defined(freebsd) || defined(solaris) || defined(openbsd) // FIXME: solaris x86
> // TODO: Cleanup multiple includes
> #include <stdio.h>
> #include <stdlib.h>
> #include <stdint.h>
> #include <math.h>
> #include "libts.h"
> #include "CoreUtils.h"
> #endif /* darwin || freebsd || solaris */
> {code}
> None of these seem specific to *BSD, and some are included elsewhere anyways. It seems we ought to be eliminate this, or possibly, narrow down the ifdef to not be platform specific (but depending on existence of include files the normal autoconf way).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)