You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "shruti-p-s (via GitHub)" <gi...@apache.org> on 2026/02/04 00:19:10 UTC
[PR] CASSSIDECAR-400- Fixing sidecar’s ProcessLifecycleProviderIntegrationTest() failure in root mode [cassandra-sidecar]
shruti-p-s opened a new pull request, #313:
URL: https://github.com/apache/cassandra-sidecar/pull/313
Patch by Shruti Sekaran; Reviewed by TBD for [CASSSIDECAR-400](https://issues.apache.org/jira/browse/CASSSIDECAR-400)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-400- Fixing sidecar’s ProcessLifecycleProviderIntegrationTest() failure in root mode [cassandra-sidecar]
Posted by "shruti-p-s (via GitHub)" <gi...@apache.org>.
shruti-p-s commented on code in PR #313:
URL: https://github.com/apache/cassandra-sidecar/pull/313#discussion_r2765299499
##########
server/src/main/java/org/apache/cassandra/sidecar/lifecycle/ProcessRuntimeConfiguration.java:
##########
@@ -128,6 +128,7 @@ public ProcessBuilder buildStartCommand(String pidFileLocation, Path stdoutFileL
startCassandraCmd.add(cassandraBin().toString());
startCassandraCmd.add("-p");
startCassandraCmd.add(pidFileLocation);
+ startCassandraCmd.add("-R"); // Allow running as root (required for Cassandra 5.0+ when running as root)
Review Comment:
Makes sense, I've updated the argument as a test override
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-400- Fixing sidecar’s ProcessLifecycleProviderIntegrationTest() failure in root mode [cassandra-sidecar]
Posted by "pauloricardomg (via GitHub)" <gi...@apache.org>.
pauloricardomg commented on code in PR #313:
URL: https://github.com/apache/cassandra-sidecar/pull/313#discussion_r2764500768
##########
server/src/main/java/org/apache/cassandra/sidecar/lifecycle/ProcessRuntimeConfiguration.java:
##########
@@ -128,6 +128,7 @@ public ProcessBuilder buildStartCommand(String pidFileLocation, Path stdoutFileL
startCassandraCmd.add(cassandraBin().toString());
startCassandraCmd.add("-p");
startCassandraCmd.add(pidFileLocation);
+ startCassandraCmd.add("-R"); // Allow running as root (required for Cassandra 5.0+ when running as root)
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-400- Fixing sidecar’s ProcessLifecycleProviderIntegrationTest() failure in root mode [cassandra-sidecar]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on code in PR #313:
URL: https://github.com/apache/cassandra-sidecar/pull/313#discussion_r2761645136
##########
server/src/main/java/org/apache/cassandra/sidecar/lifecycle/ProcessRuntimeConfiguration.java:
##########
@@ -128,6 +128,7 @@ public ProcessBuilder buildStartCommand(String pidFileLocation, Path stdoutFileL
startCassandraCmd.add(cassandraBin().toString());
startCassandraCmd.add("-p");
startCassandraCmd.add(pidFileLocation);
+ startCassandraCmd.add("-R"); // Allow running as root (required for Cassandra 5.0+ when running as root)
Review Comment:
I think adding this flag to production code is dangerous. Looking at [CASSANDRA-8142](https://issues.apache.org/jira/browse/CASSANDRA-8142) the idea is to prevent this behavior by default for good reasons. I would propose that we alternatively look into having the ability to provide optional extra args that we can configure for testing purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-400- Fixing sidecar’s ProcessLifecycleProviderIntegrationTest() failure in root mode [cassandra-sidecar]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh merged PR #313:
URL: https://github.com/apache/cassandra-sidecar/pull/313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org