You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/11/26 01:41:32 UTC

[GitHub] [zookeeper] maoling edited a comment on pull request #1541: ZOOKEEPER-4004:ZKUtil.visitSubTreeDFSHelper use method with recursive may occur some question

maoling edited a comment on pull request #1541:
URL: https://github.com/apache/zookeeper/pull/1541#issuecomment-733734206


   > I did some tests, it is seem ok, should i commit it ?
   
   @zengchao1212 Yes, you really need to add more unit tests  because the new implementation/behaviour of `visitSubTreeDFSHelper` is very different from the old one. Not only the order of output, but also the size of output sometimes


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org