[groovy] branch GROOVY_3_0_X updated: GROOVY-9331: shuffled() DGM method shuffles wrong list

[pa...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

paulk pushed a commit to branch GROOVY_3_0_X
in repository https://gitbox.apache.org/repos/asf/groovy.git


The following commit(s) were added to refs/heads/GROOVY_3_0_X by this push:
     new b1846ac  GROOVY-9331: shuffled() DGM method shuffles wrong list
b1846ac is described below

commit b1846ac24a8dd6b18ff936936241d591bd4176ab
Author: Paul King <pa...@asert.com.au>
AuthorDate: Tue Dec 10 07:26:02 2019 +1000

    GROOVY-9331: shuffled() DGM method shuffles wrong list
---
 src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java b/src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java
index ea986f4..b398ba7 100644
--- a/src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java
+++ b/src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java
@@ -12121,7 +12121,7 @@ public class DefaultGroovyMethods extends DefaultGroovyMethodsSupport {
      */
     public static <T> List<T> shuffled(List<T> self) {
         List<T> copy = new ArrayList(self);
-        Collections.shuffle(self);
+        Collections.shuffle(copy);
         return copy;
     }
 
@@ -12142,7 +12142,7 @@ public class DefaultGroovyMethods extends DefaultGroovyMethodsSupport {
      */
     public static <T> List<T> shuffled(List<T> self, Random rnd) {
         List<T> copy = new ArrayList(self);
-        Collections.shuffle(self, rnd);
+        Collections.shuffle(copy, rnd);
         return copy;
     }