You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2022/04/12 09:28:40 UTC

[GitHub] [celix] PengZheng commented on a diff in pull request #414: Fix rsalist race

PengZheng commented on code in PR #414:
URL: https://github.com/apache/celix/pull/414#discussion_r848206922


##########
bundles/remote_services/topology_manager/src/topology_manager.c:
##########
@@ -209,7 +209,6 @@ celix_status_t topologyManager_rsaAdded(void * handle, service_reference_pt unus
 
 	celixThreadMutex_lock(&manager->rsaListLock);
 	arrayList_add(manager->rsaList, rsa);
-    celixThreadMutex_unlock(&manager->rsaListLock);
 
 	// add already imported services to new rsa
     celixThreadMutex_lock(&manager->importedServicesLock);

Review Comment:
   Then we have to make sure ABBA deak-lock does not happen: `rsaListLock` should always be acquired before `importedServicesLock`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org