You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "globalbus (via GitHub)" <gi...@apache.org> on 2023/08/25 14:13:57 UTC
[GitHub] [camel-karaf] globalbus opened a new pull request, #242: CAMEL-19788 Simplify BlueprintCamelStateService getState calls
globalbus opened a new pull request, #242:
URL: https://github.com/apache/camel-karaf/pull/242
as described in https://issues.apache.org/jira/browse/CAMEL-19788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karaf] jbonofre commented on pull request #242: CAMEL-19788 Simplify BlueprintCamelStateService getState calls
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #242:
URL: https://github.com/apache/camel-karaf/pull/242#issuecomment-1693441693
Agree to keep it on Camel 3.x. For Camel 4.x, I'm working on the refactoring but it's not ready yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karaf] globalbus commented on pull request #242: CAMEL-19788 Simplify BlueprintCamelStateService getState calls
Posted by "globalbus (via GitHub)" <gi...@apache.org>.
globalbus commented on PR #242:
URL: https://github.com/apache/camel-karaf/pull/242#issuecomment-1693458078
rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-19788 Simplify BlueprintCamelStateService getState calls [camel-karaf]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre closed pull request #242: CAMEL-19788 Simplify BlueprintCamelStateService getState calls
URL: https://github.com/apache/camel-karaf/pull/242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karaf] globalbus commented on pull request #242: CAMEL-19788 Simplify BlueprintCamelStateService getState calls
Posted by "globalbus (via GitHub)" <gi...@apache.org>.
globalbus commented on PR #242:
URL: https://github.com/apache/camel-karaf/pull/242#issuecomment-1693862188
I found [comment](https://github.com/apache/camel-karaf/blob/077c151fa7c683a442cc0624b5976eb44ba3e9d6/components/camel-blueprint/src/main/java/org/apache/camel/blueprint/handler/CamelNamespaceHandler.java#L320) that is definitely not true.
For right now, there is single BlueprintCamelStateService for each blueprint context (opposite to karaf BlueprintStateService implementation). So maybe it's better to register this bean in OSGi instead, to really have only one Service?
Why I'm touching it? I'm using karaf BundleService.getInfo as a part of healthcheck of my application. If I have around 1000 bundles with camel in blueprint, I also have 1000 BlueprintCamelStateService and it's must be called 1000 times per each bundle. Not so very brilliant idea. A lot of iterating over states map (with mostly one object in it) and a lot of temporary objects for garbage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-19788 Simplify BlueprintCamelStateService getState calls [camel-karaf]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #242:
URL: https://github.com/apache/camel-karaf/pull/242#issuecomment-2082956933
@globalbus I propose to use the "new" camel-karaf: GH issue, etc. Please, can you open a new PR based on `main` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org