You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by zh...@apache.org on 2023/10/11 08:06:04 UTC

[dolphinscheduler] 02/40: feat: Add others scopes for release tool (#14844)

This is an automated email from the ASF dual-hosted git repository.

zhongjiajie pushed a commit to branch 3.2.0-release
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git

commit 9d4f9a745771fe8f2c3cb4b9250b75f6cee04092
Author: Jay Chung <zh...@gmail.com>
AuthorDate: Sat Sep 2 10:14:21 2023 +0800

    feat: Add others scopes for release tool (#14844)
    
    Co-authored-by: caishunfeng <ca...@gmail.com>
    (cherry picked from commit 46c0eb48c6e4729b953df2523cac16b5be3887a5)
---
 tools/release/github/changelog.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/release/github/changelog.py b/tools/release/github/changelog.py
index 517d6b0b49..76c2c4152f 100644
--- a/tools/release/github/changelog.py
+++ b/tools/release/github/changelog.py
@@ -51,6 +51,7 @@ class Changelog:
         self.improvements = []
         self.documents = []
         self.chores = []
+        self.others = []
 
     def generate(self) -> str:
         """Generate changelog."""
@@ -77,6 +78,9 @@ class Changelog:
         if self.chores:
             detail = f"## Chore{self.changelog_prefix}{self._convert(self.chores)}{self.changelog_suffix}"
             final.append(detail)
+        if self.others:
+            detail = f"## Others{self.changelog_prefix}{self._convert(self.others)}{self.changelog_suffix}"
+            final.append(detail)
         return "\n".join(final)
 
     @staticmethod
@@ -105,11 +109,7 @@ class Changelog:
             elif self._is_chore(pr):
                 self.chores.append(pr)
             else:
-                raise KeyError(
-                    "There must at least one of labels `feature|bug|improvement|document|chore`"
-                    "but it do not, pr: %s",
-                    pr["html_url"],
-                )
+                self.others.append(pr)
 
     def _is_feature(self, pr: Dict) -> bool:
         """Belong to feature pull requests."""