You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/11 15:56:18 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #28801: [SPARK-31970][CORE] Make MDC configuration step be consistent between setLocalProperty and log4j.properties

cloud-fan commented on a change in pull request #28801:
URL: https://github.com/apache/spark/pull/28801#discussion_r438895926



##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -965,4 +962,5 @@ private[spark] object Executor {
   // task is fully deserialized. When possible, the TaskContext.getLocalProperty call should be
   // used instead.
   val taskDeserializationProps: ThreadLocal[Properties] = new ThreadLocal[Properties]
+  val MDC = "mdc."

Review comment:
       this is too short... I'm ok to just hardcode it in the code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org