You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "magicgoody (via GitHub)" <gi...@apache.org> on 2023/08/31 13:36:15 UTC
[GitHub] [beam] magicgoody opened a new pull request, #28259: Publish Checkstyle Results
magicgoody opened a new pull request, #28259:
URL: https://github.com/apache/beam/pull/28259
This PR was created to add an action that visualize the results of Checkstyle tests and adds them to the workflow summary page.
The action requires additional permissions:
checks: write (allow to add test result to workflow summary page)
Example runs:
no error: https://github.com/magicgoody/beam/actions/runs/5964470451
with error: https://github.com/magicgoody/beam/actions/runs/5949179444
Example screenshots:
Checkstyle result without violations

Checkstyle result with violations

------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28259: Publish Checkstyle Results
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28259:
URL: https://github.com/apache/beam/pull/28259#issuecomment-1702537712
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #28259: Publish Checkstyle Results
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #28259:
URL: https://github.com/apache/beam/pull/28259#discussion_r1312987932
##########
.github/workflows/beam_PreCommit_Spotless.yml:
##########
@@ -94,4 +94,9 @@ jobs:
uses: actions/upload-artifact@v3
with:
name: java-code-coverage-report
- path: "**/build/reports/checkstyle/*.xml"
\ No newline at end of file
+ path: "**/build/reports/checkstyle/*.xml"
+ - name: Publish checkstyle check
+ uses: jwgmeligmeyling/checkstyle-github-action@master
Review Comment:
```suggestion
uses: jwgmeligmeyling/checkstyle-github-action@v1
```
Generally when we use 3rd party actions, we should pin to a tag. This is less likely to randomly break, and the infra team will only allowlist actions that are pinned to tags
##########
.github/workflows/beam_PreCommit_Spotless.yml:
##########
@@ -94,4 +94,9 @@ jobs:
uses: actions/upload-artifact@v3
with:
name: java-code-coverage-report
- path: "**/build/reports/checkstyle/*.xml"
\ No newline at end of file
+ path: "**/build/reports/checkstyle/*.xml"
+ - name: Publish checkstyle check
+ uses: jwgmeligmeyling/checkstyle-github-action@master
Review Comment:
I created a jira ticket with infra (may not be publicly visible) to allow list this action @ v1 https://issues.apache.org/jira/browse/INFRA-24948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #28259: Publish Checkstyle Results
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #28259:
URL: https://github.com/apache/beam/pull/28259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] magicgoody commented on a diff in pull request #28259: Publish Checkstyle Results
Posted by "magicgoody (via GitHub)" <gi...@apache.org>.
magicgoody commented on code in PR #28259:
URL: https://github.com/apache/beam/pull/28259#discussion_r1314382391
##########
.github/workflows/beam_PreCommit_Spotless.yml:
##########
@@ -94,4 +94,9 @@ jobs:
uses: actions/upload-artifact@v3
with:
name: java-code-coverage-report
- path: "**/build/reports/checkstyle/*.xml"
\ No newline at end of file
+ path: "**/build/reports/checkstyle/*.xml"
+ - name: Publish checkstyle check
+ uses: jwgmeligmeyling/checkstyle-github-action@master
Review Comment:
Okay, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #28259: Publish Checkstyle Results
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #28259:
URL: https://github.com/apache/beam/pull/28259#discussion_r1321729326
##########
.github/workflows/beam_PreCommit_Spotless.yml:
##########
@@ -94,4 +94,9 @@ jobs:
uses: actions/upload-artifact@v3
with:
name: java-code-coverage-report
- path: "**/build/reports/checkstyle/*.xml"
\ No newline at end of file
+ path: "**/build/reports/checkstyle/*.xml"
+ - name: Publish checkstyle check
+ uses: jwgmeligmeyling/checkstyle-github-action@master
Review Comment:
The ticket was approved, merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org