[jira] [Commented] (STREAMS-423) reboot: cleanup source code using import .*;

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STREAMS-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550244#comment-15550244 ] 

ASF GitHub Bot commented on STREAMS-423:
----------------------------------------

Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/289#discussion_r82089943
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java ---
    @@ -18,22 +18,39 @@
     
     package org.apache.streams.twitter.provider;
     
    +import com.fasterxml.jackson.core.JsonProcessingException;
    +import com.fasterxml.jackson.databind.ObjectMapper;
     import com.google.common.base.Preconditions;
     import com.google.common.collect.Lists;
     import com.google.common.collect.Queues;
    +import com.google.common.util.concurrent.Uninterruptibles;
    +import com.typesafe.config.Config;
    +import com.typesafe.config.ConfigFactory;
    +import com.typesafe.config.ConfigParseOptions;
     import org.apache.commons.lang.NotImplementedException;
    +import org.apache.streams.config.ComponentConfigurator;
    +import org.apache.streams.config.StreamsConfiguration;
    +import org.apache.streams.config.StreamsConfigurator;
     import org.apache.streams.core.DatumStatusCounter;
     import org.apache.streams.core.StreamsDatum;
     import org.apache.streams.core.StreamsProvider;
     import org.apache.streams.core.StreamsResultSet;
    +import org.apache.streams.jackson.StreamsJacksonMapper;
     import org.apache.streams.twitter.TwitterUserInformationConfiguration;
    +import org.apache.streams.twitter.converter.TwitterDateTimeFormat;
    +import org.apache.streams.twitter.pojo.Tweet;
     import org.apache.streams.util.ComponentUtils;
     import org.joda.time.DateTime;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     import twitter4j.*;
     import twitter4j.conf.ConfigurationBuilder;
     
    +import java.io.BufferedOutputStream;
    +import java.io.File;
    +import java.io.FileNotFoundException;
    +import java.io.FileOutputStream;
    +import java.io.PrintStream;
     import java.io.Serializable;
     import java.math.BigInteger;
     import java.util.*;
    --- End diff --
    
    corrected within streams-provider-twitter for this PR
    opened STREAMS-423 to correct project-wide


> reboot: cleanup source code using import .*;
> --------------------------------------------
>
>                 Key: STREAMS-423
>                 URL: https://issues.apache.org/jira/browse/STREAMS-423
>             Project: Streams
>          Issue Type: Task
>            Reporter: Steve Blackmon
>            Assignee: Steve Blackmon
>
> as ~smarthi mentioned, using import .*; is bad practice
> correct this in the >100 files where it occurs 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)