You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "gggyd123 (via GitHub)" <gi...@apache.org> on 2024/02/27 10:40:48 UTC
[PR] bugfix: fix sql exception when checking for the existence of the UNDO_LOG table on SQL server [incubator-seata]
gggyd123 opened a new pull request, #6380:
URL: https://github.com/apache/incubator-seata/pull/6380
…_LOG table on SQL server
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
fix sql exception when checking for the existence of the UNDO_LOG table on SQL server
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
fixes #6379
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix sql exception when checking for the existence of the UNDO_LOG table on SQL server [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6380:
URL: https://github.com/apache/incubator-seata/pull/6380#discussion_r1505308210
##########
changes/zh-cn/2.x.md:
##########
Review Comment:
Please add the author's information as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix sql exception when checking for the existence of the UNDO_LOG table on SQL server [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #6380:
URL: https://github.com/apache/incubator-seata/pull/6380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix sql exception when checking for the existence of the UNDO_LOG table on SQL server [incubator-seata]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6380:
URL: https://github.com/apache/incubator-seata/pull/6380#issuecomment-1968180428
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6380?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `50.00000%` with `1 lines` in your changes are missing coverage. Please review.
> Project coverage is 52.43%. Comparing base [(`3c98058`)](https://app.codecov.io/gh/apache/incubator-seata/commit/3c98058f78fd25d971f198821e9d4064a55f4c26?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`60c61be`)](https://app.codecov.io/gh/apache/incubator-seata/pull/6380?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: Current head 60c61be differs from pull request most recent head 73795e5. Consider uploading reports for the commit 73795e5 to get more accurate results
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/6380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #6380 +/- ##
============================================
+ Coverage 52.40% 52.43% +0.02%
Complexity 5244 5244
============================================
Files 924 924
Lines 32066 32068 +2
Branches 3833 3833
============================================
+ Hits 16805 16814 +9
+ Misses 13607 13598 -9
- Partials 1654 1656 +2
```
| [Files](https://app.codecov.io/gh/apache/incubator-seata/pull/6380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...source/undo/sqlserver/SqlServerUndoLogManager.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cm0tZGF0YXNvdXJjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvcm0vZGF0YXNvdXJjZS91bmRvL3NxbHNlcnZlci9TcWxTZXJ2ZXJVbmRvTG9nTWFuYWdlci5qYXZh) | `11.42% <50.00%> (+2.33%)` | :arrow_up: |
... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6380/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org