You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2016/05/31 15:41:56 UTC

Review Request 48078: Add tests for the HDFS plugin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48078/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-1006
    https://issues.apache.org/jira/browse/RANGER-1006


Repository: ranger


Description
-------

Currently, there are no functioning tests in the Ranger source for the HDFS plugin. This task is to add some tests.

See attached for a patch which uses a custom RangerAdminClient which just reads in some policies from a file (generated offline using the Admin). A MiniDfsCluster is started using the RangerHdfsAuthorizer for authorization.


Diffs
-----

  hdfs-agent/pom.xml f5e42eb 
  hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/HDFSRangerTest.java PRE-CREATION 
  hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/HdfsClientTester.java ff2802a 
  hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/RangerAdminClientImpl.java PRE-CREATION 
  hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/TestRangerServiceHdfs.java 053fbb8 
  hdfs-agent/src/test/resources/hdfs-policies.json PRE-CREATION 
  hdfs-agent/src/test/resources/ranger-hdfs-security.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/48078/diff/


Testing
-------


Thanks,

Colm O hEigeartaigh


Re: Review Request 48078: Add tests for the HDFS plugin

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48078/#review135660
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On May 31, 2016, 3:41 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48078/
> -----------------------------------------------------------
> 
> (Updated May 31, 2016, 3:41 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1006
>     https://issues.apache.org/jira/browse/RANGER-1006
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently, there are no functioning tests in the Ranger source for the HDFS plugin. This task is to add some tests.
> 
> See attached for a patch which uses a custom RangerAdminClient which just reads in some policies from a file (generated offline using the Admin). A MiniDfsCluster is started using the RangerHdfsAuthorizer for authorization.
> 
> 
> Diffs
> -----
> 
>   hdfs-agent/pom.xml f5e42eb 
>   hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/HDFSRangerTest.java PRE-CREATION 
>   hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/HdfsClientTester.java ff2802a 
>   hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/RangerAdminClientImpl.java PRE-CREATION 
>   hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/TestRangerServiceHdfs.java 053fbb8 
>   hdfs-agent/src/test/resources/hdfs-policies.json PRE-CREATION 
>   hdfs-agent/src/test/resources/ranger-hdfs-security.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48078/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>