You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/01/14 12:51:31 UTC
[GitHub] [incubator-iotdb] SilverNarcissus opened a new pull request #741:
[IOTDB-421] Fix merge problem
SilverNarcissus opened a new pull request #741: [IOTDB-421] Fix merge problem
URL: https://github.com/apache/incubator-iotdb/pull/741
After dividing storage groups by time partition, merge part contains a potential bug about merging different partition's data into one partition.
So I change the logic of merge and only merge the data from the same time partition
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jt2594838 commented on issue #741: [IOTDB-421]
Fix merge problem
Posted by GitBox <gi...@apache.org>.
jt2594838 commented on issue #741: [IOTDB-421] Fix merge problem
URL: https://github.com/apache/incubator-iotdb/pull/741#issuecomment-574166472
It is okay, but it seems you are trying to bypassing this problem instead of solving it directly.
Please also dig out the root fo this bug, or someone may have to one day.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] SilverNarcissus commented on issue #741:
[IOTDB-421] Fix merge problem
Posted by GitBox <gi...@apache.org>.
SilverNarcissus commented on issue #741: [IOTDB-421] Fix merge problem
URL: https://github.com/apache/incubator-iotdb/pull/741#issuecomment-574535076
This problem has been fixed at https://github.com/apache/incubator-iotdb/pull/743 more gracefully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] SilverNarcissus closed pull request #741:
[IOTDB-421] Fix merge problem
Posted by GitBox <gi...@apache.org>.
SilverNarcissus closed pull request #741: [IOTDB-421] Fix merge problem
URL: https://github.com/apache/incubator-iotdb/pull/741
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services