You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "RoyLee1224 (via GitHub)" <gi...@apache.org> on 2025/11/25 02:38:05 UTC

[PR] Close zh-TW translation gaps [airflow]

RoyLee1224 opened a new pull request, #58658:
URL: https://github.com/apache/airflow/pull/58658

Just realized that these translation keys should've been removed in #56173

```
filters.logicalDateTo
filters.logicalDateFrom
filters.runAfterTo
filters.runAfterFrom
```

I will open a separate PR to remove these keys from all files, keeping this PR focused on the zh-TW translations.

Also, as far as I know, we don't currently have a script to check for unused keys. I'll try to implement one.

<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of an existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Close zh-TW translation gaps [airflow]

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.

Lee-W commented on code in PR #58658:
URL: https://github.com/apache/airflow/pull/58658#discussion_r2558390339


##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/components.json:
##########
@@ -49,6 +49,13 @@
     "warning_one": "1 個警告",
     "warning_other": "{{count}} 個警告"
   },
+  "dateRangeFilter": {
+    "validation": {
+      "invalidDateFormat": "無效的日期格式",
+      "invalidTimeFormat": "無效的時間格式",
+      "startBeforeEnd": "開始日期/時間必須在結束日期/時間之前"

Review Comment:
   ```suggestion
         "startBeforeEnd": "開始時間必須在結束時間之前"
   ```
   
   Would it be better this way? "日期/時間" is not that easy to read



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Close zh-TW translation gaps [airflow]

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.

Lee-W merged PR #58658:
URL: https://github.com/apache/airflow/pull/58658


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Close zh-TW translation gaps [airflow]

Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.

RoyLee1224 commented on PR #58658:
URL: https://github.com/apache/airflow/pull/58658#issuecomment-3574029847

   Draft opened!  #58661


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Close zh-TW translation gaps [airflow]

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.

Lee-W commented on PR #58658:
URL: https://github.com/apache/airflow/pull/58658#issuecomment-3573582613

   > Also, as far as I know, we don't currently have a script to check for unused keys. I'll try to implement one.
   
   Great idea!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org