You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ilya Shishkov (Jira)" <ji...@apache.org> on 2024/09/06 15:45:00 UTC
[jira] [Comment Edited] (IGNITE-22920) Final cleanup of GridDhtTxFinishRequest
[ https://issues.apache.org/jira/browse/IGNITE-22920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873259#comment-17873259 ]
Ilya Shishkov edited comment on IGNITE-22920 at 9/6/24 3:44 PM:
----------------------------------------------------------------
{{GridDhtTxFinishRequest#partUpdateCounters()}} usage was removed in IGNITE-10078 [1]. Thus, this method seems to be useless.
Getter for {{GridDhtTxFinishRequest#pendingVers}} was removed in [2], but actually it was unused since initial commit.
{{GridDhtTxFinishRequest#writeVersion()}} usage was removed before first Ignite release in [3] and as I see {{GridDistributedTxPrepareRequest#writeVersion()}} is used instead [4-6].
{{GridDhtTxFinishRequest#isolation()}} was removed before first Ignite release: see [7, 8].
# [https://github.com/apache/ignite/commit/e7a90a445f09b0783918a0b5cfbeddee7102c45e#diff-0b00deac783b25444a9201a862ba487bb1f83de7dd319edd2b02064b8efebbeaL1426]
# [https://github.com/apache/ignite/commit/457a9ae4d3b0d6eef6e92a15f5ef79c15ccf1f95#diff-3ef6211e80513fc51e2185d3c1b59378aed8d18d2744e7a0dfa92018fba8d684L310]
# [https://github.com/apache/ignite/commit/0354a41b94e891273a06587c6cea95aaee15d995#diff-0b00deac783b25444a9201a862ba487bb1f83de7dd319edd2b02064b8efebbeaL735]
# [https://github.com/apache/ignite/commit/0354a41b94e891273a06587c6cea95aaee15d995#diff-0b00deac783b25444a9201a862ba487bb1f83de7dd319edd2b02064b8efebbeaR827]
# [https://github.com/apache/ignite/commit/0354a41b94e891273a06587c6cea95aaee15d995#diff-0b00deac783b25444a9201a862ba487bb1f83de7dd319edd2b02064b8efebbeaR910]
# [https://github.com/apache/ignite/commit/0354a41b94e891273a06587c6cea95aaee15d995#diff-0b00deac783b25444a9201a862ba487bb1f83de7dd319edd2b02064b8efebbeaR1029]
# [https://github.com/apache/ignite/commit/ab2d84c04682bbc9e678449c04b0b61ba8bbdd2c#diff-ab111c346798e53372d293986c88a10ec936f3a2ba4c50b70b186752f4aca168L656]
# [https://github.com/apache/ignite/commit/ab2d84c04682bbc9e678449c04b0b61ba8bbdd2c#diff-6e02d7ca4e5c62d7526b3c1abd085235c57844498623adab1d76f7f321dc13ecL504]
was (Author: shishkovilja):
{{GridDhtTxFinishRequest#partUpdateCounters()}} usage was removed in IGNITE-10078 [1]. Thus, this method seems to be useless.
Getter for {{GridDhtTxFinishRequest#pendingVers}} was removed in [2], but actually it was unused since initial commit.
{{GridDhtTxFinishRequest#writeVersion()}} and {{GridDhtTxFinishRequest#isolation()}} usages was removed before first Ignite release in [3] and [4, 5] respectively.
# https://github.com/apache/ignite/commit/e7a90a445f09b0783918a0b5cfbeddee7102c45e#diff-0b00deac783b25444a9201a862ba487bb1f83de7dd319edd2b02064b8efebbeaL1426
# https://github.com/apache/ignite/commit/457a9ae4d3b0d6eef6e92a15f5ef79c15ccf1f95#diff-3ef6211e80513fc51e2185d3c1b59378aed8d18d2744e7a0dfa92018fba8d684L310
# https://github.com/apache/ignite/commit/ab2d84c04682bbc9e678449c04b0b61ba8bbdd2c#diff-ab111c346798e53372d293986c88a10ec936f3a2ba4c50b70b186752f4aca168L186
# https://github.com/apache/ignite/commit/ab2d84c04682bbc9e678449c04b0b61ba8bbdd2c#diff-ab111c346798e53372d293986c88a10ec936f3a2ba4c50b70b186752f4aca168L656
# https://github.com/apache/ignite/commit/ab2d84c04682bbc9e678449c04b0b61ba8bbdd2c#diff-6e02d7ca4e5c62d7526b3c1abd085235c57844498623adab1d76f7f321dc13ecL504
> Final cleanup of GridDhtTxFinishRequest
> ---------------------------------------
>
> Key: IGNITE-22920
> URL: https://issues.apache.org/jira/browse/IGNITE-22920
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Ilya Shishkov
> Assignee: Ilya Shishkov
> Priority: Minor
> Labels: ise
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{GridDhtTxFinishRequest}} has redundant class members:
> # {{GridDhtTxFinishRequest#pendingVers}} field does not have getter and any other external read possibility.
> # {{GridDhtTxFinishRequest#partUpdateCounters()}} getter has no usages, moreover corresponding field {{#partUpdateCnt}} can not be updated: there are no constructor parameters or setter method. The same situation is with {{#writeVer}} and {{#isolation}} filelds.
> We have to figure out whether this is redundant code or whether we have *_lost some useful functionality_*.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)