You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2017/05/09 18:30:21 UTC
[kudu-CR] Clarify error for permitted max tablets at creation time
Will Berkeley has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6829
Change subject: Clarify error for permitted max tablets at creation time
......................................................................
Clarify error for permitted max tablets at creation time
Several users have been confused by the error returned when
trying to create a table with too many tablets. This patch
lengthens the error message so it's clearer that the restriction
is for table creation, and suggests the workaround of adding
range partitions.
Change-Id: I1f084e0ad37e0578eeeb8af00767fccb23e1b165
---
M src/kudu/master/catalog_manager.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/6829/1
--
To view, visit http://gerrit.cloudera.org:8080/6829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f084e0ad37e0578eeeb8af00767fccb23e1b165
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] Clarify error for permitted max tablets at creation time
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Clarify error for permitted max tablets at creation time
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f084e0ad37e0578eeeb8af00767fccb23e1b165
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Clarify error for permitted max tablets at creation time
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged.
Change subject: Clarify error for permitted max tablets at creation time
......................................................................
Clarify error for permitted max tablets at creation time
Several users have been confused by the error returned when
trying to create a table with too many tablets. This patch
lengthens the error message so it's clearer that the restriction
is for table creation, and suggests the workaround of adding
range partitions.
Change-Id: I1f084e0ad37e0578eeeb8af00767fccb23e1b165
Reviewed-on: http://gerrit.cloudera.org:8080/6829
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/client/client-test.cc
M src/kudu/master/catalog_manager.cc
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f084e0ad37e0578eeeb8af00767fccb23e1b165
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Clarify error for permitted max tablets at creation time
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6829
to look at the new patch set (#2).
Change subject: Clarify error for permitted max tablets at creation time
......................................................................
Clarify error for permitted max tablets at creation time
Several users have been confused by the error returned when
trying to create a table with too many tablets. This patch
lengthens the error message so it's clearer that the restriction
is for table creation, and suggests the workaround of adding
range partitions.
Change-Id: I1f084e0ad37e0578eeeb8af00767fccb23e1b165
---
M src/kudu/client/client-test.cc
M src/kudu/master/catalog_manager.cc
2 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/6829/2
--
To view, visit http://gerrit.cloudera.org:8080/6829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f084e0ad37e0578eeeb8af00767fccb23e1b165
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins