[GitHub] [pulsar] mattisonchao commented on a diff in pull request #16668: [fix][broker] Fix the managed ledger factory shutdown stuck due to scheduled executor shutdown first

[GitBox <gi...@apache.org>]

mattisonchao commented on code in PR #16668:
URL: https://github.com/apache/pulsar/pull/16668#discussion_r925708276


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java:
##########
@@ -596,7 +593,10 @@ public void closeFailed(ManagedLedgerException exception, Object ctx) {
             }
         }));
         entryCacheManager.clear();
-        return FutureUtil.waitForAll(futures);
+        return FutureUtil.waitForAll(futures).thenAccept(__ -> {

Review Comment:
   Maybe we can use `whenComplete` to cover the exception case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org