You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ajantha-bhat (via GitHub)" <gi...@apache.org> on 2023/05/18 12:00:16 UTC

[GitHub] [iceberg] ajantha-bhat opened a new pull request, #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

ajantha-bhat opened a new pull request, #7642:
URL: https://github.com/apache/iceberg/pull/7642

   Bumped Nessie version to 0.59.0
   https://github.com/projectnessie/nessie/releases/tag/nessie-0.59.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] nastra merged pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #7642:
URL: https://github.com/apache/iceberg/pull/7642


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#discussion_r1198800725


##########
flink/v1.15/build.gradle:
##########
@@ -152,6 +152,9 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
     }
     implementation(project(':iceberg-nessie')) {
       exclude group: 'com.google.code.findbugs', module: 'jsr305'
+      // Nessie brings Jackson dependencies of version 2.15.0 or later.

Review Comment:
   Also, for the shadowJar issue with Nessie version bump (with Jackson 2.15.1),  
   check the logs here
   https://github.com/apache/iceberg/actions/runs/5013686487/jobs/8987072724



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] ajantha-bhat commented on pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#issuecomment-1554402597

   cc: @snazy, @dimas-b, @nastra   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#discussion_r1198926511


##########
flink/v1.17/build.gradle:
##########
@@ -152,6 +152,9 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
     }
     implementation(project(':iceberg-nessie')) {
       exclude group: 'com.google.code.findbugs', module: 'jsr305'
+      // Nessie brings Jackson dependencies of version 2.15.0 or later.
+      // These are multi-release jars and doesn't work with Java-8 shadowJar plugin.

Review Comment:
   Oh, if we just bump the Nessie version, the build will fail for shadowJar task for runtime hive, runtime flink, runtime spark with the error mentioned [here](https://github.com/apache/iceberg/actions/runs/5013686487/jobs/8987072724)
   
   The reason for failure is Nessie brings Jackson 2.15.1 as a dependency for runtime shadow jar tasks. But Jackson 2.15.0 onwards releases [multi-release jars](https://github.com/FasterXML/jackson-core/issues/897) (packs multiple versions of java classes).   Hence, the shadowJar tasks running on java 8 fails to build the uber jar.
   
   So, I am excluding Nessie's Jackson version. So, it uses Iceberg's jackson version  2.14.1 for building the uber jar.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] dimas-b commented on a diff in pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#discussion_r1198955388


##########
flink/v1.17/build.gradle:
##########
@@ -152,6 +152,9 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
     }
     implementation(project(':iceberg-nessie')) {
       exclude group: 'com.google.code.findbugs', module: 'jsr305'
+      // Nessie brings Jackson dependencies of version 2.15.0 or later.
+      // These are multi-release jars and doesn't work with Java-8 shadowJar plugin.

Review Comment:
   the dependency impact appears to be too broad to me... Is there perhaps some way to alter the declarations on the Nessie side to avoid the exclusions cascade?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] dimas-b commented on a diff in pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#discussion_r1198955917


##########
hive-runtime/build.gradle:
##########
@@ -43,6 +43,9 @@ project(':iceberg-hive-runtime') {
     }
     implementation(project(':iceberg-nessie')) {
       exclude group: 'com.google.code.findbugs', module: 'jsr305'
+      // Nessie brings Jackson dependencies of version 2.15.0 or later.
+      // These are multi-release jars and doesn't work with Java-8 shadowJar plugin.
+      exclude group: 'com.fasterxml.jackson', module: 'jackson-bom'

Review Comment:
   the dependency impact appears to be too broad to me... Is there perhaps some way to alter the declarations on the Nessie side to avoid the exclusions cascade?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#discussion_r1198964244


##########
hive-runtime/build.gradle:
##########
@@ -43,6 +43,9 @@ project(':iceberg-hive-runtime') {
     }
     implementation(project(':iceberg-nessie')) {
       exclude group: 'com.google.code.findbugs', module: 'jsr305'
+      // Nessie brings Jackson dependencies of version 2.15.0 or later.
+      // These are multi-release jars and doesn't work with Java-8 shadowJar plugin.
+      exclude group: 'com.fasterxml.jackson', module: 'jackson-bom'

Review Comment:
   Do you mean, Nessie can degrade the Jackson and do a minor release and Iceberg can bump to that version? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#discussion_r1198990104


##########
hive-runtime/build.gradle:
##########
@@ -43,6 +43,9 @@ project(':iceberg-hive-runtime') {
     }
     implementation(project(':iceberg-nessie')) {
       exclude group: 'com.google.code.findbugs', module: 'jsr305'
+      // Nessie brings Jackson dependencies of version 2.15.0 or later.
+      // These are multi-release jars and doesn't work with Java-8 shadowJar plugin.
+      exclude group: 'com.fasterxml.jackson', module: 'jackson-bom'

Review Comment:
   The dependencies look like this before the exclude. So, Unless I exclude the `jackson-bom`, the issue still exists for me. 
   
   ```
   +--- project :iceberg-nessie
   |    +--- project :iceberg-api (*)
   |    +--- project :iceberg-common (*)
   |    +--- project :iceberg-core (*)
   |    +--- project :iceberg-bundled-guava
   |    +--- org.projectnessie.nessie:nessie-client -> 0.59.0
   |    |    +--- com.fasterxml.jackson:jackson-bom:2.15.1 (*)
   |    |    +--- com.fasterxml.jackson.core:jackson-core -> 2.15.1 (*)
   |    |    +--- com.fasterxml.jackson.core:jackson-databind -> 2.15.1 (*)
   |    |    +--- com.fasterxml.jackson.core:jackson-annotations -> 2.15.1 (*)
   |    |    +--- org.eclipse.microprofile.openapi:microprofile-openapi-api:3.1
   |    |    \--- org.projectnessie.nessie:nessie-model:0.59.0
   |    |         +--- com.fasterxml.jackson:jackson-bom:2.15.1 (*)
   |    |         +--- com.fasterxml.jackson.core:jackson-databind -> 2.15.1 (*)
   |    |         \--- com.fasterxml.jackson.core:jackson-annotations -> 2.15.1 (*)
   |    +--- com.fasterxml.jackson.core:jackson-databind -> 2.15.1 (*)
   |    \--- com.fasterxml.jackson.core:jackson-core -> 2.15.1 (*)
   ```
   
   After excluding the `jackson-bom,`  dependencies look like this.
   ```
   +--- project :iceberg-nessie
   |    +--- project :iceberg-api (*)
   |    +--- project :iceberg-common (*)
   |    +--- project :iceberg-core (*)
   |    +--- project :iceberg-bundled-guava
   |    +--- org.projectnessie.nessie:nessie-client -> 0.59.0
   |    |    +--- com.fasterxml.jackson.core:jackson-core -> 2.14.1 (*)
   |    |    +--- com.fasterxml.jackson.core:jackson-databind -> 2.14.1 (*)
   |    |    +--- com.fasterxml.jackson.core:jackson-annotations -> 2.14.1 (*)
   |    |    +--- org.eclipse.microprofile.openapi:microprofile-openapi-api:3.1
   |    |    \--- org.projectnessie.nessie:nessie-model:0.59.0
   |    |         +--- com.fasterxml.jackson.core:jackson-databind -> 2.14.1 (*)
   |    |         \--- com.fasterxml.jackson.core:jackson-annotations -> 2.14.1 (*)
   |    +--- com.fasterxml.jackson.core:jackson-databind -> 2.14.1 (*)
   |    \--- com.fasterxml.jackson.core:jackson-core -> 2.14.1 (*)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#discussion_r1198785055


##########
flink/v1.15/build.gradle:
##########
@@ -152,6 +152,9 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
     }
     implementation(project(':iceberg-nessie')) {
       exclude group: 'com.google.code.findbugs', module: 'jsr305'
+      // Nessie brings Jackson dependencies of version 2.15.0 or later.

Review Comment:
   I am not really sure about the impact if Iceberg Nessie client uses a different version of Jackson than the Nessie server. 
   
   If there is a requirement of version matching, then I guess we need to make a Nessie release with older Jackson version 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] ajantha-bhat commented on pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#issuecomment-1556522407

   I have locally built the the Iceberg spark runtime jar with this changes and verified with latest Nessie docker image. It can work. 
   
   cc: @snazy, @dimas-b  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] ajantha-bhat commented on pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#issuecomment-1557560704

   @nastra, @dimas-b: I found the problem with our current shadow jar plugin. Using the standard shadow jar plugin has solved the multi-release jar issue. 
   So, I will simplify this PR. 
   
   But we need to merge https://github.com/apache/iceberg/pull/7681 first


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#discussion_r1201518622


##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java:
##########
@@ -37,13 +37,13 @@
 import org.projectnessie.error.NessieConflictException;
 import org.projectnessie.error.NessieNotFoundException;
 import org.projectnessie.error.NessieReferenceConflictException;
+import org.projectnessie.error.ReferenceConflicts;

Review Comment:
   Classes were moved to a different package in 0.59.0. Hence this change. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] ajantha-bhat commented on pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#issuecomment-1558519755

   @nastra, @Fokko: Can you please help in merging this? Thanks.   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] nastra commented on a diff in pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#discussion_r1198898844


##########
flink/v1.17/build.gradle:
##########
@@ -152,6 +152,9 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
     }
     implementation(project(':iceberg-nessie')) {
       exclude group: 'com.google.code.findbugs', module: 'jsr305'
+      // Nessie brings Jackson dependencies of version 2.15.0 or later.
+      // These are multi-release jars and doesn't work with Java-8 shadowJar plugin.

Review Comment:
   I'm actually not sure I understand what this comment means. Could you elaborate please?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#discussion_r1198926511


##########
flink/v1.17/build.gradle:
##########
@@ -152,6 +152,9 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
     }
     implementation(project(':iceberg-nessie')) {
       exclude group: 'com.google.code.findbugs', module: 'jsr305'
+      // Nessie brings Jackson dependencies of version 2.15.0 or later.
+      // These are multi-release jars and doesn't work with Java-8 shadowJar plugin.

Review Comment:
   Oh, if we just bump the Nessie version, the build will fail for shadowJar task for runtime hive, runtime flink, runtime spark with the error mentioned [here](https://github.com/apache/iceberg/actions/runs/5013686487/jobs/8987072724)
   
   The reason for failure is Nessie brings Jackson 2.15.1 as a dependency for runtime shadow jar tasks. But Jackson 2.15.0 onwards releases [multi-release jars](https://github.com/FasterXML/jackson-core/issues/897) (packs multiple versions of java classes).   Hence, the shadowJar tasks running on java 8 fails to build the uber jar.
   
   So, I am excluding Nessie's Jackson version (2.15.1). So, it uses Iceberg's jackson version  2.14.1 for building the uber jar.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] dimas-b commented on a diff in pull request #7642: Nessie: Bump Nessie version from 0.58.1 to 0.59.0

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#discussion_r1198966399


##########
hive-runtime/build.gradle:
##########
@@ -43,6 +43,9 @@ project(':iceberg-hive-runtime') {
     }
     implementation(project(':iceberg-nessie')) {
       exclude group: 'com.google.code.findbugs', module: 'jsr305'
+      // Nessie brings Jackson dependencies of version 2.15.0 or later.
+      // These are multi-release jars and doesn't work with Java-8 shadowJar plugin.
+      exclude group: 'com.fasterxml.jackson', module: 'jackson-bom'

Review Comment:
   No, I mean whether we can (and I'm not sure it's possible) to adjust Nessie dependency declarations such that Iceberg prefers its own version of Jackson, without repo-wide exclusions. I imagine similar changes may be required in all other downstream projects that build with java 8.



##########
hive-runtime/build.gradle:
##########
@@ -43,6 +43,9 @@ project(':iceberg-hive-runtime') {
     }
     implementation(project(':iceberg-nessie')) {
       exclude group: 'com.google.code.findbugs', module: 'jsr305'
+      // Nessie brings Jackson dependencies of version 2.15.0 or later.
+      // These are multi-release jars and doesn't work with Java-8 shadowJar plugin.
+      exclude group: 'com.fasterxml.jackson', module: 'jackson-bom'

Review Comment:
   No, I mean whether we can (and I'm not sure it's possible) adjust Nessie dependency declarations such that Iceberg prefers its own version of Jackson, without repo-wide exclusions. I imagine similar changes may be required in all other downstream projects that build with java 8.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org