You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@pivot.apache.org by Andrei Pozolotin <an...@gmail.com> on 2011/05/15 01:46:56 UTC

BUG: ListView selection with keys

BUG: ListView selection with keys

1) if you take this example
http://pivot.apache.org/tutorials/lists.html

2) select with mouse first item

3) then with keys: shift + down continue select until all list items are
selected

4) now ListView no longer responds to key strokes

this is on 64 bit  ubuntu 10.04 and jdk 1.6.0 _25

verified same bug in current trunk


Re: BUG: ListView selection with keys

Posted by Edvin Syse <ed...@sysedata.no>.
The functionality/implementation might not be to Greg's liking, but a 
similar solution would be nice to get in there :)

-- Edvin

Den 15.05.2011 16:24, skrev Andrei Pozolotin:
> Edvin: great! thank you. (I hope Greg applies it soon) Andrei.
>
> -------- Original Message --------
> Subject: Re: BUG: ListView selection with keys
> From: Edvin Syse <ed...@sysedata.no>
> To: user@pivot.apache.org
> Date: Sun 15 May 2011 05:23:47 AM CDT
>> Here's a patch against trunk that fixes the problem :)
>>
>> -- Edvin
>>
>> Den 15.05.2011 09:28, skrev Edvin Syse:
>>> When reading the source code of TerraListViewSkin, it looks like this is
>>> indeed the case. It should be a simple fix, though...
>>>
>>> Den 15.05.2011 09:11, skrev Edvin Syse:
>>>> Hm.. actually, you are right.. I get the same behavior as you describe.
>>>> Even when releasing shift, pressing up arrow doesn't release the
>>>> selection. It kind of looks like the "cursor" is on the first row,
>>>> because if you select let's say three elements in the middle of the
>>>> list
>>>> with shift+down, releasing shift and pressing up arrow will select the
>>>> element at the beginning of the list. But again, then pressing down
>>>> arrow should fix the problem in your example, but it doesn't...
>>>>
>>>> -- Edvin
>>>>
>>>> Den 15.05.2011 09:06, skrev Edvin Syse:
>>>>> I think you might be confused by the behavior of using arrow keys
>>>>> while
>>>>> holding down shift. When shift is pressed and you press the down
>>>>> arrow,
>>>>> the next element after the current selection is added to the
>>>>> selection.
>>>>> If you press the up arrow, the element in front of the current
>>>>> selection
>>>>> range is selected. Hence, when all the elements are selected, pressing
>>>>> up or down is not supposed to change anything. If you release
>>>>> shift, the
>>>>> selection changes (to one element), right?
>>>>>
>>>>> -- Edvin
>>>>>
>>>>> Den 15.05.2011 01:46, skrev Andrei Pozolotin:
>>>>>> BUG: ListView selection with keys
>>>>>>
>>>>>> 1) if you take this example
>>>>>> http://pivot.apache.org/tutorials/lists.html
>>>>>>
>>>>>> 2) select with mouse first item
>>>>>>
>>>>>> 3) then with keys: shift + down continue select until all list items
>>>>>> are
>>>>>> selected
>>>>>>
>>>>>> 4) now ListView no longer responds to key strokes
>>>>>>
>>>>>> this is on 64 bit ubuntu 10.04 and jdk 1.6.0 _25
>>>>>>
>>>>>> verified same bug in current trunk
>>>>>>
>

Re: BUG: ListView selection with keys

Posted by Edvin Syse <ed...@sysedata.no>.
I'll do it tonight :)

Den 15.05.2011 17:00, skrev Chris Bartlett:
> Could one of you please create a JIRA ticket for this issue and attach
> the patch to it.
> https://issues.apache.org/jira/browse/PIVOT
> When doing so, please make sure you check tick the box that grants
> permission to use the patch.
>
> Due to the similarity with ListViews, this issue might also apply to
> TableViews.
>
> Chris
>
> On 15 May 2011 21:24, Andrei Pozolotin <andrei.pozolotin@gmail.com
> <ma...@gmail.com>> wrote:
>
>     Edvin: great! thank you. (I hope Greg applies it soon) Andrei.
>
>
>     -------- Original Message  --------
>     Subject: Re: BUG: ListView selection with keys
>     From: Edvin Syse <ed...@sysedata.no> <ma...@sysedata.no>
>     To: user@pivot.apache.org <ma...@pivot.apache.org>
>     Date: Sun 15 May 2011 05:23:47 AM CDT
>>     Here's a patch against trunk that fixes the problem :)
>>
>>     -- Edvin
>>
>>     Den 15.05.2011 09:28, skrev Edvin Syse:
>>>     When reading the source code of TerraListViewSkin, it looks like
>>>     this is
>>>     indeed the case. It should be a simple fix, though...
>>>
>>>     Den 15.05.2011 09:11, skrev Edvin Syse:
>>>>     Hm.. actually, you are right.. I get the same behavior as you
>>>>     describe.
>>>>     Even when releasing shift, pressing up arrow doesn't release the
>>>>     selection. It kind of looks like the "cursor" is on the first row,
>>>>     because if you select let's say three elements in the middle of
>>>>     the list
>>>>     with shift+down, releasing shift and pressing up arrow will
>>>>     select the
>>>>     element at the beginning of the list. But again, then pressing down
>>>>     arrow should fix the problem in your example, but it doesn't...
>>>>
>>>>     -- Edvin
>>>>
>>>>     Den 15.05.2011 09:06, skrev Edvin Syse:
>>>>>     I think you might be confused by the behavior of using arrow
>>>>>     keys while
>>>>>     holding down shift. When shift is pressed and you press the
>>>>>     down arrow,
>>>>>     the next element after the current selection is added to the
>>>>>     selection.
>>>>>     If you press the up arrow, the element in front of the current
>>>>>     selection
>>>>>     range is selected. Hence, when all the elements are selected,
>>>>>     pressing
>>>>>     up or down is not supposed to change anything. If you release
>>>>>     shift, the
>>>>>     selection changes (to one element), right?
>>>>>
>>>>>     -- Edvin
>>>>>
>>>>>     Den 15.05.2011 01:46, skrev Andrei Pozolotin:
>>>>>>     BUG: ListView selection with keys
>>>>>>
>>>>>>     1) if you take this example
>>>>>>     http://pivot.apache.org/tutorials/lists.html
>>>>>>
>>>>>>     2) select with mouse first item
>>>>>>
>>>>>>     3) then with keys: shift + down continue select until all list
>>>>>>     items
>>>>>>     are
>>>>>>     selected
>>>>>>
>>>>>>     4) now ListView no longer responds to key strokes
>>>>>>
>>>>>>     this is on 64 bit ubuntu 10.04 and jdk 1.6.0 _25
>>>>>>
>>>>>>     verified same bug in current trunk
>>>>>>
>
>

Re: BUG: ListView selection with keys

Posted by Edvin Syse <ed...@sysedata.no>.
OK, I'll subscribe to the dev list now and post a suggestion hopefully 
during the weekend :)

Den 20.05.2011 13:58, skrev Greg Brown:
> That would be great. Why don't you put your suggestions out to the dev list first and then we can add them to the ticket when the details have been worked out?
>
> On May 20, 2011, at 5:03 AM, Edvin Syse wrote:
>
>> I've just updated to latest trunk, still the same issue. I do agree that the current behavior when holding shift and selecting up/down is not as most users will expect, but my patch suggestion doesn't change that, it just makes it possible to unselect after every item in the list has been selected.
>>
>> I'd be happy to take a shot at creating a suggestion for a better overall selection/navigation strategy if you'd like, more in the lines of Windows Explorer functionality, but this patch will atleast solve the immediate problem. What's the ticket for the long term solution, I'd love to take a look?
>>
>> -- Edvin
>>
>> Den 19.05.2011 01:39, skrev Sandro Martini:
>>> Hi all,
>>> I've just do some fixes in the same classes (not only Greg does :-) ),
>>> so in the JIRA ticket (
>>> https://issues.apache.org/jira/browse/PIVOT-744 ) you can find an
>>> updated patch, and some new comments ... particularly in the usability
>>> field.
>>> Note that even Tables and Trees should have the same behavior ...
>>>
>>> Can you try to update Pivot sources from the trunk and retry ?
>>> So you can even try to execute (under tests)
>>> multiple_selection_list.bxml , multiple_selection_table.bxml ,
>>> multiple_selection_tree.bxml
>>>
>>> What do you think (post here and/or in the issue, thanks) ?
>>>
>>>
>>> For a long-term (and of course more complete) solution of selection
>>> and navigation with keystrokes we have a ticket (and related
>>> discussions, but some things are still to see if/how to do), but for
>>> the 2.1 release ... it's a field where I and Chris have much interers
>>> ... and any comment is welcome.
>>>
>>>
>>> Thanks to all,
>>> Sandro
>

Re: BUG: ListView selection with keys

Posted by Greg Brown <gk...@verizon.net>.
That would be great. Why don't you put your suggestions out to the dev list first and then we can add them to the ticket when the details have been worked out?

On May 20, 2011, at 5:03 AM, Edvin Syse wrote:

> I've just updated to latest trunk, still the same issue. I do agree that the current behavior when holding shift and selecting up/down is not as most users will expect, but my patch suggestion doesn't change that, it just makes it possible to unselect after every item in the list has been selected.
> 
> I'd be happy to take a shot at creating a suggestion for a better overall selection/navigation strategy if you'd like, more in the lines of Windows Explorer functionality, but this patch will atleast solve the immediate problem. What's the ticket for the long term solution, I'd love to take a look?
> 
> -- Edvin
> 
> Den 19.05.2011 01:39, skrev Sandro Martini:
>> Hi all,
>> I've just do some fixes in the same classes (not only Greg does :-) ),
>> so in the JIRA ticket (
>> https://issues.apache.org/jira/browse/PIVOT-744 ) you can find an
>> updated patch, and some new comments ... particularly in the usability
>> field.
>> Note that even Tables and Trees should have the same behavior ...
>> 
>> Can you try to update Pivot sources from the trunk and retry ?
>> So you can even try to execute (under tests)
>> multiple_selection_list.bxml , multiple_selection_table.bxml ,
>> multiple_selection_tree.bxml
>> 
>> What do you think (post here and/or in the issue, thanks) ?
>> 
>> 
>> For a long-term (and of course more complete) solution of selection
>> and navigation with keystrokes we have a ticket (and related
>> discussions, but some things are still to see if/how to do), but for
>> the 2.1 release ... it's a field where I and Chris have much interers
>> ... and any comment is welcome.
>> 
>> 
>> Thanks to all,
>> Sandro


Re: BUG: ListView selection with keys

Posted by Edvin Syse <ed...@sysedata.no>.
I've just updated to latest trunk, still the same issue. I do agree that 
the current behavior when holding shift and selecting up/down is not as 
most users will expect, but my patch suggestion doesn't change that, it 
just makes it possible to unselect after every item in the list has been 
selected.

I'd be happy to take a shot at creating a suggestion for a better 
overall selection/navigation strategy if you'd like, more in the lines 
of Windows Explorer functionality, but this patch will atleast solve the 
immediate problem. What's the ticket for the long term solution, I'd 
love to take a look?

-- Edvin

Den 19.05.2011 01:39, skrev Sandro Martini:
> Hi all,
> I've just do some fixes in the same classes (not only Greg does :-) ),
> so in the JIRA ticket (
> https://issues.apache.org/jira/browse/PIVOT-744 ) you can find an
> updated patch, and some new comments ... particularly in the usability
> field.
> Note that even Tables and Trees should have the same behavior ...
>
> Can you try to update Pivot sources from the trunk and retry ?
> So you can even try to execute (under tests)
> multiple_selection_list.bxml , multiple_selection_table.bxml ,
> multiple_selection_tree.bxml
>
> What do you think (post here and/or in the issue, thanks) ?
>
>
> For a long-term (and of course more complete) solution of selection
> and navigation with keystrokes we have a ticket (and related
> discussions, but some things are still to see if/how to do), but for
> the 2.1 release ... it's a field where I and Chris have much interers
> ... and any comment is welcome.
>
>
> Thanks to all,
> Sandro

Re: BUG: ListView selection with keys

Posted by Sandro Martini <sa...@gmail.com>.
Hi all,
I've just do some fixes in the same classes (not only Greg does :-) ),
so in the JIRA ticket (
https://issues.apache.org/jira/browse/PIVOT-744 ) you can find an
updated patch, and some new comments ... particularly in the usability
field.
Note that even Tables and Trees should have the same behavior ...

Can you try to update Pivot sources from the trunk and retry ?
So you can even try to execute (under tests)
multiple_selection_list.bxml , multiple_selection_table.bxml ,
multiple_selection_tree.bxml

What do you think (post here and/or in the issue, thanks) ?


For a long-term (and of course more complete) solution of selection
and navigation with keystrokes we have a ticket (and related
discussions, but some things are still to see if/how to do), but for
the 2.1 release ... it's a field where I and Chris have much interers
... and any comment is welcome.


Thanks to all,
Sandro

Re: BUG: ListView selection with keys

Posted by Edvin Syse <ed...@sysedata.no>.
Done. Refined the patch a bit as well:

https://issues.apache.org/jira/browse/PIVOT-744

Den 15.05.2011 17:00, skrev Chris Bartlett:
> Could one of you please create a JIRA ticket for this issue and attach
> the patch to it.
> https://issues.apache.org/jira/browse/PIVOT
> When doing so, please make sure you check tick the box that grants
> permission to use the patch.
>
> Due to the similarity with ListViews, this issue might also apply to
> TableViews.
>
> Chris
>
> On 15 May 2011 21:24, Andrei Pozolotin <andrei.pozolotin@gmail.com
> <ma...@gmail.com>> wrote:
>
>     Edvin: great! thank you. (I hope Greg applies it soon) Andrei.
>
>
>     -------- Original Message  --------
>     Subject: Re: BUG: ListView selection with keys
>     From: Edvin Syse <ed...@sysedata.no> <ma...@sysedata.no>
>     To: user@pivot.apache.org <ma...@pivot.apache.org>
>     Date: Sun 15 May 2011 05:23:47 AM CDT
>>     Here's a patch against trunk that fixes the problem :)
>>
>>     -- Edvin
>>
>>     Den 15.05.2011 09:28, skrev Edvin Syse:
>>>     When reading the source code of TerraListViewSkin, it looks like
>>>     this is
>>>     indeed the case. It should be a simple fix, though...
>>>
>>>     Den 15.05.2011 09:11, skrev Edvin Syse:
>>>>     Hm.. actually, you are right.. I get the same behavior as you
>>>>     describe.
>>>>     Even when releasing shift, pressing up arrow doesn't release the
>>>>     selection. It kind of looks like the "cursor" is on the first row,
>>>>     because if you select let's say three elements in the middle of
>>>>     the list
>>>>     with shift+down, releasing shift and pressing up arrow will
>>>>     select the
>>>>     element at the beginning of the list. But again, then pressing down
>>>>     arrow should fix the problem in your example, but it doesn't...
>>>>
>>>>     -- Edvin
>>>>
>>>>     Den 15.05.2011 09:06, skrev Edvin Syse:
>>>>>     I think you might be confused by the behavior of using arrow
>>>>>     keys while
>>>>>     holding down shift. When shift is pressed and you press the
>>>>>     down arrow,
>>>>>     the next element after the current selection is added to the
>>>>>     selection.
>>>>>     If you press the up arrow, the element in front of the current
>>>>>     selection
>>>>>     range is selected. Hence, when all the elements are selected,
>>>>>     pressing
>>>>>     up or down is not supposed to change anything. If you release
>>>>>     shift, the
>>>>>     selection changes (to one element), right?
>>>>>
>>>>>     -- Edvin
>>>>>
>>>>>     Den 15.05.2011 01:46, skrev Andrei Pozolotin:
>>>>>>     BUG: ListView selection with keys
>>>>>>
>>>>>>     1) if you take this example
>>>>>>     http://pivot.apache.org/tutorials/lists.html
>>>>>>
>>>>>>     2) select with mouse first item
>>>>>>
>>>>>>     3) then with keys: shift + down continue select until all list
>>>>>>     items
>>>>>>     are
>>>>>>     selected
>>>>>>
>>>>>>     4) now ListView no longer responds to key strokes
>>>>>>
>>>>>>     this is on 64 bit ubuntu 10.04 and jdk 1.6.0 _25
>>>>>>
>>>>>>     verified same bug in current trunk
>>>>>>
>
>

Re: BUG: ListView selection with keys

Posted by Chris Bartlett <cb...@gmail.com>.
Could one of you please create a JIRA ticket for this issue and attach the
patch to it.
https://issues.apache.org/jira/browse/PIVOT
When doing so, please make sure you check tick the box that grants
permission to use the patch.

Due to the similarity with ListViews, this issue might also apply to
TableViews.

Chris

On 15 May 2011 21:24, Andrei Pozolotin <an...@gmail.com> wrote:

>  Edvin: great! thank you. (I hope Greg applies it soon) Andrei.
>
>
> -------- Original Message  --------
> Subject: Re: BUG: ListView selection with keys
> From: Edvin Syse <ed...@sysedata.no> <ed...@sysedata.no>
> To: user@pivot.apache.org
> Date: Sun 15 May 2011 05:23:47 AM CDT
>
> Here's a patch against trunk that fixes the problem :)
>
> -- Edvin
>
> Den 15.05.2011 09:28, skrev Edvin Syse:
>
> When reading the source code of TerraListViewSkin, it looks like this is
> indeed the case. It should be a simple fix, though...
>
> Den 15.05.2011 09:11, skrev Edvin Syse:
>
> Hm.. actually, you are right.. I get the same behavior as you describe.
> Even when releasing shift, pressing up arrow doesn't release the
> selection. It kind of looks like the "cursor" is on the first row,
> because if you select let's say three elements in the middle of the list
> with shift+down, releasing shift and pressing up arrow will select the
> element at the beginning of the list. But again, then pressing down
> arrow should fix the problem in your example, but it doesn't...
>
> -- Edvin
>
> Den 15.05.2011 09:06, skrev Edvin Syse:
>
> I think you might be confused by the behavior of using arrow keys while
> holding down shift. When shift is pressed and you press the down arrow,
> the next element after the current selection is added to the selection.
> If you press the up arrow, the element in front of the current selection
> range is selected. Hence, when all the elements are selected, pressing
> up or down is not supposed to change anything. If you release shift, the
> selection changes (to one element), right?
>
> -- Edvin
>
> Den 15.05.2011 01:46, skrev Andrei Pozolotin:
>
> BUG: ListView selection with keys
>
> 1) if you take this example
> http://pivot.apache.org/tutorials/lists.html
>
> 2) select with mouse first item
>
> 3) then with keys: shift + down continue select until all list items
> are
> selected
>
> 4) now ListView no longer responds to key strokes
>
> this is on 64 bit ubuntu 10.04 and jdk 1.6.0 _25
>
> verified same bug in current trunk
>
>
>

Re: BUG: ListView selection with keys

Posted by Andrei Pozolotin <an...@gmail.com>.
Edvin: great! thank you. (I hope Greg applies it soon) Andrei.

-------- Original Message  --------
Subject: Re: BUG: ListView selection with keys
From: Edvin Syse <ed...@sysedata.no>
To: user@pivot.apache.org
Date: Sun 15 May 2011 05:23:47 AM CDT
> Here's a patch against trunk that fixes the problem :)
>
> -- Edvin
>
> Den 15.05.2011 09:28, skrev Edvin Syse:
>> When reading the source code of TerraListViewSkin, it looks like this is
>> indeed the case. It should be a simple fix, though...
>>
>> Den 15.05.2011 09:11, skrev Edvin Syse:
>>> Hm.. actually, you are right.. I get the same behavior as you describe.
>>> Even when releasing shift, pressing up arrow doesn't release the
>>> selection. It kind of looks like the "cursor" is on the first row,
>>> because if you select let's say three elements in the middle of the
>>> list
>>> with shift+down, releasing shift and pressing up arrow will select the
>>> element at the beginning of the list. But again, then pressing down
>>> arrow should fix the problem in your example, but it doesn't...
>>>
>>> -- Edvin
>>>
>>> Den 15.05.2011 09:06, skrev Edvin Syse:
>>>> I think you might be confused by the behavior of using arrow keys
>>>> while
>>>> holding down shift. When shift is pressed and you press the down
>>>> arrow,
>>>> the next element after the current selection is added to the
>>>> selection.
>>>> If you press the up arrow, the element in front of the current
>>>> selection
>>>> range is selected. Hence, when all the elements are selected, pressing
>>>> up or down is not supposed to change anything. If you release
>>>> shift, the
>>>> selection changes (to one element), right?
>>>>
>>>> -- Edvin
>>>>
>>>> Den 15.05.2011 01:46, skrev Andrei Pozolotin:
>>>>> BUG: ListView selection with keys
>>>>>
>>>>> 1) if you take this example
>>>>> http://pivot.apache.org/tutorials/lists.html
>>>>>
>>>>> 2) select with mouse first item
>>>>>
>>>>> 3) then with keys: shift + down continue select until all list items
>>>>> are
>>>>> selected
>>>>>
>>>>> 4) now ListView no longer responds to key strokes
>>>>>
>>>>> this is on 64 bit ubuntu 10.04 and jdk 1.6.0 _25
>>>>>
>>>>> verified same bug in current trunk
>>>>>


Re: BUG: ListView selection with keys

Posted by Edvin Syse <ed...@sysedata.no>.
Here's a patch against trunk that fixes the problem :)

-- Edvin

Den 15.05.2011 09:28, skrev Edvin Syse:
> When reading the source code of TerraListViewSkin, it looks like this is
> indeed the case. It should be a simple fix, though...
>
> Den 15.05.2011 09:11, skrev Edvin Syse:
>> Hm.. actually, you are right.. I get the same behavior as you describe.
>> Even when releasing shift, pressing up arrow doesn't release the
>> selection. It kind of looks like the "cursor" is on the first row,
>> because if you select let's say three elements in the middle of the list
>> with shift+down, releasing shift and pressing up arrow will select the
>> element at the beginning of the list. But again, then pressing down
>> arrow should fix the problem in your example, but it doesn't...
>>
>> -- Edvin
>>
>> Den 15.05.2011 09:06, skrev Edvin Syse:
>>> I think you might be confused by the behavior of using arrow keys while
>>> holding down shift. When shift is pressed and you press the down arrow,
>>> the next element after the current selection is added to the selection.
>>> If you press the up arrow, the element in front of the current selection
>>> range is selected. Hence, when all the elements are selected, pressing
>>> up or down is not supposed to change anything. If you release shift, the
>>> selection changes (to one element), right?
>>>
>>> -- Edvin
>>>
>>> Den 15.05.2011 01:46, skrev Andrei Pozolotin:
>>>> BUG: ListView selection with keys
>>>>
>>>> 1) if you take this example
>>>> http://pivot.apache.org/tutorials/lists.html
>>>>
>>>> 2) select with mouse first item
>>>>
>>>> 3) then with keys: shift + down continue select until all list items
>>>> are
>>>> selected
>>>>
>>>> 4) now ListView no longer responds to key strokes
>>>>
>>>> this is on 64 bit ubuntu 10.04 and jdk 1.6.0 _25
>>>>
>>>> verified same bug in current trunk
>>>>

Re: BUG: ListView selection with keys

Posted by Edvin Syse <ed...@sysedata.no>.
When reading the source code of TerraListViewSkin, it looks like this is 
indeed the case. It should be a simple fix, though...

Den 15.05.2011 09:11, skrev Edvin Syse:
> Hm.. actually, you are right.. I get the same behavior as you describe.
> Even when releasing shift, pressing up arrow doesn't release the
> selection. It kind of looks like the "cursor" is on the first row,
> because if you select let's say three elements in the middle of the list
> with shift+down, releasing shift and pressing up arrow will select the
> element at the beginning of the list. But again, then pressing down
> arrow should fix the problem in your example, but it doesn't...
>
> -- Edvin
>
> Den 15.05.2011 09:06, skrev Edvin Syse:
>> I think you might be confused by the behavior of using arrow keys while
>> holding down shift. When shift is pressed and you press the down arrow,
>> the next element after the current selection is added to the selection.
>> If you press the up arrow, the element in front of the current selection
>> range is selected. Hence, when all the elements are selected, pressing
>> up or down is not supposed to change anything. If you release shift, the
>> selection changes (to one element), right?
>>
>> -- Edvin
>>
>> Den 15.05.2011 01:46, skrev Andrei Pozolotin:
>>> BUG: ListView selection with keys
>>>
>>> 1) if you take this example
>>> http://pivot.apache.org/tutorials/lists.html
>>>
>>> 2) select with mouse first item
>>>
>>> 3) then with keys: shift + down continue select until all list items are
>>> selected
>>>
>>> 4) now ListView no longer responds to key strokes
>>>
>>> this is on 64 bit ubuntu 10.04 and jdk 1.6.0 _25
>>>
>>> verified same bug in current trunk
>>>

Re: BUG: ListView selection with keys

Posted by Edvin Syse <ed...@sysedata.no>.
Hm.. actually, you are right.. I get the same behavior as you describe. 
Even when releasing shift, pressing up arrow doesn't release the 
selection. It kind of looks like the "cursor" is on the first row, 
because if you select let's say three elements in the middle of the list 
with shift+down, releasing shift and pressing up arrow will select the 
element at the beginning of the list. But again, then pressing down 
arrow should fix the problem in your example, but it doesn't...

-- Edvin

Den 15.05.2011 09:06, skrev Edvin Syse:
> I think you might be confused by the behavior of using arrow keys while
> holding down shift. When shift is pressed and you press the down arrow,
> the next element after the current selection is added to the selection.
> If you press the up arrow, the element in front of the current selection
> range is selected. Hence, when all the elements are selected, pressing
> up or down is not supposed to change anything. If you release shift, the
> selection changes (to one element), right?
>
> -- Edvin
>
> Den 15.05.2011 01:46, skrev Andrei Pozolotin:
>> BUG: ListView selection with keys
>>
>> 1) if you take this example
>> http://pivot.apache.org/tutorials/lists.html
>>
>> 2) select with mouse first item
>>
>> 3) then with keys: shift + down continue select until all list items are
>> selected
>>
>> 4) now ListView no longer responds to key strokes
>>
>> this is on 64 bit ubuntu 10.04 and jdk 1.6.0 _25
>>
>> verified same bug in current trunk
>>

Re: BUG: ListView selection with keys

Posted by Edvin Syse <ed...@sysedata.no>.
I think you might be confused by the behavior of using arrow keys while 
holding down shift. When shift is pressed and you press the down arrow, 
the next element after the current selection is added to the selection. 
If you press the up arrow, the element in front of the current selection 
range is selected. Hence, when all the elements are selected, pressing 
up or down is not supposed to change anything. If you release shift, the 
selection changes (to one element), right?

-- Edvin

Den 15.05.2011 01:46, skrev Andrei Pozolotin:
> BUG: ListView selection with keys
>
> 1) if you take this example
> http://pivot.apache.org/tutorials/lists.html
>
> 2) select with mouse first item
>
> 3) then with keys: shift + down continue select until all list items are
> selected
>
> 4) now ListView no longer responds to key strokes
>
> this is on 64 bit ubuntu 10.04 and jdk 1.6.0 _25
>
> verified same bug in current trunk
>