You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Leo Li (JIRA)" <ji...@apache.org> on 2006/08/11 11:14:13 UTC
[jira] Created: (HARMONY-1155) [classlib][luni]implement get
environment for 5.0
[classlib][luni]implement get environment for 5.0
-------------------------------------------------
Key: HARMONY-1155
URL: http://issues.apache.org/jira/browse/HARMONY-1155
Project: Harmony
Issue Type: New Feature
Components: Classlib
Reporter: Leo Li
Hi,
Harmony lacks the new feature of System.getenv(). I would like to implement the inner class that can be used by System.getenv() and the native code that gets the environment string from the os.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1155) [classlib][luni]implement get
environment for 5.0
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1155?page=all ]
Paulex Yang resolved HARMONY-1155.
----------------------------------
Resolution: Fixed
Leo, patch applied at revision r431560 with some changes, thanks a lot for this enhancement, I add some error handling codes to it, so please verify everything is OK.
> [classlib][luni]implement get environment for 5.0
> -------------------------------------------------
>
> Key: HARMONY-1155
> URL: http://issues.apache.org/jira/browse/HARMONY-1155
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Leo Li
> Assigned To: Paulex Yang
> Attachments: patch.diff, patch.diff, patch.sh, patch.sh
>
>
> Hi,
> Harmony lacks the new feature of System.getenv(). I would like to implement the inner class that can be used by System.getenv() and the native code that gets the environment string from the os.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1155) [classlib][luni]implement get
environment for 5.0
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1155?page=all ]
Paulex Yang closed HARMONY-1155.
--------------------------------
Verifiedy by Leo.
> [classlib][luni]implement get environment for 5.0
> -------------------------------------------------
>
> Key: HARMONY-1155
> URL: http://issues.apache.org/jira/browse/HARMONY-1155
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Leo Li
> Assigned To: Paulex Yang
> Attachments: patch.diff, patch.diff, patch.sh, patch.sh
>
>
> Hi,
> Harmony lacks the new feature of System.getenv(). I would like to implement the inner class that can be used by System.getenv() and the native code that gets the environment string from the os.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1155) [classlib][luni]implement get
environment for 5.0
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1155?page=comments#action_12427498 ]
Paulex Yang commented on HARMONY-1155:
--------------------------------------
Leo, I have some concern on this patch,
First, seems you construct the property string in native codes by JNI API NewStringUTF, but I suspect it cannot handle the non-ascii env names and values.
Second, I don't understand why you concat all properties to a long string separated by "\n" and return in JNI method, and then in Java codes separate them, any reason not to return a array directly?
would you please help to clarify? thank you.
> [classlib][luni]implement get environment for 5.0
> -------------------------------------------------
>
> Key: HARMONY-1155
> URL: http://issues.apache.org/jira/browse/HARMONY-1155
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Leo Li
> Assigned To: Paulex Yang
> Attachments: patch.diff, patch.sh
>
>
> Hi,
> Harmony lacks the new feature of System.getenv(). I would like to implement the inner class that can be used by System.getenv() and the native code that gets the environment string from the os.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1155) [classlib][luni]implement get
environment for 5.0
Posted by "Leo Li (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1155?page=comments#action_12436423 ]
Leo Li commented on HARMONY-1155:
---------------------------------
Verified. Sorry for the delay.
> [classlib][luni]implement get environment for 5.0
> -------------------------------------------------
>
> Key: HARMONY-1155
> URL: http://issues.apache.org/jira/browse/HARMONY-1155
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Leo Li
> Assigned To: Paulex Yang
> Attachments: patch.diff, patch.diff, patch.sh, patch.sh
>
>
> Hi,
> Harmony lacks the new feature of System.getenv(). I would like to implement the inner class that can be used by System.getenv() and the native code that gets the environment string from the os.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1155) [classlib][luni]implement get
environment for 5.0
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1155?page=all ]
Paulex Yang reassigned HARMONY-1155:
------------------------------------
Assignee: Paulex Yang
> [classlib][luni]implement get environment for 5.0
> -------------------------------------------------
>
> Key: HARMONY-1155
> URL: http://issues.apache.org/jira/browse/HARMONY-1155
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Leo Li
> Assigned To: Paulex Yang
> Attachments: patch.diff, patch.sh
>
>
> Hi,
> Harmony lacks the new feature of System.getenv(). I would like to implement the inner class that can be used by System.getenv() and the native code that gets the environment string from the os.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1155) [classlib][luni]implement get
environment for 5.0
Posted by "Leo Li (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1155?page=all ]
Leo Li updated HARMONY-1155:
----------------------------
Attachment: patch.diff
patch.sh
Hi,
Would you pls apply my patch?
Thanks.
Good luck!
> [classlib][luni]implement get environment for 5.0
> -------------------------------------------------
>
> Key: HARMONY-1155
> URL: http://issues.apache.org/jira/browse/HARMONY-1155
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Leo Li
> Attachments: patch.diff, patch.sh
>
>
> Hi,
> Harmony lacks the new feature of System.getenv(). I would like to implement the inner class that can be used by System.getenv() and the native code that gets the environment string from the os.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1155) [classlib][luni]implement get
environment for 5.0
Posted by "Leo Li (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1155?page=all ]
Leo Li updated HARMONY-1155:
----------------------------
Attachment: patch.diff
patch.sh
Hi, Paulex:
Thank you for your reminding.
In the patch, native code will return a byte array that contains the environment variables that will be decoded in java to string.
Will any one try the patch?
Thank you.
> [classlib][luni]implement get environment for 5.0
> -------------------------------------------------
>
> Key: HARMONY-1155
> URL: http://issues.apache.org/jira/browse/HARMONY-1155
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Leo Li
> Assigned To: Paulex Yang
> Attachments: patch.diff, patch.diff, patch.sh, patch.sh
>
>
> Hi,
> Harmony lacks the new feature of System.getenv(). I would like to implement the inner class that can be used by System.getenv() and the native code that gets the environment string from the os.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira