You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/04 11:50:07 UTC
[GitHub] [spark] akiyamaneko opened a new pull request #30249: [SPARK-33342 WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
akiyamaneko opened a new pull request #30249:
URL: https://github.com/apache/spark/pull/30249
### What changes were proposed in this pull request?
fix the wrong url and display name of blocking thread in threadDump page.
The blockingThreadId variable passed to the page should be of string type instead of Option type.
### Why are the changes needed?
blocking threadId in the ui page is not displayed well, and the corresponding url cannot be redirected normally
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
The pr only involves minor changes to the page and does not affect other functions,
The manual test results are as follows. The thread name displayed on the page is correct, and you can click on the URL to jump to the corresponding url
![Uploading shows_ok.gif…]()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-722642991
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-722642991
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-722641741
**[Test build #130660 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130660/testReport)** for PR 30249 at commit [`17d12b6`](https://github.com/apache/spark/commit/17d12b611bcc53ae19f98f7ed55bcdbcc60530cf).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-721687797
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-721687339
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-722589261
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35271/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-721687797
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-722551432
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-722553485
**[Test build #130660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130660/testReport)** for PR 30249 at commit [`17d12b6`](https://github.com/apache/spark/commit/17d12b611bcc53ae19f98f7ed55bcdbcc60530cf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-722576880
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35271/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-722553485
**[Test build #130660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130660/testReport)** for PR 30249 at commit [`17d12b6`](https://github.com/apache/spark/commit/17d12b611bcc53ae19f98f7ed55bcdbcc60530cf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-722853786
Thanks, merging to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-721687339
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-722589273
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akiyamaneko commented on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
akiyamaneko commented on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-721688213
friendly ping @gengliangwang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #30249:
URL: https://github.com/apache/spark/pull/30249
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-722589273
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akiyamaneko edited a comment on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
akiyamaneko edited a comment on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-721688213
friendly ping @gengliangwang @sarutak
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30249: [SPARK-33342][WEBUI] fix the wrong url and display name of blocking thread in threadDump page.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30249:
URL: https://github.com/apache/spark/pull/30249#issuecomment-722589290
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35271/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org