You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/06/23 07:22:03 UTC

[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3113: [SCB-2595] enable checkstyle missingSwitchDefault

liubao68 commented on code in PR #3113:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3113#discussion_r904666760


##########
foundations/foundation-protobuf/src/main/java/org/apache/servicecomb/foundation/protobuf/internal/schema/deserializer/DeserializerSchemaManager.java:
##########
@@ -234,6 +234,8 @@ protected <T> FieldSchema<T> createRepeatedSchema(Field protoField, PropertyDesc
           return StringRepeatedReadSchemas.create(protoField, propertyDescriptor);
         case BYTES:
           return BytesRepeatedReadSchemas.create(protoField, propertyDescriptor);
+        default:
+          throw new IllegalStateException("unknown proto field type: " + protoField.getType());

Review Comment:
   Maybe use ProtoUtils.throwNotSupportMerge(protoField, propertyDescriptor.getJavaType()); is better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org