You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/18 11:40:00 UTC
[jira] [Commented] (ARTEMIS-1329) JMS test
NoLocalSubscriberTest#testNoLocalReconnect fails with OpenWire protocol
(activemq-client JMS library)
[ https://issues.apache.org/jira/browse/ARTEMIS-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294859#comment-16294859 ]
ASF GitHub Bot commented on ARTEMIS-1329:
-----------------------------------------
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1725
ARTEMIS-1329 testNoLocalReconnect was failing with OpenWire protocol
Can anybody review this? This fixes the issue, but I find it weird to assign client ID to CID (connection ID) property. Although the same thing is done [here](https://github.com/apache/activemq-artemis/blob/master/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java#L83)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq-artemis-1 ARTEMIS-1329
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1725.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1725
----
commit 59418b8da5940748fed986d1a72f44f4313e16e2
Author: Stanislav Knot <sk...@redhat.com>
Date: 2017-12-18T11:28:30Z
ARTEMIS-1329 testNoLocalReconnect was failing with OpenWire protocol
----
> JMS test NoLocalSubscriberTest#testNoLocalReconnect fails with OpenWire protocol (activemq-client JMS library)
> --------------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-1329
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1329
> Project: ActiveMQ Artemis
> Issue Type: Test
> Components: Broker, OpenWire
> Affects Versions: 2.3.0
> Reporter: Jiri Daněk
>
> Consider test org.apache.activemq.artemis.tests.integration.jms.client.NoLocalSubscriberTest#testNoLocalReconnect.
> When it is adapted to run with multiple JMS clients, or when run from the standalone reproducer at https://github.com/jdanekrh/jms-reproducers/blob/NoLocalSubscriberTest/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/NoLocalSubscriberTest.java
> (the standalone reproducer requires a running broker to connect to), the test passes with Core and AMQP protocols,
> and fails with OpenWire at assertion
> {noformat}
> // now drain the subscription
> // we should not receive message M3, but we should receive message M4
> // However for some reason Artemis doesn't receive either
> TextMessage textMessage = (TextMessage) topicSubscriber.receive(1000);
> assertNotNull(textMessage);
> {noformat}
> With exception
> {noformat}
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertNotNull(Assert.java:621)
> at org.junit.Assert.assertNotNull(Assert.java:631)
> at org.apache.activemq.artemis.tests.integration.jms.client.NoLocalSubscriberTest.testNoLocalReconnect(NoLocalSubscriberTest.java:178)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at org.junit.runners.Suite.runChild(Suite.java:127)
> at org.junit.runners.Suite.runChild(Suite.java:26)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
> at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
> at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
> at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
> at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)