You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "matan-wonderful (via GitHub)" <gi...@apache.org> on 2026/06/08 08:22:10 UTC

[PR] fix(linker): handle empty pr issue regexp [devlake]

matan-wonderful opened a new pull request, #8911:
URL: https://github.com/apache/devlake/pull/8911

   ### Summary
   
   This PR fixes a linker crash when `prToIssueRegexp` is empty.
   
   Normal-mode projects can enable the linker metric without a configured regexp, which currently produces a linker task with an empty regexp. `PrepareTaskData` leaves `PrToIssueRegexp` nil in that case, and `LinkPrToIssue` later panics when it calls `FindAllString` on the nil regexp.
   
   Changes:
   
   - Skip linker metric pipeline generation when `prToIssueRegexp` is empty.
   - Reject explicit linker task options with an empty `prToIssueRegexp`.
   - Add a defensive nil-regexp guard in `LinkPrToIssue`.
   - Add unit coverage for empty and trimmed regexp handling.
   
   ### Does this close any open issues?
   
   No linked issue.
   
   ### Screenshots
   
   Not applicable.
   
   ### Other Information
   
   Validation:
   
   - `go test ./plugins/linker/tasks ./plugins/linker/impl`
   - `git diff --check`
   
   I also tried `go test ./plugins/linker/...`, but the linker e2e package requires `E2E_DB_URL` and fails immediately without that environment variable.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(linker): handle empty pr issue regexp [devlake]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8911:
URL: https://github.com/apache/devlake/pull/8911#issuecomment-6159588151

   This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(linker): handle empty pr issue regexp [devlake]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8911:
URL: https://github.com/apache/devlake/pull/8911#issuecomment-6028304778

   This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(linker): handle empty pr issue regexp [devlake]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #8911: fix(linker): handle empty pr issue regexp
URL: https://github.com/apache/devlake/pull/8911


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org