svn commit: r1885304 - /pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java

[ti...@apache.org]

Author: tilman
Date: Sat Jan  9 17:58:24 2021
New Revision: 1885304

URL: http://svn.apache.org/viewvc?rev=1885304&view=rev
Log:
PDFBOX-5017: change annotation for tests that don't need parameter

Modified:
    pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java

Modified: pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java?rev=1885304&r1=1885303&r2=1885304&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java (original)
+++ pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java Sat Jan  9 17:58:24 2021
@@ -111,6 +111,7 @@ import org.bouncycastle.util.CollectionS
 import org.bouncycastle.util.Selector;
 import org.bouncycastle.util.Store;
 import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.MethodSource;
 
@@ -272,22 +273,17 @@ class TestCreateSignature
      * @throws TSPException
      * @throws CertificateVerificationException 
      */
-    @ParameterizedTest
-	@MethodSource("signingTypes")
-    void testCreateSignedTimeStamp(boolean externallySign)
+    @Test
+    void testCreateSignedTimeStamp()
             throws IOException, CMSException, OperatorCreationException, GeneralSecurityException,
                    TSPException, CertificateVerificationException
     {
-        if (externallySign)
-        {
-            return; // runs only once, independent of externallySign
-        }
         if (tsa == null || tsa.isEmpty())
         {
             System.err.println("No TSA URL defined, test skipped");
             return;
         }
-        final String fileName = getOutputFileName("timestamped{0}.pdf", externallySign);
+        final String fileName = getOutputFileName("timestamped{0}.pdf", false);
         CreateSignedTimeStamp signing = new CreateSignedTimeStamp(tsa);
         signing.signDetached(new File(IN_DIR + "sign_me.pdf"), new File(OUT_DIR + fileName));
 
@@ -744,15 +740,10 @@ class TestCreateSignature
      * @throws CertificateVerificationException
      * @throws NoSuchAlgorithmException 
      */
-    @ParameterizedTest
-	@MethodSource("signingTypes")
-    void testCRL(boolean externallySign) throws IOException, CMSException, CertificateException, TSPException,
+    @Test
+    void testCRL() throws IOException, CMSException, CertificateException, TSPException,
             OperatorCreationException, CertificateVerificationException, NoSuchAlgorithmException
     {
-        if (externallySign)
-        {
-            return; // runs only once, independent of externallySign
-        }
         String hexSignature;
         try (BufferedReader bfr = 
             new BufferedReader(new InputStreamReader(new FileInputStream(IN_DIR + "hexsignature.txt"))))
@@ -810,15 +801,10 @@ class TestCreateSignature
      * @throws org.bouncycastle.operator.OperatorCreationException
      * @throws org.bouncycastle.cms.CMSException
      */
-    @ParameterizedTest
-	@MethodSource("signingTypes")
-    void testAddValidationInformation(boolean externallySign)
+    @Test
+    void testAddValidationInformation()
             throws IOException, GeneralSecurityException, OCSPException, OperatorCreationException, CMSException
     {
-        if (externallySign)
-        {
-            return; // runs only once, independent of externallySign
-        }
         File inFile = new File("target/pdfs", "notCertified_368835_Sig_en_201026090509.pdf");
         String name = inFile.getName();
         String substring = name.substring(0, name.lastIndexOf('.'));