[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #991: OAK-10273: Index-definition json created during oak-run reindex shoul…

["thomasmueller (via GitHub)" <gi...@apache.org>]

thomasmueller commented on code in PR #991:
URL: https://github.com/apache/jackrabbit-oak/pull/991#discussion_r1233796327


##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/IndexerSupport.java:
##########
@@ -121,7 +121,7 @@ public void updateIndexDefinitions(NodeBuilder rootBuilder) throws IOException,
 
     protected void dumpIndexDefinitions(NodeStore nodeStore) throws IOException {
         IndexDefinitionPrinter printer = new IndexDefinitionPrinter(nodeStore, indexHelper.getIndexPathService());
-        printer.setFilter("{\"properties\":[\"*\", \"-:childOrder\"],\"nodes\":[\"*\", \"-:index-definition\"]}");
+        printer.setFilter("{\"properties\":[\"*\", \"-:childOrder\"],\"nodes\":[\"*\", \"-:index-definition\", \"-:data\", \"-:suggest-data\"]}");

Review Comment:
   I'm not sure if this is actually correct.
   
   Isn't the dump needed for import? If yes, then that would mean if we don't export the ":data" node, import of an index would have to do a full reindex as the index data is empty...
   
   So, first we need to check where this dumpIndexDefinitions method is actually called from... unluckily, there is no documentation it seems.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org