You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by ja...@apache.org on 2023/01/24 15:39:33 UTC

[iceberg] branch master updated: AWS: Print logs whether Glue optimistic locking is used or not (#6358)

This is an automated email from the ASF dual-hosted git repository.

jackye pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new 89e603788a AWS: Print logs whether Glue optimistic locking is used or not (#6358)
89e603788a is described below

commit 89e603788a50be3c45ac11690551d6a8124dfe89
Author: Akira Ajisaka <ak...@amazon.com>
AuthorDate: Wed Jan 25 00:39:22 2023 +0900

    AWS: Print logs whether Glue optimistic locking is used or not (#6358)
---
 aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java b/aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java
index 94f533ea3c..db6e8ead7e 100644
--- a/aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java
+++ b/aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java
@@ -152,7 +152,13 @@ public class GlueCatalog extends BaseMetastoreCatalog
     if (properties.containsKey(CatalogProperties.LOCK_IMPL)) {
       return LockManagers.from(properties);
     } else if (SET_VERSION_ID.isNoop()) {
+      LOG.warn(
+          "Optimistic locking is not available in the environment. Using in-memory lock manager."
+              + " To ensure atomic transaction, please configure a distributed lock manager"
+              + " such as the DynamoDB lock manager.");
       return LockManagers.defaultLockManager();
+    } else {
+      LOG.debug("Using optimistic locking for Glue Data Catalog tables.");
     }
     return null;
   }