You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/12 20:59:59 UTC

[GitHub] [incubator-superset] MarcusSorealheis opened a new pull request #8033: fixed the bleeding dashboard chart issue

MarcusSorealheis opened a new pull request #8033: fixed the bleeding dashboard chart issue
URL: https://github.com/apache/incubator-superset/pull/8033
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   User mentioned Horizon chart was bleeding. I verified that it was and added simple fix. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   <img width="1134" alt="Screen Shot 2019-08-12 at 1 27 23 PM" src="https://user-images.githubusercontent.com/2353608/62897991-49ade800-bd09-11e9-9a7a-44690066b1b7.png">
   
   After:
   ![Screen Shot 2019-08-12 at 1 55 25 PM](https://user-images.githubusercontent.com/2353608/62898003-54687d00-bd09-11e9-990b-a27b32c22544.png)
   
   
   ### TEST PLAN
   Do we test CSS? I can add if we do, but I did not see that in the project. (honestly didn't look hard)
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org